https://github.com/torvalds/linux
Revision 51b3e2700177b89fdb0d985926ce777a7ad52b15 authored by Andrew Klossner on 12 March 2009, 12:36:39 UTC, committed by Jean Delvare on 12 March 2009, 12:36:39 UTC
f75375_probe calls i2c_get_clientdata to initialize the data pointer,
but there isn't yet any client data to get, and the value is never
used before the variable is assigned a new value seven lines later.

The call doesn't hurt anything and wastes only a couple of cycles.
The reason to fix it is because this module serves as an example to
hackers writing new hwmon drivers, and this part of the example is
confusing.

Signed-off-by: Andrew Klossner <andrew@cesa.opbu.xerox.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
1 parent e267d25
History
Tip revision: 51b3e2700177b89fdb0d985926ce777a7ad52b15 authored by Andrew Klossner on 12 March 2009, 12:36:39 UTC
hwmon: (f75375s) Remove unnecessary and confusing initialization
Tip revision: 51b3e27
File Mode Size
Documentation
arch
block
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
usr
virt
.gitignore -rw-r--r-- 867 bytes
.mailmap -rw-r--r-- 3.9 KB
COPYING -rw-r--r-- 18.3 KB
CREDITS -rw-r--r-- 91.3 KB
Kbuild -rw-r--r-- 2.4 KB
MAINTAINERS -rw-r--r-- 107.1 KB
Makefile -rw-r--r-- 53.2 KB
README -rw-r--r-- 16.7 KB
REPORTING-BUGS -rw-r--r-- 3.1 KB

README

back to top