https://github.com/torvalds/linux
Revision 53846574799884a04a4498f6342400d5c1423c79 authored by Bartlomiej Zolnierkiewicz on 08 December 2008, 16:52:05 UTC, committed by Bartlomiej Zolnierkiewicz on 08 December 2008, 16:52:05 UTC
IDE pmac host driver build fails with CONFIG_BLK_DEV_IDEDMA_PMAC=n
as reported by Kamalesh:

> drivers/ide/pmac.c: In function 'pmac_ide_set_pio_mode':
> drivers/ide/pmac.c:527: error: implicit declaration of function 'kauai_lookup_timing'
> drivers/ide/pmac.c:527: error: 'shasta_pio_timings' undeclared (first use in this function)
> drivers/ide/pmac.c:527: error: (Each undeclared identifier is reported only once
> drivers/ide/pmac.c:527: error: for each function it appears in.)
> drivers/ide/pmac.c:534: error: 'kauai_pio_timings' undeclared (first use in this function)
> drivers/ide/pmac.c: In function 'pmac_ide_do_resume':
> drivers/ide/pmac.c:914: error: 'IDE_WAKEUP_DELAY' undeclared (first use in this function)
> drivers/ide/pmac.c: At top level:
> drivers/ide/pmac.c:1007: error: 'pmac_ide_init_dma' undeclared here (not in a function)
> drivers/ide/pmac.c: In function 'pmac_ide_setup_device':
> drivers/ide/pmac.c:1107: error: 'IDE_WAKEUP_DELAY' undeclared (first use in this function)
> drivers/ide/pmac.c: In function 'pmac_ide_macio_attach':
> drivers/ide/pmac.c:1209: error: 'pmac_ide_hwif_t' has no member named 'dma_regs'
> drivers/ide/pmac.c:1210: error: 'pmac_ide_hwif_t' has no member named 'dma_regs'
> make[2]: *** [drivers/ide/pmac.o] Error 1

Fix it by removing the superfluous config option.

Reported-and-tested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
1 parent 1a65988
History
Tip revision: 53846574799884a04a4498f6342400d5c1423c79 authored by Bartlomiej Zolnierkiewicz on 08 December 2008, 16:52:05 UTC
ide: build-fix for CONFIG_BLK_DEV_IDEDMA_PMAC=n
Tip revision: 5384657
File Mode Size
internal
aead.h -rw-r--r-- 2.6 KB
aes.h -rw-r--r-- 859 bytes
algapi.h -rw-r--r-- 8.1 KB
authenc.h -rw-r--r-- 609 bytes
b128ops.h -rw-r--r-- 2.4 KB
ctr.h -rw-r--r-- 524 bytes
des.h -rw-r--r-- 403 bytes
gf128mul.h -rw-r--r-- 8.0 KB
hash.h -rw-r--r-- 4.1 KB
rng.h -rw-r--r-- 1.8 KB
scatterwalk.h -rw-r--r-- 3.4 KB
sha.h -rw-r--r-- 1.7 KB
skcipher.h -rw-r--r-- 2.7 KB
twofish.h -rw-r--r-- 613 bytes

back to top