Revision 552165bcf7060b998b4a9b5b86110b6a5e04dfd9 authored by David Rivshin on 28 April 2016, 01:25:25 UTC, committed by David S. Miller on 28 April 2016, 21:27:29 UTC
Commit 9e42f715264ff158478fa30eaed847f6e131366b ("drivers: net: cpsw: add
phy-handle parsing") saved the "phy-handle" phandle into a new cpsw_priv
field. However, phy connections are per-slave, so the phy_node field should
be in cpsw_slave_data rather than cpsw_priv.

This would go unnoticed in a single emac configuration. But in dual_emac
mode, the last "phy-handle" property parsed for either slave would be used
by both of them, causing them both to refer to the same phy_device.

Fixes: 9e42f715264f ("drivers: net: cpsw: add phy-handle parsing")
Signed-off-by: David Rivshin <drivshin@allworx.com>
Tested-by: Nicolas Chauvet <kwizart@gmail.com>
Tested-by: Andrew Goodbody <andrew.goodbody@cambrionix.com>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent bbdd09e
History
File Mode Size
Makefile -rw-r--r-- 386 bytes
rcu.h -rw-r--r-- 4.7 KB
rcutorture.c -rw-r--r-- 54.3 KB
srcu.c -rw-r--r-- 21.6 KB
sync.c -rw-r--r-- 6.7 KB
tiny.c -rw-r--r-- 6.8 KB
tiny_plugin.h -rw-r--r-- 4.6 KB
tree.c -rw-r--r-- 142.0 KB
tree.h -rw-r--r-- 29.1 KB
tree_plugin.h -rw-r--r-- 90.0 KB
tree_trace.c -rw-r--r-- 12.8 KB
update.c -rw-r--r-- 28.0 KB

back to top