https://github.com/torvalds/linux
Revision 5600f6986628dde8881734090588474f54a540a8 authored by Pavel Skripkin on 14 March 2022, 05:56:32 UTC, committed by Dmitry Torokhov on 15 March 2022, 01:15:11 UTC
Syzbot reported warning in usb_submit_urb() which is caused by wrong
endpoint type. There was a check for the number of endpoints, but not
for the type of endpoint.
Fix it by replacing old desc.bNumEndpoints check with
usb_find_common_endpoints() helper for finding endpoints
Fail log:
usb 5-1: BOGUS urb xfer, pipe 1 != type 3
WARNING: CPU: 2 PID: 48 at drivers/usb/core/urb.c:502 usb_submit_urb+0xed2/0x18a0 drivers/usb/core/urb.c:502
Modules linked in:
CPU: 2 PID: 48 Comm: kworker/2:2 Not tainted 5.17.0-rc6-syzkaller-00226-g07ebd38a0da2 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
Workqueue: usb_hub_wq hub_event
...
Call Trace:
<TASK>
aiptek_open+0xd5/0x130 drivers/input/tablet/aiptek.c:830
input_open_device+0x1bb/0x320 drivers/input/input.c:629
kbd_connect+0xfe/0x160 drivers/tty/vt/keyboard.c:1593
Fixes: 8e20cf2bce12 ("Input: aiptek - fix crash on detecting device without endpoints")
Reported-and-tested-by: syzbot+75cccf2b7da87fb6f84b@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Link: https://lore.kernel.org/r/20220308194328.26220-1-paskripkin@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent e941dc1
Tip revision: 5600f6986628dde8881734090588474f54a540a8 authored by Pavel Skripkin on 14 March 2022, 05:56:32 UTC
Input: aiptek - properly check endpoint type
Input: aiptek - properly check endpoint type
Tip revision: 5600f69
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs | ||
| befs | ||
| bfs | ||
| btrfs | ||
| cachefiles | ||
| ceph | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| crypto | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efivarfs | ||
| efs | ||
| erofs | ||
| exfat | ||
| exportfs | ||
| ext2 | ||
| ext4 | ||
| f2fs | ||
| fat | ||
| freevxfs | ||
| fscache | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hugetlbfs | ||
| iomap | ||
| isofs | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| kernfs | ||
| ksmbd | ||
| lockd | ||
| minix | ||
| netfs | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nilfs2 | ||
| nls | ||
| notify | ||
| ntfs | ||
| ntfs3 | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| orangefs | ||
| overlayfs | ||
| proc | ||
| pstore | ||
| qnx4 | ||
| qnx6 | ||
| quota | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| smbfs_common | ||
| squashfs | ||
| sysfs | ||
| sysv | ||
| tracefs | ||
| ubifs | ||
| udf | ||
| ufs | ||
| unicode | ||
| vboxsf | ||
| verity | ||
| xfs | ||
| zonefs | ||
| Kconfig | -rw-r--r-- | 9.6 KB |
| Kconfig.binfmt | -rw-r--r-- | 7.0 KB |
| Makefile | -rw-r--r-- | 4.6 KB |
| aio.c | -rw-r--r-- | 61.1 KB |
| anon_inodes.c | -rw-r--r-- | 8.1 KB |
| attr.c | -rw-r--r-- | 13.3 KB |
| bad_inode.c | -rw-r--r-- | 5.8 KB |
| binfmt_aout.c | -rw-r--r-- | 8.2 KB |
| binfmt_elf.c | -rw-r--r-- | 60.8 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 43.6 KB |
| binfmt_flat.c | -rw-r--r-- | 28.5 KB |
| binfmt_misc.c | -rw-r--r-- | 17.4 KB |
| binfmt_script.c | -rw-r--r-- | 4.2 KB |
| buffer.c | -rw-r--r-- | 88.4 KB |
| char_dev.c | -rw-r--r-- | 16.5 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.7 KB |
| coredump.c | -rw-r--r-- | 27.7 KB |
| d_path.c | -rw-r--r-- | 11.5 KB |
| dax.c | -rw-r--r-- | 46.6 KB |
| dcache.c | -rw-r--r-- | 86.0 KB |
| direct-io.c | -rw-r--r-- | 39.4 KB |
| drop_caches.c | -rw-r--r-- | 1.9 KB |
| eventfd.c | -rw-r--r-- | 12.0 KB |
| eventpoll.c | -rw-r--r-- | 64.1 KB |
| exec.c | -rw-r--r-- | 50.1 KB |
| fcntl.c | -rw-r--r-- | 23.8 KB |
| fhandle.c | -rw-r--r-- | 6.8 KB |
| file.c | -rw-r--r-- | 31.0 KB |
| file_table.c | -rw-r--r-- | 10.9 KB |
| filesystems.c | -rw-r--r-- | 6.5 KB |
| fs-writeback.c | -rw-r--r-- | 79.3 KB |
| fs_context.c | -rw-r--r-- | 17.7 KB |
| fs_parser.c | -rw-r--r-- | 10.7 KB |
| fs_pin.c | -rw-r--r-- | 1.9 KB |
| fs_struct.c | -rw-r--r-- | 3.4 KB |
| fs_types.c | -rw-r--r-- | 2.5 KB |
| fsopen.c | -rw-r--r-- | 11.0 KB |
| init.c | -rw-r--r-- | 6.1 KB |
| inode.c | -rw-r--r-- | 64.2 KB |
| internal.h | -rw-r--r-- | 5.2 KB |
| io-wq.c | -rw-r--r-- | 33.7 KB |
| io-wq.h | -rw-r--r-- | 5.1 KB |
| io_uring.c | -rw-r--r-- | 278.2 KB |
| ioctl.c | -rw-r--r-- | 24.0 KB |
| kernel_read_file.c | -rw-r--r-- | 4.4 KB |
| libfs.c | -rw-r--r-- | 40.0 KB |
| locks.c | -rw-r--r-- | 74.1 KB |
| mbcache.c | -rw-r--r-- | 12.0 KB |
| mount.h | -rw-r--r-- | 4.0 KB |
| mpage.c | -rw-r--r-- | 20.3 KB |
| namei.c | -rw-r--r-- | 133.7 KB |
| namespace.c | -rw-r--r-- | 111.4 KB |
| no-block.c | -rw-r--r-- | 478 bytes |
| nsfs.c | -rw-r--r-- | 6.6 KB |
| open.c | -rw-r--r-- | 34.7 KB |
| pipe.c | -rw-r--r-- | 35.9 KB |
| pnode.c | -rw-r--r-- | 15.1 KB |
| pnode.h | -rw-r--r-- | 2.0 KB |
| posix_acl.c | -rw-r--r-- | 23.8 KB |
| proc_namespace.c | -rw-r--r-- | 8.1 KB |
| read_write.c | -rw-r--r-- | 38.9 KB |
| readdir.c | -rw-r--r-- | 13.9 KB |
| remap_range.c | -rw-r--r-- | 13.8 KB |
| select.c | -rw-r--r-- | 34.7 KB |
| seq_file.c | -rw-r--r-- | 25.0 KB |
| signalfd.c | -rw-r--r-- | 8.7 KB |
| splice.c | -rw-r--r-- | 38.8 KB |
| stack.c | -rw-r--r-- | 2.5 KB |
| stat.c | -rw-r--r-- | 21.2 KB |
| statfs.c | -rw-r--r-- | 9.7 KB |
| super.c | -rw-r--r-- | 45.4 KB |
| sync.c | -rw-r--r-- | 10.1 KB |
| sysctls.c | -rw-r--r-- | 809 bytes |
| timerfd.c | -rw-r--r-- | 13.9 KB |
| userfaultfd.c | -rw-r--r-- | 54.6 KB |
| utimes.c | -rw-r--r-- | 7.6 KB |
| xattr.c | -rw-r--r-- | 27.4 KB |
Computing file changes ...
