Skip to main content

Browse the archive

Revision 563713e128e1b3ccbbd8cd369a117da1f91ddd58 authored by Benjamin Wang on 11 November 2022, 09:35:26 UTC, committed by Benjamin Wang on 11 November 2022, 09:35:26 UTC 
etcdserver: call the OnPreCommitUnsafe in unsafeCommit
 
`unsafeCommit` is called by both `(*batchTxBuffered) commit` and
`(*backend) defrag`. When users perform the defragmentation
operation, etcd doesn't update the consistent index. If etcd
crashes(e.g. panicking) in the process for whatever reason, then
etcd replays the WAL entries starting from the latest snapshot,
accordingly it may re-apply entries which might have already been
applied, eventually the revision isn't consistent with other members.

Refer to discussion in https://github.com/etcd-io/etcd/pull/14685

Signed-off-by: Benjamin Wang <wachao@vmware.com>
1 parent c2378be
Raw File
codecov.yml 
codecov:
  token: "6040de41-c073-4d6f-bbf8-d89256ef31e1"
  disable_default_path_fixes: true

fixes:
  - "go.etcd.io/etcd/api/v3/::api/"
  - "go.etcd.io/etcd/client/v3/::client/v3/"
  - "go.etcd.io/etcd/client/v2/::client/v2/"
  - "go.etcd.io/etcd/etcdctl/v3/::etcdctl/"
  - "go.etcd.io/etcd/pkg/v3/::pkg/"
  - "go.etcd.io/etcd/raft/v3/::raft/"
  - "go.etcd.io/etcd/server/v3/::server/"

ignore:
  - "**/*.pb.go"
  - "**/*.pb.gw.go"
  - "tests/**/*"
  - "go.etcd.io/etcd/tests/**/*"
back to top