Skip to main content

Browse the archive

https://github.com/mozilla/gecko-dev
16 June 2024, 00:10:27 UTC
Revision 56b1961b797875e601ab039de0d8aa5507839593 authored by Iain Ireland on 20 May 2024, 12:09:59 UTC, committed by Iain Ireland on 20 May 2024, 12:09:59 UTC 
Bug 1897150: Initialize thisValue on every comparator call r=jandem a=pascalc
 
I also considered setting this in ArraySortData::setComparatorArgs, but this matches the change we made for the descriptor.

The only data for the comparator call that is still constant is the comparator itself. I think that's still fine, so long as we trace it during a GC, which we do.

Differential Revision: https://phabricator.services.mozilla.com/D210749
1 parent fad3d6c
Raw File
Tip revision: 56b1961b797875e601ab039de0d8aa5507839593 authored by Iain Ireland on 20 May 2024, 12:09:59 UTC
Bug 1897150: Initialize thisValue on every comparator call r=jandem a=pascalc
Tip revision: 56b1961
.clang-format 
BasedOnStyle: Google
ColumnLimit: 80

# Prevent the loss of indentation with these macros
MacroBlockBegin: "^\
JS_BEGIN_MACRO|\
NS_INTERFACE_MAP_BEGIN|\
NS_INTERFACE_TABLE_HEAD|\
NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION|\
NS_IMPL_CYCLE_COLLECTION_.*_BEGIN|\
NS_INTERFACE_TABLE_HEAD_CYCLE_COLLECTION_INHERITED|\
NS_INTERFACE_TABLE_BEGIN|\
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED|\
NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED|\
NS_QUERYFRAME_HEAD$"
MacroBlockEnd: "^\
JS_END_MACRO|\
NS_INTERFACE_MAP_END|\
NS_IMPL_CYCLE_COLLECTION_.*_END|\
NS_INTERFACE_TABLE_END|\
NS_INTERFACE_TABLE_TAIL.*|\
NS_INTERFACE_MAP_END_.*|\
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END_INHERITED|\
NS_IMPL_CYCLE_COLLECTION_UNLINK_END_INHERITED|\
NS_QUERYFRAME_TAIL.*$"

SortIncludes: false
IndentPPDirectives: AfterHash
StatementMacros: [MARKUPMAP, ASSERT_TRUE, ASSERT_FALSE, TEST, CHECK]

# The Google coding style states:
# You should do this consistently within a single file, so, when modifying an
# existing file, use the style in that file.
# Let's be more prescriptive and default to the one used in the Mozilla
# coding style
DerivePointerAlignment: false
PointerAlignment: Left
back to top