56e085f | Kristiyan Kostadinov | 10 October 2023, 16:57:09 UTC | build: remove Windows CI check (#52140) (#55527) Based on recent discussions, these changes remove the Windows CI check because it has been too flaky for too long. Furthermore, we've concluded that the simulated file system in the compiler tests already catches the same set of bugs as running the tests on a real Windows system. PR Close #52140 (cherry picked from commit 5a969e06b7cc5971aaf9fb7fa5aab44561eb9872) PR Close #55527 | 25 April 2024, 15:48:45 UTC |
4127b29 | Alan Agius | 25 April 2024, 09:44:32 UTC | build: address failures in zone.js typings tests (#55527) Update zone.js typings tests to work PR Close #55527 | 25 April 2024, 15:48:45 UTC |
7490849 | Alan Agius | 25 April 2024, 07:39:22 UTC | build: make scripts for compatibility with Node.js 18.20+ (#55527) This commit enhances the ng-dev and other local scripts to ensure compatibility with Node.js 18.20+. This adjustment is essential for releasing this branch, as it would otherwise lack compatibility with that version. (cherry picked from commit 416d44092b04896d6f9dda0ff0eba429087d793a) PR Close #55527 | 25 April 2024, 15:48:45 UTC |
499f09a | Emma Twersky | 06 November 2023, 18:33:21 UTC | docs: add angular.dev banner (#52535) PR Close #52535 | 06 November 2023, 19:04:11 UTC |
ace0a68 | Alex Rickabaugh | 02 November 2023, 21:39:01 UTC | release: cut the v16.2.12 release | 02 November 2023, 21:41:54 UTC |
e092184 | Alex Castle | 01 November 2023, 23:08:34 UTC | fix(common): apply fixed_srcset_width values only to fixed srcsets (#52486) fix fixed_srcseet_width being incorrectly applied to responsive srcsets PR Close #52486 | 02 November 2023, 18:04:25 UTC |
64e4835 | Angular Robot | 19 October 2023, 16:07:43 UTC | build: update peter-evans/create-or-update-comment digest to 23ff157 (#52279) See associated pull request for more information. PR Close #52279 | 02 November 2023, 17:43:21 UTC |
03f4050 | arturovt | 08 September 2023, 18:35:55 UTC | fix(animations): remove `finish` listener once player is destroyed (#51136) This commit removes the `finish` listener from the Animation object once the animation is finished, effectively resolving a memory leak. Previously, the `finish` listener captured `this`, which prevented `this` from being garbage collected. PR Close #51136 | 02 November 2023, 17:29:41 UTC |
07efb49 | Mayuresh Dharwadkar | 29 October 2023, 11:16:37 UTC | docs: Fix typos (#52442) PR Close #52442 | 31 October 2023, 20:44:08 UTC |
873c4f2 | JoostK | 28 October 2023, 22:53:50 UTC | fix(compiler-cli): use originally used module specifier for transform functions (#52437) Prior to this change, the transform function would be referenced with a potentially relative import into an external declaration file. Such imports are not portable and should not be created in this context. This commit addresses the issue by threading though the originally used module specifier by means of the `Reference` type. Fixes #52324 PR Close #52437 | 31 October 2023, 20:42:52 UTC |
b3b4ae4 | JoostK | 28 October 2023, 19:59:19 UTC | fix(compiler-cli): properly emit literal types in input coercion function arguments (#52437) This commit fixes an issue where using literal types in the arguments of an input coercion function could result in emitting invalid output, due to an assumption that TypeScript makes when emitting literal types. Specifically, it takes the literal's text from its containing source file, but this breaks when the literal type node has been transplanted into a different source file. This issue has surfaced in the type-check code generator and is already being addressed there, so this commit moves the relevant `TypeEmitter` class from the `typecheck` module to the `translator` module, such that it can be reused for emitting types in the type translator. Fixes #51672 PR Close #52437 | 31 October 2023, 20:42:51 UTC |
a6dd8fa | Joey Perrott | 18 October 2023, 19:57:36 UTC | build: update lockfile (#52271) Update lockfiles throughout PR Close #52271 | 31 October 2023, 19:45:52 UTC |
df0902d | marktechson | 30 October 2023, 20:36:56 UTC | docs: update home page for live stream event (#52456) PR Close #52456 | 31 October 2023, 18:58:17 UTC |
ba499d5 | Emma Twersky | 28 October 2023, 01:16:40 UTC | docs: make banner persist until 11/8 (#52432) PR Close #52432 | 31 October 2023, 18:57:07 UTC |
a51bb69 | Ivad | 24 October 2023, 20:15:32 UTC | docs(docs-infra): fix typo in tap into the observable tutorial example (#52359) PR Close #52359 | 27 October 2023, 19:49:38 UTC |
5ff99f2 | Evan Kleiner | 28 September 2023, 23:36:15 UTC | docs: add warning for localhost proxy (#51948) PR Close #51948 | 27 October 2023, 19:32:20 UTC |
38b4602 | Susheel Thapa | 20 October 2023, 12:01:51 UTC | docs: fixed typos (#52297) PR Close #52297 | 25 October 2023, 23:39:06 UTC |
ee5b1cf | Dylan Hunn | 25 October 2023, 21:20:58 UTC | release: cut the v16.2.11 release | 25 October 2023, 21:26:10 UTC |
b79b4ac | Andrew Scott | 24 October 2023, 19:51:52 UTC | fix(router): `RouterTestingHarness` should throw if a component is expected but navigation fails (#52357) The `RouterTestingHarness` should throw an error if the call to `navigateByUrl` expects a component to be activated but the navigation failed. fixes #52344 PR Close #52357 | 25 October 2023, 18:04:24 UTC |
019a0f4 | AleksanderBodurri | 25 October 2023, 06:20:59 UTC | fix(core): load global utils before creating platform injector in the standalone case (#52365) This is needed so that the providers configured on platform creation are picked up by the injector profiler. PR Close #52365 | 25 October 2023, 17:51:21 UTC |
7853332 | AleksanderBodurri | 25 October 2023, 06:20:46 UTC | fix(core): get root and platform injector providers in special cases (#52365) Previously, because the platform injector does not have a provider container, this API would fail. Now, we account for this case specifically by returning the found providers immediately, without trying to calculate their importpaths. Also previously, in the case where a boostrapped standalone component did not import any feature modules, the environment injector connected to that bootstrapped component would be the root injector configured by `bootstrapApplication`. This injector is configured through a `providers` array instead of an `imports` array, and also does not have a provider container. Similarly to the platform case, we account this for this by returning the found providers immediately if there is no provider container for our standalone component. PR Close #52365 | 25 October 2023, 17:51:21 UTC |
54ea3b6 | AleksanderBodurri | 25 October 2023, 04:20:48 UTC | fix(core): emit provider configured event when a service is configured with `providedIn` (#52365) Previously this case was missed by the default framework injector profiler. Now in ngDevMode this event emits correctly when a service is configured with `providedIn`. This includes the case where injection tokens are configured with a `providedIn`. This commit also includes unit tests for this new case in the injector profiler. PR Close #52365 | 25 October 2023, 17:51:21 UTC |
372dd0a | Alvaro Junqueira | 23 October 2023, 10:52:42 UTC | docs: the `Component` import is not being used (#52323) PR Close #52323 | 25 October 2023, 16:35:22 UTC |
3afee87 | Naaajii | 24 October 2023, 17:54:01 UTC | docs(docs-infra): fix codeblock snippet for APP_INITIALIZER (#52354) fixes broken code snippet for standalone application using APP_INITIALIZER PR Close #52354 | 25 October 2023, 16:34:47 UTC |
56c93d0 | Matthieu Riegler | 24 October 2023, 16:29:56 UTC | docs(core): fix the language code (#52352) PR Close #52352 | 25 October 2023, 16:32:18 UTC |
fd88d6a | Angular Robot | 23 October 2023, 20:41:12 UTC | docs: update Angular CLI help [16.2.x] (#52335) Updated Angular CLI help contents. PR Close #52335 | 24 October 2023, 16:30:17 UTC |
3687359 | cexbrayat | 23 October 2023, 13:06:01 UTC | docs: remove test.ts file in aio (#52327) Same as 7ba5dc87ed, but for aio This file is not necessary since CLI v15+ PR Close #52327 | 24 October 2023, 16:23:00 UTC |
1693846 | Andrew Scott | 23 October 2023, 23:39:11 UTC | test(core): fix test observing broken OnPush checkNoChanges (#52337) The test is actually observing that OnPush results in a view not being checked when checkNoChanges runs. PR Close #52337 | 24 October 2023, 16:21:52 UTC |
8239a8f | Emma Twersky | 23 October 2023, 17:33:57 UTC | docs: add event banner (#52334) PR Close #52334 | 23 October 2023, 20:40:00 UTC |
fbf49b5 | Angular Robot | 18 October 2023, 06:06:08 UTC | build: update all non-major dependencies (#52259) See associated pull request for more information. PR Close #52259 | 19 October 2023, 16:25:42 UTC |
bf70bf6 | Pawel Kozlowski | 18 October 2023, 16:42:40 UTC | release: cut the v16.2.10 release | 18 October 2023, 16:46:27 UTC |
b4c4b42 | vivekkoya | 07 October 2023, 01:32:23 UTC | docs: Update BAZEL.md with correct bazelrc documentation link (#52090) PR Close #52090 | 18 October 2023, 16:15:02 UTC |
2643d0a | Quentin | 18 October 2023, 14:42:58 UTC | docs: fix typo (#52258) Fix typo in aio/content/errors/NG05104.md file PR Close #52258 | 18 October 2023, 16:13:43 UTC |
55e41d8 | Angular Robot | 17 October 2023, 16:06:39 UTC | build: update scorecard action dependencies (#52126) See associated pull request for more information. PR Close #52126 | 18 October 2023, 15:45:29 UTC |
1a09d3e | Angular Robot | 17 October 2023, 22:05:51 UTC | build: update io_bazel_rules_sass digest to 425ecaf (#52173) See associated pull request for more information. PR Close #52173 | 18 October 2023, 15:37:08 UTC |
2820425 | Pawel Kozlowski | 18 October 2023, 10:26:14 UTC | build: update babel dependencies to v7.23.2 (#52255) 16.2.x version of #52236 PR Close #52255 | 18 October 2023, 13:56:47 UTC |
06ce49a | Quentin | 17 October 2023, 19:17:21 UTC | docs: fix typo (#52247) Fix word: corresponding PR Close #52247 | 18 October 2023, 09:29:38 UTC |
d6070af | Quentin | 15 October 2023, 15:05:55 UTC | docs: fix typo (#52219) Fix word: incompatibilities PR Close #52219 | 16 October 2023, 16:30:45 UTC |
37e7f2d | Andrew Miller | 15 October 2023, 19:47:27 UTC | docs(language-service): add neovim setup to angular language service docs (#52212) PR Close #52212 | 16 October 2023, 16:19:11 UTC |
81018d7 | Osama Heykal | 16 October 2023, 00:49:20 UTC | docs: add missing next steps section (#52220) Added missing 'next steps' section in the tutorial. PR Close #52220 | 16 October 2023, 14:27:14 UTC |
6997c52 | thomas | 06 October 2023, 13:03:05 UTC | docs: add thomas laforge to GDE resources and add angularchallenges to resources (#52075) PR Close #52075 | 16 October 2023, 09:12:59 UTC |
d75eaa7 | Paul Gschwendtner | 12 October 2023, 18:26:20 UTC | refactor(core): remove unused helper for setting `LView` for reactive consumer (#52192) This code path is never hit because the assignment of the lview happens in `commitLViewConsumerIfHasProducers`. PR Close #52192 | 13 October 2023, 12:08:34 UTC |
630e906 | Miroslav Foltýn | 11 October 2023, 19:56:30 UTC | docs(router): add clarification for behavior of paramsInheritanceStrategy: 'emptyOnly' (#52170) Follows up to the https://github.com/angular/angular/issues/52108 which was opened due to the confusion surrounding paramsInheritanceStrategy: 'emptyOnly'. PR Close #52170 | 13 October 2023, 09:14:22 UTC |
25788b2 | Nicolas Frizzarin | 03 October 2023, 20:02:43 UTC | docs: add Nicolas Frizzarin to GDE resources (#52003) This PR add Nicolas Frizzarin to the GDE resources docs: fix typo on description PR Close #52003 | 12 October 2023, 15:44:47 UTC |
f52eee8 | Pawel Kozlowski | 12 October 2023, 10:16:07 UTC | Revert "refactor(compiler-cli): remove `MethodIdentifier` type (#49611)" (#52174) This reverts commit c2b1a242e8db0ef8e03f7ee85ffa1f82562fd735. PR Close #52174 | 12 October 2023, 10:35:49 UTC |
5f2a33a | Matthieu Riegler | 28 March 2023, 12:44:43 UTC | refactor(compiler-cli): remove `MethodIdentifier` type (#49611) `MethodIdentifier` is unused as is `IdentifierKind.Method`. They both can be removed. PR Close #49611 | 11 October 2023, 19:34:50 UTC |
7537928 | Angular Robot | 11 October 2023, 19:19:13 UTC | docs: update Angular CLI help [16.2.x] (#52169) Updated Angular CLI help contents. PR Close #52169 | 11 October 2023, 19:33:29 UTC |
c8f87c8 | Angular Robot | 05 October 2023, 15:03:50 UTC | docs: update events (#52053) Generated `events.json` with the latest events retrieved from the Firebase DB. PR Close #52053 | 11 October 2023, 19:18:05 UTC |
fb10abc | Andrew Scott | 11 October 2023, 16:50:52 UTC | release: cut the v16.2.9 release | 11 October 2023, 16:56:14 UTC |
a3136e0 | Angular Robot | 10 October 2023, 19:05:47 UTC | build: update io_bazel_rules_sass digest to 9a327e5 (#52119) See associated pull request for more information. PR Close #52119 | 11 October 2023, 16:23:07 UTC |
fcdae57 | Linus Wieland | 11 October 2023, 07:49:57 UTC | docs(animations): fix typo in state name of keyframes example (#52155) PR Close #52155 | 11 October 2023, 16:15:04 UTC |
51a5baa | Matthieu Riegler | 24 January 2023, 22:03:11 UTC | fix(forms): reset() call with null values on nested group (#48830) Non typed forms allow to pass null to nested groups when calling `formGroup.reset()`, this commit prevent an undefined access. fixes #20509 PR Close #48830 | 10 October 2023, 22:34:32 UTC |
7d8b3f4 | Andrew Scott | 10 October 2023, 19:38:15 UTC | build: update payload sizes to fix pre-existing failures (#52149) The payload sizes are failing on CI. This commit updates them to the current values. PR Close #52149 | 10 October 2023, 21:00:26 UTC |
427705e | mgechev | 09 October 2023, 17:04:32 UTC | docs: remove the developer survey 2023 banner (#52148) PR Close #52148 | 10 October 2023, 19:35:23 UTC |
2bfd28c | Thabo | 02 October 2023, 09:30:13 UTC | docs: correct wording for Directive's decorator host property key description (#51977) PR Close #51977 | 10 October 2023, 18:22:19 UTC |
d3c9e43 | Phalgun Vaddepalli | 06 October 2023, 17:52:49 UTC | docs(core): add an example of configuring APP_INITIALIZER token in context of standalone components (#52084) docs(core): fix formatting PR Close #52084 | 10 October 2023, 18:18:37 UTC |
aeb7d03 | Angular Robot | 21 September 2023, 01:25:29 UTC | build: update io_bazel_rules_sass digest to 6725d86 (#51844) See associated pull request for more information. PR Close #51844 | 09 October 2023, 20:26:42 UTC |
e63e3db | Angular Robot | 03 October 2023, 16:06:13 UTC | build: update all non-major dependencies (#52024) See associated pull request for more information. PR Close #52024 | 09 October 2023, 19:02:26 UTC |
5f433f6 | Angular Robot | 03 October 2023, 05:05:30 UTC | build: update github/codeql-action action to v2.21.9 (#51992) See associated pull request for more information. PR Close #51992 | 05 October 2023, 21:07:22 UTC |
2a10050 | Joey Perrott | 28 September 2023, 19:17:41 UTC | ci: migrate snapshot publishing from CircleCI to GHA (#51957) Migrate the snapshot publishing from CircleCI to GHA PR Close #51957 | 05 October 2023, 17:53:23 UTC |
5122729 | Joey Perrott | 29 September 2023, 14:44:46 UTC | ci: migrate saucelabs bazel job to Github Actions (#51945) Use Github Actions to run saucelabs bazel jobs PR Close #51945 | 05 October 2023, 16:18:35 UTC |
481198a | Alex Rickabaugh | 04 October 2023, 20:47:05 UTC | release: cut the v16.2.8 release | 04 October 2023, 20:55:28 UTC |
1e4c91c | Angular Robot | 30 September 2023, 15:03:37 UTC | docs: update events (#51966) Generated `events.json` with the latest events retrieved from the Firebase DB. Closes #51955 PR Close #51966 | 04 October 2023, 18:30:07 UTC |
b732961 | Andrew Scott | 26 September 2023, 17:31:27 UTC | fix(language-service): Retain correct language service when `ts.Project` reloads (#51912) When the `ts.Project` creates the language service plugin (in this case, the Angular Language Service), it sets the project's language service to the new language service returned by the plugin create: https://sourcegraph.com/github.com/microsoft/TypeScript@b12af0fa2bbd4b015e59adcfb49988cea7f919a1/-/blob/src/server/project.ts?L2035-2044 The project may be reloaded in response to various events, such as a change to the tsconfig file, which then recreates the plugin. When this happens, the language service that gets passed to the plugin `create` function will not be the typescript language service, but rather the previous instance of the new language service returned by the last call to `create`. This commit ensures that subsequent calls to `create` for the `NgLanguageService` plugin for a project after the first call are able to retrieve and hold on to the _TypeScript_ language service. fixes https://github.com/angular/vscode-ng-language-service/issues/1923 PR Close #51912 | 04 October 2023, 18:27:46 UTC |
966ce97 | Matthieu Riegler | 29 September 2023, 19:46:27 UTC | fix(service-worker): throw a critical error when handleFetch fails (#51960) #51885 patched a call site that threw an error but there were 2 others call that needed to be wrapped in the same way by a try/catch. `initializeFully` is part of the calls in `responseWith(handleFetch)`. Same #51885, throwing `SwCriticalError`allows the driver to fallback to `safeFetch` and ensure `responseWith` doesn't fail. Fixes #50378 PR Close #51960 | 04 October 2023, 15:51:07 UTC |
334fe60 | Andrew Scott | 20 September 2023, 18:30:37 UTC | refactor(core): Update view flags so only one number needs adjustment (#51839) When adding a new view flag, you currently need to adjust the last number of the last 3 flags. All of these share the same number so the shifting ones can just use the base-10 IndexWithinInitPhaseShift. PR Close #51839 | 04 October 2023, 14:29:16 UTC |
5e6955a | Angular Robot | 02 October 2023, 11:07:41 UTC | build: update dependency css-selector-parser to v3 (#51984) See associated pull request for more information. PR Close #51984 | 04 October 2023, 14:27:15 UTC |
96141c6 | Joey Perrott | 29 September 2023, 15:09:05 UTC | ci: add slack messages for failed aio deployments (#51956) Send message to to slack when aio fails to deploy PR Close #51956 | 02 October 2023, 15:37:46 UTC |
781bb91 | Joey Perrott | 20 September 2023, 16:43:30 UTC | build: lock file maintenance (#51838) Update the lock file. PR Close #51838 | 02 October 2023, 15:15:28 UTC |
82e8e5e | Joey Perrott | 21 September 2023, 15:24:11 UTC | ci: move permissions for google-internal-tests into job definition (#51847) Move permissions into the job definition for security improvement. PR Close #51847 | 29 September 2023, 17:51:21 UTC |
a16e3b8 | Dylan Hunn | 27 September 2023, 20:21:49 UTC | release: cut the v16.2.7 release | 27 September 2023, 20:28:35 UTC |
39a3e34 | Pawel Kozlowski | 20 September 2023, 13:27:56 UTC | fix(core): allow toSignal calls in reactive context (#51831) (#51892) This PR moves the Observable subscription of toSignal outside of the reactive context. As the result the toSignal calls are allowed in the computed, effect and all other reactive consumers. This is based on the reasoning that we already allow signals creation in a reactive context. Plus a similar change was done to the async pipe in the https://github.com/angular/angular/pull/50522 Fixes #51027 PR Close #51892 | 27 September 2023, 17:30:15 UTC |
aedd8de | Angular Robot | 26 September 2023, 05:06:02 UTC | build: update scorecard action dependencies (#51899) See associated pull request for more information. PR Close #51899 | 27 September 2023, 16:24:20 UTC |
68648ee | Andrew Kushnir | 26 September 2023, 22:31:44 UTC | refactor(core): avoid an empty array allocation during hydration (#51917) This commit updates hydration runtime code to avoid creating an empty array when we can avoid it. Instead, we just check whether the field is `null` directly (without using nullish coalescing). PR Close #51917 | 27 September 2023, 16:22:50 UTC |
b8f447e | Jeevan Mahesha | 27 September 2023, 04:34:43 UTC | docs: updated the server configuration for apache2 (#51921) PR Close #51921 | 27 September 2023, 16:22:14 UTC |
70d8c2f | Jithil P Ponnan | 27 September 2023, 11:10:19 UTC | docs: minor update to modify the Bazel extension url (#51925) PR Close #51925 | 27 September 2023, 16:21:35 UTC |
c3d901e | Matthieu Riegler | 24 September 2023, 21:37:45 UTC | fix(service-worker): throw a critical error when `handleFetch` fails (#51885) On Safari, the cache might fail on methods like `match` with an `Internal error`. Critical errors allows to fallback to `safeFetch()` in the `Driver`. fixes: #50378 PR Close #51885 | 26 September 2023, 16:10:38 UTC |
cc99ba4 | Pawel Kozlowski | 26 September 2023, 09:34:19 UTC | build: improve results logging in perf script (#51902) Add git references when printing perf comparison results. PR Close #51902 | 26 September 2023, 16:09:02 UTC |
3498efc | Joey Perrott | 26 September 2023, 14:58:00 UTC | ci: use pull request head sha instead of the sha provided in the github context (#51908) Use the pull request head sha so that we don't test the code already committed. PR Close #51908 | 26 September 2023, 16:07:48 UTC |
5907420 | Lars Gyrup Brink Nielsen | 04 September 2023, 11:30:45 UTC | docs: merge versions with identical version ranges in pre-v9 compatibility version table (#51842) PR Close #51842 | 25 September 2023, 16:19:10 UTC |
17cde6b | Lars Gyrup Brink Nielsen | 04 September 2023, 11:20:25 UTC | docs: correct pre-v9 TypeScript version ranges in version compatibiliy table (#51842) For versions 5.x through 8.x, this is based on the `package.json` file of `@angular/compiler-cli`. For versions 2.x through 4.x, this is based on Angular's changelog. PR Close #51842 | 25 September 2023, 16:19:10 UTC |
996cb4b | Lars Gyrup Brink Nielsen | 04 September 2023, 11:10:23 UTC | docs: normalize Angular version ranges in pre-v9 version compatibility table (#51842) PR Close #51842 | 25 September 2023, 16:19:10 UTC |
6637039 | Paul Gschwendtner | 22 September 2023, 10:39:40 UTC | fix(bazel): allow setting `_enabledBlockTypes` angular compiler option (#51862) We control most flags via Starlark and therefore limit configuration options via `tsconfig` to a minimum. We do not intend to support the enabled block types option via Starlark, so this commit allows for the option to be picked up. (This is useful for benchmarking the new control flow blocks). PR Close #51862 | 22 September 2023, 16:51:26 UTC |
6e6452d | Pawel Kozlowski | 20 September 2023, 17:44:29 UTC | release: cut the v16.2.6 release | 20 September 2023, 17:51:02 UTC |
4ccd845 | Andrew Scott | 18 September 2023, 20:37:23 UTC | refactor(router): Refactor loadChildren callback execution and privately export for SSR (#51818) This commit refactors the loadChildren callback execution of the router config loader into a function that can be used with SSR for the purposes of route extraction. PR Close #51818 | 20 September 2023, 16:34:13 UTC |
6e4d8f6 | David LJ | 22 August 2023, 12:10:17 UTC | docs: remove ref to no longer existing `test.ts` (#51462) The file was removed in Angular 15.0.0 https://github.com/angular/angular-cli/releases/tag/15.0.0 https://github.com/angular/angular-cli/commit/56a1e8f9f52658488afb9d36007e96c96d08a03b Thanks to @atscott and @JeanMeche for the wording suggestion PR Close #51462 | 19 September 2023, 16:37:39 UTC |
5810827 | Angular Robot | 18 September 2023, 20:07:45 UTC | build: update scorecard action dependencies (#51817) See associated pull request for more information. PR Close #51817 | 19 September 2023, 10:18:26 UTC |
03127fc | Paul Gschwendtner | 18 September 2023, 10:10:02 UTC | refactor(core): ensure reactive node constants are considered pure (#51809) (#51813) Currently when ESBuild bundles an application importing from `@angular/core`, the signals library will be discovered during export analysis. ESBuild will come across the constants for the reactive signal graph- and end up considering some of these as side-effects given the pattern of using a spread assignment for extending from e.g. `REACTIVE_NODE` (a similar issue may occur if we e.g. extend from the computed reactive node). See more details on the issue: https://github.com/evanw/esbuild/issues/3392 Even though, ESBuild preserves these constants now, and all of its dependencies— Terser will consider these as side-effect free and eliminate these constants. This may require multiple passes though, and might not be sufficient, depending on the chain of reactive node extensions. E.g. in the signals branch we noticed some constants unnecessarily being preserved. PR Close #51809 PR Close #51813 | 18 September 2023, 13:37:13 UTC |
bf1f9a0 | Kristiyan Kostadinov | 16 September 2023, 07:35:39 UTC | test(compiler): attempt to deflake windows tests (#51804) Another try at deflaking the tests on Windows. I'm trying a couple of fixes here: 1. I noticed that it's usually the indexer tests that fail during flaky runs. These tests also happen to be the only ones that don't pass in the `files` argument of `NgtscTestEnvironment.setup`. When `files` isn't passed in, we don't hit the file path that sets up the `MockFileSystem`. With these changes I make it so that we always initialize the mock file system. 2. The missing file system error usually comes from the `absoluteFrom` call that initializes the optional `workingDir` argument. My theory is that because it's a default value for an argument, it gets called too early before everything is initialized. These changes move the `absoluteFrom` call further down until it's needed. PR Close #51804 | 18 September 2023, 08:46:38 UTC |
3b46066 | Paul Gschwendtner | 14 September 2023, 13:28:15 UTC | refactor: ensure top-level symbols are marked as side-effect free (#51776) Terser does not treat `Symbol` as side-effect free- so if we end up with a symbol export being loaded, it will result in the symbol being retained. We noticed this in the signals prototyping where symbols exported from `computed` ended up appearing in symbol bundling tests. PR Close #51776 | 15 September 2023, 13:53:51 UTC |
b0b004e | Angular Robot | 14 September 2023, 20:06:39 UTC | build: update actions/cache digest to 704facf (#51787) See associated pull request for more information. PR Close #51787 | 15 September 2023, 09:42:51 UTC |
ffd25fc | Angular Robot | 14 September 2023, 01:25:58 UTC | build: update io_bazel_rules_sass digest to 63d77ff (#51243) See associated pull request for more information. PR Close #51243 | 15 September 2023, 07:04:10 UTC |
a31dcb9 | Joey Perrott | 14 September 2023, 19:10:56 UTC | ci: use head_ref for concurrency group (#51784) Use the head_ref value for the conncurency group on ci-priviledged rather than the ref, so that the main ref is not used and cancelling across pull requests and the main branch PR Close #51784 | 15 September 2023, 07:02:04 UTC |
5b4a5eb | Rafael Leal | 12 September 2023, 18:43:14 UTC | docs: fix broken image links in tutorial (#51744) This is to fix broken image links in the first-app tutorial documentation with functional links that match the working examples. PR Close #51744 | 14 September 2023, 14:02:42 UTC |
7b40d74 | JoostK | 10 September 2023, 17:00:58 UTC | refactor(core): let reactive node prototypes conform to their type (#51722) (#51772) This commit adds explicit type annotations to the reactive node prototype objects, such that the prototypes are type-checked against the interface they are supposed to (partially) implement. This also allows IDEs to better track usages of reactive node properties, improving code navigation. PR Close #51722 PR Close #51772 | 14 September 2023, 10:51:30 UTC |
82712f8 | JoostK | 10 September 2023, 16:56:54 UTC | fix(core): ensure a consumer drops all its stale producers (#51722) (#51772) When a producer is no longer used, the consumer has to update its internal data structure that keeps track of all producers. There used to be an issue where only half of the stale producers would actually be removed from this data structure, as the intended upper bound of the number of producers to remove would decrease with each removed producer, therefore not reaching all producers that should be removed from the data structure. This commit fixes the issue by truncating the arrays directly, without going through individual `pop` operations. An assertion that would catch the inconsistent state in the internal data structures of the signal graph has been introduced. PR Close #51722 PR Close #51772 | 14 September 2023, 10:51:30 UTC |
65d6915 | Joey Perrott | 19 July 2023, 16:58:30 UTC | ci: migrate legacy saucelabs job to Github Actions (#51695) Migrate the legacy saucelabs job PR Close #51695 | 13 September 2023, 17:49:49 UTC |
684891a | Andrew Kushnir | 12 September 2023, 22:08:23 UTC | refactor(docs-infra): increase timeout for flaky tests (#51747) This commit updates the `jasmine.DEFAULT_TIMEOUT_INTERVAL` value for some AIO tests from 10 -> 20 seconds to give more time to complete processing. This commit also refactors tests to use async/await pattern. PR Close #51747 | 13 September 2023, 17:47:54 UTC |
cc57b24 | Andrew Kushnir | 13 September 2023, 17:30:06 UTC | release: cut the v16.2.5 release | 13 September 2023, 17:33:40 UTC |
f6f3783 | Chinmay Chandak | 12 September 2023, 05:38:30 UTC | docs: Fix misspelling in note of `git commit --all` (#51735) In note of `git commit --all` command optional `-a` changed to `--all` PR Close #51735 | 12 September 2023, 19:25:43 UTC |