Revision 57fcdc264aa0f2bb481fdad9d4a1a7846395c6e1 authored by zawlazaw on 23 October 2017, 23:34:47 UTC, committed by Facebook Github Bot on 23 October 2017, 23:42:07 UTC
Summary: Java's `Status.SubCode` was out of sync with `include/rocksdb/status.h:SubCode`. When running out of disc space this led to an `IllegalArgumentException` because of an invalid status code, rather than just returning the corresponding status code without an exception. I added the missing status codes. By this, we keep the behaviour of throwing an `IllegalArgumentException` in case of newly added status codes that are defined in C but not in Java. We could think of an alternative strategy: add in Java another code "UnknownCode" which acts as a catch-all for all those status codes that are not yet mirrored from C to Java. This approach would never throw an exception but simply return a non-OK status-code. I think the current approach of throwing an Exception in case of a C/Java inconsistency is fine, but if you have some opinion on the alternative strategy, then feel free to comment here. Closes https://github.com/facebook/rocksdb/pull/3050 Differential Revision: D6129682 Pulled By: sagar0 fbshipit-source-id: f2bf44caad650837cffdcb1f93eb793b43580c66
1 parent 66a2c44
| File | Mode | Size |
|---|---|---|
| buckifier | ||
| build_tools | ||
| cache | ||
| cmake | ||
| coverage | ||
| db | ||
| docs | ||
| env | ||
| examples | ||
| hdfs | ||
| include | ||
| java | ||
| memtable | ||
| monitoring | ||
| options | ||
| port | ||
| table | ||
| third-party | ||
| tools | ||
| util | ||
| utilities | ||
| .clang-format | -rw-r--r-- | 138 bytes |
| .gitignore | -rw-r--r-- | 705 bytes |
| .travis.yml | -rw-r--r-- | 2.7 KB |
| AUTHORS | -rw-r--r-- | 322 bytes |
| CMakeLists.txt | -rw-r--r-- | 31.1 KB |
| CONTRIBUTING.md | -rw-r--r-- | 607 bytes |
| COPYING | -rw-r--r-- | 17.7 KB |
| DEFAULT_OPTIONS_HISTORY.md | -rw-r--r-- | 1.5 KB |
| DUMP_FORMAT.md | -rw-r--r-- | 763 bytes |
| HISTORY.md | -rw-r--r-- | 49.2 KB |
| INSTALL.md | -rw-r--r-- | 5.8 KB |
| LANGUAGE-BINDINGS.md | -rw-r--r-- | 814 bytes |
| LICENSE.Apache | -rw-r--r-- | 11.1 KB |
| LICENSE.leveldb | -rw-r--r-- | 1.5 KB |
| Makefile | -rw-r--r-- | 61.7 KB |
| README.md | -rw-r--r-- | 1.4 KB |
| ROCKSDB_LITE.md | -rw-r--r-- | 1.0 KB |
| TARGETS | -rw-r--r-- | 20.6 KB |
| USERS.md | -rw-r--r-- | 5.1 KB |
| Vagrantfile | -rw-r--r-- | 877 bytes |
| WINDOWS_PORT.md | -rw-r--r-- | 12.5 KB |
| appveyor.yml | -rw-r--r-- | 428 bytes |
| issue_template.md | -rw-r--r-- | 243 bytes |
| src.mk | -rw-r--r-- | 26.8 KB |
| thirdparty.inc | -rw-r--r-- | 7.8 KB |
Computing file changes ...
