Revision 580e4273d7a883ececfefa692c1f96bdbacb99b5 authored by Cong Wang on 02 October 2020, 19:13:34 UTC, committed by David S. Miller on 04 October 2020, 21:53:06 UTC
Although we take RTNL on dump path, it is possible to
skip RTNL on insertion path. So the following race condition
is possible:

rtnl_lock()		// no rtnl lock
			mutex_lock(&idrinfo->lock);
			// insert ERR_PTR(-EBUSY)
			mutex_unlock(&idrinfo->lock);
tc_dump_action()
rtnl_unlock()

So we have to skip those temporary -EBUSY entries on dump path
too.

Reported-and-tested-by: syzbot+b47bc4f247856fb4d9e1@syzkaller.appspotmail.com
Fixes: 0fedc63fadf0 ("net_sched: commit action insertions together")
Cc: Vlad Buslov <vladbu@mellanox.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 9a9e774
History
File Mode Size
aoe
drbd
mtip32xx
paride
rnbd
rsxx
xen-blkback
zram
Kconfig -rw-r--r-- 15.8 KB
Makefile -rw-r--r-- 1.5 KB
amiflop.c -rw-r--r-- 50.0 KB
ataflop.c -rw-r--r-- 54.6 KB
brd.c -rw-r--r-- 13.3 KB
cryptoloop.c -rw-r--r-- 4.3 KB
floppy.c -rw-r--r-- 135.8 KB
loop.c -rw-r--r-- 59.6 KB
loop.h -rw-r--r-- 2.3 KB
nbd.c -rw-r--r-- 61.1 KB
null_blk.h -rw-r--r-- 3.9 KB
null_blk_main.c -rw-r--r-- 47.4 KB
null_blk_trace.c -rw-r--r-- 464 bytes
null_blk_trace.h -rw-r--r-- 2.0 KB
null_blk_zoned.c -rw-r--r-- 7.5 KB
pktcdvd.c -rw-r--r-- 72.4 KB
ps3disk.c -rw-r--r-- 13.5 KB
ps3vram.c -rw-r--r-- 22.0 KB
rbd.c -rw-r--r-- 185.0 KB
rbd_types.h -rw-r--r-- 2.5 KB
skd_main.c -rw-r--r-- 93.2 KB
skd_s1120.h -rw-r--r-- 9.3 KB
sunvdc.c -rw-r--r-- 28.7 KB
swim.c -rw-r--r-- 20.2 KB
swim3.c -rw-r--r-- 31.3 KB
swim_asm.S -rw-r--r-- 4.4 KB
sx8.c -rw-r--r-- 37.2 KB
umem.c -rw-r--r-- 29.7 KB
umem.h -rw-r--r-- 3.6 KB
virtio_blk.c -rw-r--r-- 25.8 KB
xen-blkfront.c -rw-r--r-- 73.6 KB
xsysace.c -rw-r--r-- 33.4 KB
z2ram.c -rw-r--r-- 9.5 KB

back to top