https://github.com/torvalds/linux
Revision 59c84ed0ddc11f1823b4a33ace4fbcc948261bb2 authored by Jan Kara on 05 June 2012, 22:32:26 UTC, committed by Ben Myers on 21 June 2012, 19:20:36 UTC
Commit de1cbee which removed b_file_offset in favor of b_bn introduced a bug causing xfs_buf_allocate_memory() to overestimate the number of necessary pages. The problem is that xfs_buf_alloc() sets b_bn to -1 and thus effectively every buffer is straddling a page boundary which causes xfs_buf_allocate_memory() to allocate two pages and use vmalloc() for access which is unnecessary. Dave says xfs_buf_alloc() doesn't need to set b_bn to -1 anymore since the buffer is inserted into the cache only after being fully initialized now. So just make xfs_buf_alloc() fill in proper block number from the beginning. CC: David Chinner <dchinner@redhat.com> Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Ben Myers <bpm@sgi.com>
1 parent 76d0953
Tip revision: 59c84ed0ddc11f1823b4a33ace4fbcc948261bb2 authored by Jan Kara on 05 June 2012, 22:32:26 UTC
xfs: Fix overallocation in xfs_buf_allocate_memory()
xfs: Fix overallocation in xfs_buf_allocate_memory()
Tip revision: 59c84ed
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 12.7 KB |
| Kconfig.debug | -rw-r--r-- | 1015 bytes |
| Makefile | -rw-r--r-- | 1.8 KB |
| backing-dev.c | -rw-r--r-- | 22.3 KB |
| bootmem.c | -rw-r--r-- | 20.7 KB |
| bounce.c | -rw-r--r-- | 6.5 KB |
| cleancache.c | -rw-r--r-- | 6.5 KB |
| compaction.c | -rw-r--r-- | 26.3 KB |
| debug-pagealloc.c | -rw-r--r-- | 2.1 KB |
| dmapool.c | -rw-r--r-- | 13.0 KB |
| fadvise.c | -rw-r--r-- | 3.6 KB |
| failslab.c | -rw-r--r-- | 1.3 KB |
| filemap.c | -rw-r--r-- | 66.7 KB |
| filemap_xip.c | -rw-r--r-- | 11.2 KB |
| fremap.c | -rw-r--r-- | 6.7 KB |
| highmem.c | -rw-r--r-- | 10.3 KB |
| huge_memory.c | -rw-r--r-- | 63.7 KB |
| hugetlb.c | -rw-r--r-- | 79.2 KB |
| hwpoison-inject.c | -rw-r--r-- | 3.3 KB |
| init-mm.c | -rw-r--r-- | 619 bytes |
| internal.h | -rw-r--r-- | 10.3 KB |
| kmemcheck.c | -rw-r--r-- | 2.8 KB |
| kmemleak-test.c | -rw-r--r-- | 3.3 KB |
| kmemleak.c | -rw-r--r-- | 52.6 KB |
| ksm.c | -rw-r--r-- | 54.7 KB |
| maccess.c | -rw-r--r-- | 1.6 KB |
| madvise.c | -rw-r--r-- | 11.6 KB |
| memblock.c | -rw-r--r-- | 26.9 KB |
| memcontrol.c | -rw-r--r-- | 143.4 KB |
| memory-failure.c | -rw-r--r-- | 41.9 KB |
| memory.c | -rw-r--r-- | 107.9 KB |
| memory_hotplug.c | -rw-r--r-- | 24.1 KB |
| mempolicy.c | -rw-r--r-- | 65.7 KB |
| mempool.c | -rw-r--r-- | 10.4 KB |
| migrate.c | -rw-r--r-- | 33.7 KB |
| mincore.c | -rw-r--r-- | 7.8 KB |
| mlock.c | -rw-r--r-- | 15.7 KB |
| mm_init.c | -rw-r--r-- | 3.7 KB |
| mmap.c | -rw-r--r-- | 70.8 KB |
| mmu_context.c | -rw-r--r-- | 1.4 KB |
| mmu_notifier.c | -rw-r--r-- | 9.1 KB |
| mmzone.c | -rw-r--r-- | 2.0 KB |
| mprotect.c | -rw-r--r-- | 7.9 KB |
| mremap.c | -rw-r--r-- | 13.6 KB |
| msync.c | -rw-r--r-- | 2.4 KB |
| nobootmem.c | -rw-r--r-- | 10.5 KB |
| nommu.c | -rw-r--r-- | 50.9 KB |
| oom_kill.c | -rw-r--r-- | 22.2 KB |
| page-writeback.c | -rw-r--r-- | 67.4 KB |
| page_alloc.c | -rw-r--r-- | 165.6 KB |
| page_cgroup.c | -rw-r--r-- | 11.9 KB |
| page_io.c | -rw-r--r-- | 3.2 KB |
| page_isolation.c | -rw-r--r-- | 3.7 KB |
| pagewalk.c | -rw-r--r-- | 5.8 KB |
| percpu-km.c | -rw-r--r-- | 2.8 KB |
| percpu-vm.c | -rw-r--r-- | 12.9 KB |
| percpu.c | -rw-r--r-- | 57.0 KB |
| pgtable-generic.c | -rw-r--r-- | 3.3 KB |
| prio_tree.c | -rw-r--r-- | 6.3 KB |
| process_vm_access.c | -rw-r--r-- | 13.3 KB |
| quicklist.c | -rw-r--r-- | 2.4 KB |
| readahead.c | -rw-r--r-- | 16.1 KB |
| rmap.c | -rw-r--r-- | 52.4 KB |
| shmem.c | -rw-r--r-- | 77.5 KB |
| slab.c | -rw-r--r-- | 120.6 KB |
| slob.c | -rw-r--r-- | 17.1 KB |
| slub.c | -rw-r--r-- | 129.3 KB |
| sparse-vmemmap.c | -rw-r--r-- | 5.9 KB |
| sparse.c | -rw-r--r-- | 20.3 KB |
| swap.c | -rw-r--r-- | 21.2 KB |
| swap_state.c | -rw-r--r-- | 10.2 KB |
| swapfile.c | -rw-r--r-- | 63.0 KB |
| truncate.c | -rw-r--r-- | 19.0 KB |
| util.c | -rw-r--r-- | 8.9 KB |
| vmalloc.c | -rw-r--r-- | 65.7 KB |
| vmscan.c | -rw-r--r-- | 93.3 KB |
| vmstat.c | -rw-r--r-- | 33.3 KB |
Computing file changes ...
