https://github.com/facebook/rocksdb
Revision 5aa675457e44598dd6e5828954cecbfc2a1a4f41 authored by anand76 on 16 July 2024, 02:13:29 UTC, committed by Facebook GitHub Bot on 16 July 2024, 02:13:29 UTC
Summary: The failure of `WriteCurrentStateToManifest()` in `VersionSet::ProcessManifestWrites()` was not handled properly. If it failed, `manifest_io_status` was not updated, leading to `manifest_file_number_` being updated to the newly created manifest even though its bad. This would lead to the bad manifest immediately getting deleted, and also the good manifest (referenced by `CURRENT`) getting deleted by obsolete file deletion because of `manifest_file_number_` not referencing its number. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12865 Reviewed By: hx235 Differential Revision: D59782940 Pulled By: anand1976 fbshipit-source-id: f752fb9a1c23fd3d734616e273613cbac204301b
1 parent 4ff35af
Tip revision: 5aa675457e44598dd6e5828954cecbfc2a1a4f41 authored by anand76 on 16 July 2024, 02:13:29 UTC
Fix unhandled MANIFEST write errors (#12865)
Fix unhandled MANIFEST write errors (#12865)
Tip revision: 5aa6754
| File | Mode | Size |
|---|---|---|
| .circleci | ||
| .github | ||
| buckifier | ||
| build_tools | ||
| cache | ||
| cmake | ||
| coverage | ||
| db | ||
| db_stress_tool | ||
| docs | ||
| env | ||
| examples | ||
| file | ||
| fuzz | ||
| include | ||
| java | ||
| logging | ||
| memory | ||
| memtable | ||
| microbench | ||
| monitoring | ||
| options | ||
| plugin | ||
| port | ||
| table | ||
| test_util | ||
| third-party | ||
| tools | ||
| trace_replay | ||
| unreleased_history | ||
| util | ||
| utilities | ||
| .clang-format | -rw-r--r-- | 138 bytes |
| .gitignore | -rw-r--r-- | 1.0 KB |
| .lgtm.yml | -rw-r--r-- | 67 bytes |
| .watchmanconfig | -rw-r--r-- | 130 bytes |
| AUTHORS | -rw-r--r-- | 322 bytes |
| CMakeLists.txt | -rw-r--r-- | 58.6 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 3.3 KB |
| CONTRIBUTING.md | -rw-r--r-- | 706 bytes |
| COPYING | -rw-r--r-- | 17.7 KB |
| DEFAULT_OPTIONS_HISTORY.md | -rw-r--r-- | 1.5 KB |
| DUMP_FORMAT.md | -rw-r--r-- | 763 bytes |
| HISTORY.md | -rw-r--r-- | 328.3 KB |
| INSTALL.md | -rw-r--r-- | 8.6 KB |
| LANGUAGE-BINDINGS.md | -rw-r--r-- | 1.3 KB |
| LICENSE.Apache | -rw-r--r-- | 11.1 KB |
| LICENSE.leveldb | -rw-r--r-- | 1.5 KB |
| Makefile | -rw-r--r-- | 101.8 KB |
| PLUGINS.md | -rw-r--r-- | 975 bytes |
| README.md | -rw-r--r-- | 1.6 KB |
| TARGETS | -rw-r--r-- | 646.6 KB |
| USERS.md | -rw-r--r-- | 11.2 KB |
| Vagrantfile | -rw-r--r-- | 1017 bytes |
| WINDOWS_PORT.md | -rw-r--r-- | 12.5 KB |
| common.mk | -rw-r--r-- | 963 bytes |
| crash_test.mk | -rw-r--r-- | 4.7 KB |
| issue_template.md | -rw-r--r-- | 294 bytes |
| rocksdb.pc.in | -rw-r--r-- | 292 bytes |
| src.mk | -rw-r--r-- | 48.0 KB |
| thirdparty.inc | -rw-r--r-- | 7.8 KB |
Computing file changes ...
