https://github.com/torvalds/linux
Revision 5c51543b0ae45967cfa99ca16748dc72888cc265 authored by Masami Hiramatsu on 18 April 2013, 09:33:18 UTC, committed by Linus Torvalds on 18 April 2013, 15:58:38 UTC
Fix a double locking bug caused when debug.kprobe-optimization=0.
While the proc_kprobes_optimization_handler locks kprobe_mutex,
wait_for_kprobe_optimizer locks it again and that causes a double lock.
To fix the bug, this introduces different mutex for protecting
sysctl parameter and locks it in proc_kprobes_optimization_handler.
Of course, since we need to lock kprobe_mutex when touching kprobes
resources, that is done in *optimize_all_kprobes().

This bug was introduced by commit ad72b3bea744 ("kprobes: fix
wait_for_kprobe_optimizer()")

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent d202f05
History
Tip revision: 5c51543b0ae45967cfa99ca16748dc72888cc265 authored by Masami Hiramatsu on 18 April 2013, 09:33:18 UTC
kprobes: Fix a double lock bug of kprobe_mutex
Tip revision: 5c51543
File Mode Size
00-INDEX -rw-r--r-- 81 bytes
README.buddha -rw-r--r-- 7.5 KB
kernel-options.txt -rw-r--r-- 32.4 KB

README.buddha

back to top