5d5b515 | Andrew Kushnir | 07 December 2022, 21:45:33 UTC | release: cut the v15.0.3 release | 07 December 2022, 21:54:02 UTC |
bf44dc2 | Konstantin Kharitonov | 06 December 2022, 16:22:45 UTC | fix(common): Update `Location` to support base href containing `origin` (#48327) In case `APP_BASE_HREF` is set including `origin` the further usage of it might cause failure e.g. If an app is placed on `https://example.com` and bundles are on `https://cdn-example.com` you have to set `APP_BASE_HREF` up as `https://example.com/` and build the app with `--base-href` as `https://cdn-example.com/` but it does not work because of the bug Fixes #48175 PR Close #48327 | 07 December 2022, 17:18:01 UTC |
7df1989 | Angular Robot | 06 December 2022, 19:34:14 UTC | build: update cross-repo angular dependencies (#47882) (#48384) See associated pull request for more information. PR Close #47882 (cherry picked from commit 7c4e9ce5c0eb99f9cf6e4ad2faa9197d0ff986ec) PR Close #48384 | 07 December 2022, 17:09:30 UTC |
6b6bf63 | Angular Robot | 06 December 2022, 17:33:10 UTC | build: update all non-major dependencies (#48372) (#48384) See associated pull request for more information. PR Close #48372 (cherry picked from commit 126573d76b9456f55070fa0fdc54eeacc5762000) PR Close #48384 | 07 December 2022, 17:09:30 UTC |
cb7365a | Alan Agius | 06 December 2022, 15:39:27 UTC | refactor(compiler): replace `flatten` and `map` with `flatMap`. (#48378) Replace custom `flatten` and `map` with native `flatMap` usage. Benchmark: | Test case name | Result | |---------------- |-------------------------------------------------------- | | flatten & map | flatten & map x 1,182 ops/sec ±2.18% (63 runs sampled) | | flatMap | flatMap x 6,011 ops/sec ±0.91% (35 runs sampled) | The fact that `flatMap` is faster is also highlighted in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flatMap PR Close #48378 | 07 December 2022, 17:08:26 UTC |
a51e625 | Angular Robot | 06 December 2022, 06:03:04 UTC | build: update github/codeql-action action to v2.1.35 (#48371) See associated pull request for more information. PR Close #48371 | 07 December 2022, 17:07:34 UTC |
e4dcaa5 | Kristiyan Kostadinov | 05 December 2022, 11:47:46 UTC | fix(core): unable to inject ChangeDetectorRef inside host directives (#48355) When injecting the `ChangeDetectorRef` into a node that matches a component, we create a new ref using the component's LView. This breaks down for host directives, because they run before the component's LView has been created. These changes resolve the issue by creating the LView before creating the node injector for the directives. Fixes #48249. PR Close #48355 | 07 December 2022, 17:06:46 UTC |
c0d0417 | Alan Agius | 05 December 2022, 16:18:26 UTC | refactor(core): simplify array flatten logic (#48358) We can now use modern Javascript to get the same result. PR Close #48358 | 06 December 2022, 20:48:42 UTC |
5e2cd07 | Angular Robot | 06 December 2022, 18:35:55 UTC | build: update dependency jasmine-spec-reporter to v7 (#48367) See associated pull request for more information. PR Close #48367 | 06 December 2022, 19:43:05 UTC |
4c76f94 | Angular Robot | 06 December 2022, 18:35:42 UTC | build: update dependency @types/jasmine to v4 (#48365) See associated pull request for more information. PR Close #48365 | 06 December 2022, 18:57:04 UTC |
0e539eb | Angular Robot | 05 December 2022, 17:34:07 UTC | build: update eslint dependencies to v5.45.1 (#48223) See associated pull request for more information. PR Close #48223 | 06 December 2022, 18:52:16 UTC |
39b6cbc | Angular Robot | 06 December 2022, 17:34:01 UTC | build: update dependency karma-jasmine-html-reporter to v2 (#48369) See associated pull request for more information. PR Close #48369 | 06 December 2022, 18:09:14 UTC |
9a5d842 | dario-piotrowicz | 04 December 2022, 21:26:59 UTC | fix(compiler): make sure selectors inside container queries are correctly scoped (#48353) improve the emulated shadowDom implementation so that it can correctly scope selectors present inside the @container at-rule (recently added to the css specs) resolves #48264 PR Close #48353 | 06 December 2022, 17:59:00 UTC |
1e58a8c | Alan Agius | 06 December 2022, 11:49:32 UTC | docs: wrap json property in double quotes (#48375) Previously, the `budgets` was not wrapped in quotes which caused the JSON to be invalid. PR Close #48375 | 06 December 2022, 17:58:22 UTC |
40d6a06 | Alan Agius | 05 December 2022, 18:19:00 UTC | refactor(core): remove old AJD workaround for G3 (#48363) This workaround does not seem to be needed any longer. PR Close #48363 | 06 December 2022, 17:14:24 UTC |
fc872b1 | Angular Robot | 06 December 2022, 00:05:46 UTC | build: update dependency ts-node to v10 (#48370) See associated pull request for more information. PR Close #48370 | 06 December 2022, 17:12:27 UTC |
fdb2a38 | Angular Robot | 06 December 2022, 00:05:28 UTC | build: update dependency karma-jasmine to v5 (#48368) See associated pull request for more information. PR Close #48368 | 06 December 2022, 17:11:48 UTC |
ac51e5c | Angular Robot | 05 December 2022, 23:05:26 UTC | build: update dependency jasmine-core to v4 (#48366) See associated pull request for more information. PR Close #48366 | 05 December 2022, 23:56:41 UTC |
45cc5f4 | Paul Gschwendtner | 05 December 2022, 13:23:16 UTC | build: switch new AIO preview action to use `aio: preview` label (#48345) The new AIO preview deployment should take over the existing `aio: preview` label- now after it being tested- and working as expected. PR Close #48345 | 05 December 2022, 22:52:38 UTC |
3f9cfae | Paul Gschwendtner | 30 November 2022, 15:43:23 UTC | build: remove docker-based AIO preview deploy setup (#48345) The docker-based AIO preview deploy setup is replaced with significantly simpler setup using GitHub actions provided by dev-infra (also something dev-infra can maintain better then). The actions under the hood leverage Firebase preview channels. PR Close #48345 | 05 December 2022, 22:52:38 UTC |
dcab0f4 | Bob Watson | 05 December 2022, 15:45:23 UTC | docs: add example app for new landing page (#48360) PR Close #48360 | 05 December 2022, 22:37:47 UTC |
0b04da1 | Alan Agius | 05 December 2022, 13:35:02 UTC | refactor(core): remove several private utils and APIs (#48357) These APIs are no longer used. PR Close #48357 | 05 December 2022, 22:35:10 UTC |
a4c82ba | Alan Agius | 05 December 2022, 13:19:35 UTC | refactor(compiler): remove unused `projection` const (#48357) `projection` const is unused in `serializePlaceholderValue`. PR Close #48357 | 05 December 2022, 22:35:09 UTC |
28b0b89 | Alan Agius | 05 December 2022, 13:18:59 UTC | refactor(common): remove unused `setDOM` (#48357) Remove unused `setDOM` method is unused. PR Close #48357 | 05 December 2022, 22:35:09 UTC |
50b1c2b | Alex Castle | 08 November 2022, 22:09:21 UTC | fix(common): Don't generate srcsets with very large sources (#47997) Fix an issue where users could inadvertently generate very large source images in ngOptimizedImage PR Close #47997 | 05 December 2022, 20:12:14 UTC |
9214e58 | Joey Perrott | 05 December 2022, 16:18:24 UTC | build: enable the ng-dev auth service (#48361) Enable the auth service for merging into the repository PR Close #48361 | 05 December 2022, 20:09:08 UTC |
0b388a0 | Paul Gschwendtner | 04 December 2022, 16:17:11 UTC | build: add more debug information for occasional windows flakiness (#48351) Ocassionally the NodeJS version is not correct after NVM on Windows. This adds some debug information that should help improve stability here. A recent attempt to update the `$PATH` did not seem to help. PR Close #48351 | 05 December 2022, 20:04:05 UTC |
dc5f436 | piyush132000 | 04 December 2022, 05:46:03 UTC | docs: removed empty methods (#48343) Removed empty methods and import from files PR Close #48343 | 05 December 2022, 20:03:33 UTC |
7f31e55 | Derek Cormier | 02 December 2022, 20:49:22 UTC | build(bazel): mark an AIO sjs e2e test as flakey (#48331) Like a couple of the the other systemjs e2e tests, this one occasionally fails CI. PR Close #48331 | 05 December 2022, 20:02:29 UTC |
06c34cd | Andrew Scott | 23 November 2022, 23:17:14 UTC | refactor(router): Remove assignExtraOptionsToRouter helper function (#48313) This commit removes the unnecessary `assignExtraOptionsToRouter` helper function. This helper is not necessary because the options can be retrieved from DI and assigned during the construction on the Router. PR Close #48313 | 05 December 2022, 20:01:57 UTC |
58e5549 | Andrew Scott | 23 November 2022, 23:07:35 UTC | refactor(router): Eliminate constructor parameters in Router class (#48313) The Router constructor and `setupRouter` factory mainly exist as a legacy configuration. Since the Router's creation, the style in Angular has evolved quite a bit. This commit eliminates and cleans up some unnecessary comlicated code paths related to the router constructor/factory. Note that there are edits to the `setupTestingRouter` that could be seen as breaking. However, it is not for several reasons: 1. The function is documented as a factory function. If used as documented, the parameters should match what's available in DI 2. The function is totally unused by the Router itself and is not used in g3 either. I believe it was made publicApi by an error when updating documentation annotations long ago. PR Close #48313 | 05 December 2022, 20:01:57 UTC |
1b37306 | Derek Cormier | 04 December 2022, 03:51:04 UTC | build(bazel): set ci steps that build aio to 2xlarge+ (#48342) These steps builds AIO which is memory intensive. Running out of memory may be the cause of some ci flakiness. Change the executor size to test this theory. For context: The CLI process is randomly getting `Killed`, likely by the linux OOM killer. The Angular CLI builds happen on the host machine- no RBE. Without the Bazel migration they were previously already at ~63% peak RAM. With Bazel's overhead and e.g. remote caching, it seems to hit 100% (can be seen in CircleCI machine insights). OOM killer may then choose the highest consuming task. i.e. the Angular CLI and kill it. Angular CLI build ram consumption is proportional to the size of the app. AIO is not small https://app.circleci.com/pipelines/github/angular/angular/53992/workflows/ec47e3d8-2e7d-45b8-a802-7ec8ec4026c4/jobs/1265666/parallel-runs/0/steps/0-106 https://angular-team.slack.com/archives/C02PARQNMC1/p1670067910332809i PR Close #48342 | 05 December 2022, 11:40:56 UTC |
226441f | Paul Gschwendtner | 04 December 2022, 17:52:28 UTC | build: set target firebase project when setting deploy target (#48352) We now set the Firebase deploy target for AIO preview deployment via GitHub actions. It looks like configuring the deploy target also requires authentication / or a project. PR Close #48352 | 04 December 2022, 20:26:10 UTC |
38701ce | Paul Gschwendtner | 04 December 2022, 13:34:09 UTC | build: check out project before setting AIO preview targets (#48347) Checks out the Firebase project before setting the AIO preview targets. Surprisingly Firebase requires a project when setting resource identifiers for the targets. This is already done by the Firebase deploy action from @FirebaseExtended, but we need to do it earlier. PR Close #48347 | 04 December 2022, 16:14:11 UTC |
09388eb | Paul Gschwendtner | 04 December 2022, 11:23:53 UTC | build: use npx for setting firebase deploy targets in AIO preview (#48346) For the deploy job we still need to use the Firebase CLI to configure the proper hosting deploy targets. See: 011ef66a04d576b33e8828844a94960393fbc8aa. We don't have node modules installed in this job, and it would also be overkill to install them for just using firebase here. Since the action uses `npx firebase-tools` down the line anyway, we can use it without any speed downsides. PR Close #48346 | 04 December 2022, 13:18:40 UTC |
95886d8 | Paul Gschwendtner | 03 December 2022, 10:42:24 UTC | build: set firebase deploy target when deploying AIO preview (#48338) The AIO firebase project specifies `aio` as deploy target. This means that we need to configure this target before being able to deploy AIO previews. We use the default project target as target since the preview Firebase project does not use multi site targets. See: https://firebase.google.com/docs/hosting/multisites PR Close #48338 | 04 December 2022, 11:11:40 UTC |
6f79c2b | Angular Robot | 03 December 2022, 11:02:32 UTC | build: update actions/checkout action to v3 (#48337) See associated pull request for more information. PR Close #48337 | 03 December 2022, 16:09:10 UTC |
59f2d46 | Angular Robot | 03 December 2022, 10:33:21 UTC | build: update actions/checkout digest (#48336) See associated pull request for more information. PR Close #48336 | 03 December 2022, 10:45:39 UTC |
30226f0 | Paul Gschwendtner | 30 November 2022, 18:36:01 UTC | build: setup github actions for preview deployment of AIO (#48302) Sets up two new actions for supporting preview deployments of AIO by applying a label. i.e. `AIO preview`. PR Close #48302 | 03 December 2022, 10:13:26 UTC |
7bc6c2d | Paul Gschwendtner | 30 November 2022, 18:27:19 UTC | build: introduce common action for installing dependencies w/ cache in actions (#48302) Instead of repeating the node module installation step in future GitHub actions, a single place should contain the cache key etc. PR Close #48302 | 03 December 2022, 10:13:26 UTC |
dd4fd1f | Paul Gschwendtner | 02 December 2022, 14:48:14 UTC | build: attempt to avoid nodejs version flakiness in `test_win` job (#48326) The `test_win` job is occasionally failing where a super old NodeJS version is used even though we installed a proper one with `nvm`. It's unclear how the CircleCI windows VMs differ here, it's coming up rarely and is hard to reproduce when SSH-ing into VMs. Our best guess is that the existing NodeJS version from the container/image is super old and somehow takes precedence over the NVM-managed NodeJS version. This could happen due to bad ordering in the `$PATH` environment variable, or NVM not properly being wired up there. We attempt to fix this by always setting `$PATH` to the NVM symlink directory manually- with highest priority. PR Close #48326 | 02 December 2022, 22:55:55 UTC |
49af83e | Andrew Kushnir | 01 December 2022, 22:49:00 UTC | docs: added `missingNgForOfLet` extended diagnostics details page (#48320) Closes #48288. PR Close #48320 | 02 December 2022, 22:54:10 UTC |
2131c55 | Andrew Kushnir | 01 December 2022, 22:27:37 UTC | docs: added `missingControlFlowDirective` extended diagnostics details page (#48319) Closes #48287. PR Close #48319 | 02 December 2022, 19:46:54 UTC |
2af6388 | Alan Agius | 30 November 2022, 09:37:19 UTC | refactor(platform-browser): simplify `flattenStyles` method (#48293) With this change we simplify the `flattenStyles` logic using modern JavaScript. PR Close #48293 | 02 December 2022, 19:36:13 UTC |
2eccfd4 | Paul Gschwendtner | 02 December 2022, 16:38:32 UTC | build: fix unnecessary large runfiles in AIO when composing boilerplate (#48329) The `example-boilerplate` NodeJS binary always depends on all files from the individual examples. This is not needed as for composition w/ the boilerplate, only the target example content + boilerplate is needed in the runfiles. This reduces the runfiles and therefore speeds up boilerplate creation (which can happen for all examples concurrently). PR Close #48329 | 02 December 2022, 17:47:44 UTC |
f1cb455 | Paul Gschwendtner | 02 December 2022, 16:36:23 UTC | build: always ensure `node_modules` folders are not picked up in AIO (#48329) AIO has two risk places where `node_modules` folders may exist and may be accidentally picked up by Bazel- even though they are already added as part of `.bazelignore` and made visible through `.gitignore`. It doesn't hurt instructing Bazel to always ignore `node_modules` as part of the `glob` instruction. Co-authored-by: Joey Perrott <josephperrott@gmail.com> PR Close #48329 | 02 December 2022, 17:47:44 UTC |
520946d | Paul Gschwendtner | 02 December 2022, 16:23:58 UTC | build: do not use `--config=release` when building AIO for development (#48329) When building AIO using `yarn build` the `--config=release` is added. This was done as part of the Bazel migration to make sure the footer shows a Git revision via Bazel stamping. This does not provide enough benefits, compared to the downside of reduced caching. Bazel will discard the analysis cache when the stamp configuration changes. This may happen easily when you work in framework where `--config=release` is not used. Then when starting work in AIO: the config changes and the cache is discarded. This may even mean that existing framework package build artifacts may be discarded when an AIO local build is started. Co-authored-by: Joey Perrott <josephperrott@gmail.com> PR Close #48329 | 02 December 2022, 17:47:44 UTC |
cd526c1 | Paul Gschwendtner | 01 December 2022, 21:38:57 UTC | build: cleanup bazelignore file (#48329) These folders are no longer used in the source tree, and only exist in the Bazel sandbox. We can rmeove them. Node modules are kept because people may create them when editing the integration `package.json` files. PR Close #48329 | 02 December 2022, 17:47:43 UTC |
ff07194 | Paul Gschwendtner | 01 December 2022, 21:31:21 UTC | build: avoid common `node_modules/` bazel slowness pitfall (#48329) It's very easy to have some random `node_modules/` folder floating around in the repository. Especially coming from the old AIO example boilerplate setup (which heavily relied on nested node modules). These `node_modules/` folders can contain millions of files and might be accidentally picked up by Bazel `glob`'s (if they are authored in way that selects all nested files). This could surface in `aio/tools/examples/shared` or individual content examples, causing the Bazel analysis phase or runfile forest creation to take forever given more than 1.5 files being dealt with. Note that we keep the `examples/shared` node modules folder gitignored as otherwise Renovate may have problems when updating the folder. PR Close #48329 | 02 December 2022, 17:47:43 UTC |
c0fe820 | Andrew Scott | 01 December 2022, 20:23:01 UTC | docs: Add page for 'suffixNotSupported' diagnostic (#48315) Adds documentation page for `suffixNotSupported` extended diagnostic. fixes #48290 PR Close #48315 | 02 December 2022, 16:59:01 UTC |
fab1af7 | Pawel Kozlowski | 01 December 2022, 14:40:41 UTC | perf(docs-infra): remove usage of the NgClass directive (#48312) NgClass has non-negligable performance cost, especially if a different object is provided as NgClass input (which was the case for the NavItemComponent). The perfornace problem was noticed in the scope of the INP score investigations while profiling the https://angular.io/resources page. On this particular page replacing NgClass usage with alternatives results in 20x (!) runtime perf improvement. Such big improvement is possible since we avoid unneeded CSS classes removal / adding in the DOM. Part of #25518 PR Close #48312 | 02 December 2022, 16:58:20 UTC |
5a85e44 | Paul Gschwendtner | 02 December 2022, 14:33:29 UTC | build: enable progress messages for Bazel in CircleCI (#48316) Bazel otherwise may almost look as being stuck when it performs many slow e2e tests. We should show what is running, even it results in a little more output in the logs. PR Close #48316 | 02 December 2022, 16:57:45 UTC |
6921bf2 | Paul Gschwendtner | 02 December 2022, 14:14:07 UTC | build: patch `rules_nodejs` to ensure `nodejs_binary` targets can be used as tools in RBE (#48316) See full explanation in: https://github.com/bazelbuild/rules_nodejs/pull/3605 PR Close #48316 | 02 December 2022, 16:57:44 UTC |
b9ef619 | Paul Gschwendtner | 01 December 2022, 21:21:07 UTC | build: fix AIO jobs not running with RBE and CircleCI Bazel settings (#48316) The `.bazelrc` workspace file attempted to imported the `.bazelrc.user` file. This user file is set on CI to include the CI specific Bazel settings. Apparently this user rc import does not work, and fails silently given the `try-import`. It fails because for AIO Bazel commands we change the working directory using `yarn --cwd aio` and the `try-import` is relative to the working directory.. PR Close #48316 | 02 December 2022, 16:57:44 UTC |
167bc0d | Andrew Scott | 01 December 2022, 19:42:33 UTC | fix(compiler-cli): Produce diagnostic rather than crash when using invalid hostDirective (#48314) Because the language service uses the compiler, we try to produce as much useful information as possible rather than throwing hard errors. Hard errors cause the compiler to crash. While this can be acceptable when compiling a program as part of a regular build, this is undesirable for the language service. PR Close #48314 | 01 December 2022, 21:43:31 UTC |
b620d9b | piyush132000 | 25 November 2022, 16:20:43 UTC | docs: removed empty method (#48236) I removed empty methods from a file and unnecessary import and added export keyword for exportng module PR Close #48236 | 01 December 2022, 17:39:09 UTC |
73ec0c6 | Andrew Scott | 30 November 2022, 20:11:37 UTC | release: cut the v15.0.2 release | 30 November 2022, 20:20:17 UTC |
d933b17 | Pawel Kozlowski | 29 November 2022, 15:11:58 UTC | refactor(core): remove debug data structures (#48281) This commit removes several debug data structures from the framework runtime. The data structures in question were introduced in the framework in the past with the idea of having debugging aid in the form of the human-redable data structures. It turned out that in practice those data structures were not used (most of the fwk developers didn't even know about their existence!), yet we kept paying the price of maintaining those duplicated (prod and debug) version of the data structures. PR Close #48281 | 30 November 2022, 17:27:59 UTC |
db53ce4 | Angular Robot | 29 November 2022, 18:36:17 UTC | build: update dependency @types/uuid to v9 (#48285) See associated pull request for more information. PR Close #48285 | 30 November 2022, 17:27:04 UTC |
2a44592 | Andrew Scott | 30 November 2022, 00:19:09 UTC | refactor(router): Remove DeprecatedLoadChildren (#48292) This option has already been removed from availability externally. Internally, the last use has been removed for the type on Route.loadChildren. More testing will be necessary to verify nothing relies on the other code paths. PR Close #48292 | 30 November 2022, 16:29:11 UTC |
82756e8 | Andrew Scott | 17 November 2022, 01:09:19 UTC | refactor(router): Move navigationId handling to the transition manager (#48257) The navigationId is really just a count of how many navigations have been processed through the navigation pipeline. This tracking should be done as part of the navigation transition handler PR Close #48257 | 29 November 2022, 22:55:53 UTC |
60af2d0 | Andrew Scott | 17 November 2022, 00:19:23 UTC | refactor(router): Move transition subject into transition handler (#48257) The navigation transitions subject belongs in the navigation transitions handler rather than the Router. PR Close #48257 | 29 November 2022, 22:55:53 UTC |
92066f1 | Andrew Scott | 16 November 2022, 23:57:48 UTC | refactor(router): directly inject internal properties from DI (#48257) Rather than accessing router internal properties that are available in DI, this commit directly injects those dependencies in the navigation transition handler. Note that there are several other items that _should_ be injectable in DI (like the TitleStrategy) but because those are part of the Router public interface and writeable(!), they might be changed during runtime. We have to get these other items from the Router for now... PR Close #48257 | 29 November 2022, 22:55:53 UTC |
0a36f4f | Andrew Scott | 16 November 2022, 23:48:52 UTC | refactor(router): Get EnvironmentInjector directly in transition handler (#48257) Remove the NgModuleRef from the internal interface of the Router. This was only used to get the injector (equivalent to EnvironmentInjector). Instead, the navigation transition handler can directly inject the EnvironmentInjector PR Close #48257 | 29 November 2022, 22:55:53 UTC |
8e46fb5 | Andrew Scott | 16 November 2022, 23:45:11 UTC | refactor(router): Move configLoader to transition handler (#48257) The ConfigLoader is only used as part of the navigation transition. Moving the loader there completes the removal of event triggering in the router code. This all now lives in the transition handler (plus the router scroller, but let's ignore that...). PR Close #48257 | 29 November 2022, 22:55:53 UTC |
f36cf49 | Andrew Scott | 16 November 2022, 23:39:27 UTC | refactor(router): Move events subject to transition class (#48257) The events observable is part of the lifecycle of a navigation. This should be contained in the NavigationTransitions class rather than the Router. This Subject is re-exported by the router as an observable to maintain the public API PR Close #48257 | 29 November 2022, 22:55:52 UTC |
2409dd6 | Andrew Scott | 16 November 2022, 22:59:51 UTC | refactor(router): remove malformedUriHandler from interface passed to transitions (#48257) The malformedUriHandler is not used during the navigation transition and can be removed form the interface PR Close #48257 | 29 November 2022, 22:55:52 UTC |
2067643 | Angular Robot | 24 November 2022, 07:35:12 UTC | build: update eslint dependencies (#48216) See associated pull request for more information. PR Close #48216 | 29 November 2022, 20:29:47 UTC |
a3bbc6d | Alan Agius | 24 November 2022, 07:57:18 UTC | build: remove `codelyzer` from aio dependencies (#48216) This package is no longer used. PR Close #48216 | 29 November 2022, 20:29:47 UTC |
3c62c70 | Alan Agius | 24 November 2022, 07:56:21 UTC | build: update cross-repo dependencies to latest stable version (#48216) With this change we update the cross-repo dependencies to the latest stable version PR Close #48216 | 29 November 2022, 20:29:46 UTC |
fb4f228 | Angular Robot | 29 November 2022, 06:03:33 UTC | build: update github/codeql-action action to v2.1.34 (#48272) See associated pull request for more information. PR Close #48272 | 29 November 2022, 20:29:20 UTC |
bec0007 | Rokas Brazdžionis | 29 November 2022, 07:58:22 UTC | docs: update date pipe default timezone injection token reference (#48274) replace deprecated `DATE_PIPE_DEFAULT_TIMEZONE` with `DATE_PIPE_DEFAULT_OPTIONS` PR Close #48274 | 29 November 2022, 17:40:28 UTC |
4df7301 | Paul Gschwendtner | 29 November 2022, 15:41:22 UTC | build: hide `--loader` warning when ESM import patch is installed (#48282) Similar to the Rules NodeJS require patch, we have an ESM import patch as of the AIO Bazel migration (to support ESM scripts better). This script uses `--loader`, an experimental NodeJS flag. This is similar to how `ts-node` uses it. We should disable the warnings as it results in a lot of unreadable Bazel output and the warnings are okay to be ignored. Note that we cannot fine-grain disable the specific warning so all others would be disabled too. Realistically we haven't seen any in the past and long-term we will be not relying on patched resolution anyway (looking at `rules_js`). PR Close #48282 | 29 November 2022, 17:39:26 UTC |
a192dea | Andrew Scott | 29 November 2022, 00:40:16 UTC | Revert "refactor(router): remove malformedUriHandler from interface passed to transitions (#48257)" (#48270) This reverts commit c20a7eeba6ebd59aa056fd61e945b9ecad6cf9b1. PR Close #48270 | 29 November 2022, 00:58:53 UTC |
d29cbe8 | Andrew Scott | 29 November 2022, 00:40:13 UTC | Revert "refactor(router): Move events subject to transition class (#48257)" (#48270) This reverts commit f88559eb48a6d24e8a54a51cb11dd25ba28c9840. PR Close #48270 | 29 November 2022, 00:58:53 UTC |
1eef647 | Andrew Scott | 29 November 2022, 00:40:10 UTC | Revert "refactor(router): Move configLoader to transition handler (#48257)" (#48270) This reverts commit 8c8ded8d31c922cf6ce5edb30ec659f73025ca9d. PR Close #48270 | 29 November 2022, 00:58:53 UTC |
9745fac | Andrew Scott | 29 November 2022, 00:40:08 UTC | Revert "refactor(router): Get EnvironmentInjector directly in transition handler (#48257)" (#48270) This reverts commit 03519968c03c53d94f950bb050d3d876e5ab756d. PR Close #48270 | 29 November 2022, 00:58:52 UTC |
7032bf0 | Andrew Scott | 29 November 2022, 00:40:05 UTC | Revert "refactor(router): directly inject internal properties from DI (#48257)" (#48270) This reverts commit ce38759f543381c37e0076ee7508797af207856e. PR Close #48270 | 29 November 2022, 00:58:52 UTC |
88aec87 | Andrew Scott | 29 November 2022, 00:40:02 UTC | Revert "refactor(router): Move transition subject into transition handler (#48257)" (#48270) This reverts commit 0d883484308a56e70fc46047beec566c1ddf01af. PR Close #48270 | 29 November 2022, 00:58:52 UTC |
f2d20d5 | Andrew Scott | 29 November 2022, 00:39:59 UTC | Revert "refactor(router): Move navigationId handling to the transition manager (#48257)" (#48270) This reverts commit ea114a0034d5b038721ec96b6037de54889c4f8a. PR Close #48270 | 29 November 2022, 00:58:52 UTC |
bd59a1a | Bob Watson | 28 November 2022, 21:24:39 UTC | docs: update docs to use new build and test commands (#48266) PR Close #48266 | 28 November 2022, 23:33:53 UTC |
c0601db | Matthieu Riegler | 26 November 2022, 01:11:17 UTC | test(core): remove some ViewEngine related test code (#48238) Some tests had comments relating to ViewEngine that were not needed anymore since VE was dropped. PR Close #48238 | 28 November 2022, 21:08:23 UTC |
aa920aa | Matthieu Riegler | 27 November 2022, 17:09:40 UTC | refactor(router): remove non-null assertions (#48244) As part of #24571, removing non-null assertions (where appropriate) PR Close #48244 | 28 November 2022, 21:07:59 UTC |
6eb2f76 | Derek Cormier | 28 November 2022, 19:25:36 UTC | build(bazel): fix aio deploy script Move the copy of the bazel dist folder to the firebase dist folder earlier on in the process so that any checks operate out of a single folder. | 28 November 2022, 20:29:35 UTC |
ea114a0 | Andrew Scott | 17 November 2022, 01:09:19 UTC | refactor(router): Move navigationId handling to the transition manager (#48257) The navigationId is really just a count of how many navigations have been processed through the navigation pipeline. This tracking should be done as part of the navigation transition handler PR Close #48257 | 28 November 2022, 19:54:43 UTC |
0d88348 | Andrew Scott | 17 November 2022, 00:19:23 UTC | refactor(router): Move transition subject into transition handler (#48257) The navigation transitions subject belongs in the navigation transitions handler rather than the Router. PR Close #48257 | 28 November 2022, 19:54:43 UTC |
ce38759 | Andrew Scott | 16 November 2022, 23:57:48 UTC | refactor(router): directly inject internal properties from DI (#48257) Rather than accessing router internal properties that are available in DI, this commit directly injects those dependencies in the navigation transition handler. Note that there are several other items that _should_ be injectable in DI (like the TitleStrategy) but because those are part of the Router public interface and writeable(!), they might be changed during runtime. We have to get these other items from the Router for now... PR Close #48257 | 28 November 2022, 19:54:43 UTC |
0351996 | Andrew Scott | 16 November 2022, 23:48:52 UTC | refactor(router): Get EnvironmentInjector directly in transition handler (#48257) Remove the NgModuleRef from the internal interface of the Router. This was only used to get the injector (equivalent to EnvironmentInjector). Instead, the navigation transition handler can directly inject the EnvironmentInjector PR Close #48257 | 28 November 2022, 19:54:43 UTC |
8c8ded8 | Andrew Scott | 16 November 2022, 23:45:11 UTC | refactor(router): Move configLoader to transition handler (#48257) The ConfigLoader is only used as part of the navigation transition. Moving the loader there completes the removal of event triggering in the router code. This all now lives in the transition handler (plus the router scroller, but let's ignore that...). PR Close #48257 | 28 November 2022, 19:54:43 UTC |
f88559e | Andrew Scott | 16 November 2022, 23:39:27 UTC | refactor(router): Move events subject to transition class (#48257) The events observable is part of the lifecycle of a navigation. This should be contained in the NavigationTransitions class rather than the Router. This Subject is re-exported by the router as an observable to maintain the public API PR Close #48257 | 28 November 2022, 19:54:43 UTC |
c20a7ee | Andrew Scott | 16 November 2022, 22:59:51 UTC | refactor(router): remove malformedUriHandler from interface passed to transitions (#48257) The malformedUriHandler is not used during the navigation transition and can be removed form the interface PR Close #48257 | 28 November 2022, 19:54:43 UTC |
621013a | Andrew Scott | 16 November 2022, 22:58:59 UTC | refactor(router): move lastSuccesfulNavigation to navigation transitions (#48257) lastSuccessfulNavigation is only used in the transition so it does not need to live in Router PR Close #48257 | 28 November 2022, 19:54:43 UTC |
864a96d | mgechev | 21 November 2022, 21:37:46 UTC | docs: add state of javascript banner (#48260) PR Close #48260 | 28 November 2022, 19:54:18 UTC |
458d62b | Kristiyan Kostadinov | 24 November 2022, 09:10:24 UTC | build: update angular version of in-memory-web-api (#48218) Bumps up the required Angular version of `angular-in-memory-web-api` to 15. Fixes #48197. PR Close #48218 | 28 November 2022, 17:13:47 UTC |
ebb3f58 | piyush132000 | 25 November 2022, 04:13:46 UTC | docs: removed empty methods (#48230) I removed empty methods from a file and unnecessary import PR Close #48230 | 28 November 2022, 17:13:20 UTC |
1e483eb | Alan Agius | 25 November 2022, 10:24:46 UTC | refactor(platform-server): remove `Injector` dependency for `initDominoAdapter` factory (#48231) The injector is not used by this factory. PR Close #48231 | 28 November 2022, 17:12:36 UTC |
dab7198 | Alan Agius | 25 November 2022, 13:16:03 UTC | refactor(core): remove unused private APIs (#48234) Remove private code which is not used by the Framework. PR Close #48234 | 28 November 2022, 17:11:26 UTC |
34ccffe | Aristeidis Bampakos | 26 November 2022, 16:04:37 UTC | docs: update deployment to GitHub Pages (#48239) The GitHub Pages section has been moved to the left sidebar of the Settings page. PR Close #48239 | 28 November 2022, 17:11:00 UTC |
cfd8702 | Derek Cormier | 23 November 2022, 21:28:40 UTC | build(bazel): fix pwa test metrics (#48214) Prior to the AIO bazel migration, the pwa test script only tested the pwa metric. A bug was introduced where the score target was used for all metrics, causing the AIO deploy test to fail. PR Close #48214 | 23 November 2022, 23:20:36 UTC |
e56f6d2 | Derek Cormier | 23 November 2022, 20:45:05 UTC | build(bazel): copy dist folder to aio for firebase deployment (#48214) Firebase requires the distributable to be in the same folder as firebase.json. PR Close #48214 | 23 November 2022, 23:20:36 UTC |