Revision 5d9b70f7d52eb14bb37861c663bae44de9521c35 authored by Mathias Nyman on 08 December 2017, 16:10:05 UTC, committed by Greg Kroah-Hartman on 08 December 2017, 17:26:34 UTC
Avoid null pointer dereference if some function is walking through the devs array accessing members of a new virt_dev that is mid allocation. Add the virt_dev to xhci->devs[i] _after_ the virt_device and all its members are properly allocated. issue found by KASAN: null-ptr-deref in xhci_find_slot_id_by_port "Quick analysis suggests that xhci_alloc_virt_device() is not mutex protected. If so, there is a time frame where xhci->devs[slot_id] is set but not fully initialized. Specifically, xhci->devs[i]->udev can be NULL." Cc: stable <stable@vger.kernel.org> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent be6123d
| File | Mode | Size |
|---|---|---|
| sysfs-bus-usb | -rw-r--r-- | 1.3 KB |
| sysfs-driver-hid-roccat-arvo | -rw-r--r-- | 2.8 KB |
| sysfs-driver-hid-roccat-isku | -rw-r--r-- | 7.9 KB |
| sysfs-driver-hid-roccat-koneplus | -rw-r--r-- | 7.8 KB |
| sysfs-driver-hid-roccat-konepure | -rw-r--r-- | 5.5 KB |
| sysfs-driver-hid-roccat-kovaplus | -rw-r--r-- | 6.2 KB |
| sysfs-driver-hid-roccat-lua | -rw-r--r-- | 372 bytes |
| sysfs-driver-hid-roccat-pyra | -rw-r--r-- | 6.2 KB |
| sysfs-driver-hid-roccat-ryos | -rw-r--r-- | 9.2 KB |
| sysfs-driver-hid-roccat-savu | -rw-r--r-- | 4.0 KB |
| sysfs-firmware-acpi | -rw-r--r-- | 384 bytes |
| sysfs-gpio | -rw-r--r-- | 1.3 KB |
Computing file changes ...
