Revision 5d9b70f7d52eb14bb37861c663bae44de9521c35 authored by Mathias Nyman on 08 December 2017, 16:10:05 UTC, committed by Greg Kroah-Hartman on 08 December 2017, 17:26:34 UTC
Avoid null pointer dereference if some function is walking through the
devs array accessing members of a new virt_dev that is mid allocation.

Add the virt_dev to xhci->devs[i] _after_ the virt_device and all its
members are properly allocated.

issue found by KASAN: null-ptr-deref in xhci_find_slot_id_by_port

"Quick analysis suggests that xhci_alloc_virt_device() is not mutex
protected. If so, there is a time frame where xhci->devs[slot_id] is set
but not fully initialized. Specifically, xhci->devs[i]->udev can be NULL."

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent be6123d
History
File Mode Size
endpoint
00-INDEX -rw-r--r-- 860 bytes
MSI-HOWTO.txt -rw-r--r-- 11.4 KB
PCIEBUS-HOWTO.txt -rw-r--r-- 7.6 KB
pci-error-recovery.txt -rw-r--r-- 18.3 KB
pci-iov-howto.txt -rw-r--r-- 4.3 KB
pci.txt -rw-r--r-- 24.6 KB
pcieaer-howto.txt -rw-r--r-- 10.7 KB

back to top