Revision - 5ed9dc9 - team: no need to do team_notify_peers or team_mcast_rejoin when [...] - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

17 May 2024, 09:02:56 UTC

Revision 5ed9dc99107144f83b6c1bb52a69b58875baf540 authored by Hangbin Liu on 22 November 2018, 08:15:28 UTC, committed by David S. Miller on 24 November 2018, 01:18:15 UTC

team: no need to do team_notify_peers or team_mcast_rejoin when disabling port

team_notify_peers() will send ARP and NA to notify peers. team_mcast_rejoin()
will send multicast join group message to notify peers. We should do this when
enabling/changed to a new port. But it doesn't make sense to do it when a port
is disabled.

On the other hand, when we set mcast_rejoin_count to 2, and do a failover,
team_port_disable() will increase mcast_rejoin.count_pending to 2 and then
team_port_enable() will increase mcast_rejoin.count_pending to 4. We will send
4 mcast rejoin messages at latest, which will make user confused. The same
with notify_peers.count.

Fix it by deleting team_notify_peers() and team_mcast_rejoin() in
team_port_disable().

Reported-by: Liang Li <liali@redhat.com>
Fixes: fc423ff00df3a ("team: add peer notification")
Fixes: 492b200efdd20 ("team: add support for sending multicast rejoins")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 parent 18ba58e

Files
Changes

Permalinks

Tip revision: 5ed9dc99107144f83b6c1bb52a69b58875baf540 authored by Hangbin Liu on 22 November 2018, 08:15:28 UTC
team: no need to do team_notify_peers or team_mcast_rejoin when disabling port

Tip revision: 5ed9dc9

File	Mode	Size
Documentation
LICENSES
arch
block
certs
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.clang-format	-rw-r--r--	12.7 KB
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	31 bytes
.gitattributes	-rw-r--r--	30 bytes
.gitignore	-rw-r--r--	1.5 KB
.mailmap	-rw-r--r--	10.5 KB
COPYING	-rw-r--r--	423 bytes
CREDITS	-rw-r--r--	96.5 KB
Kbuild	-rw-r--r--	2.2 KB
Kconfig	-rw-r--r--	563 bytes
MAINTAINERS	-rw-r--r--	470.9 KB
Makefile	-rw-r--r--	59.7 KB
README	-rw-r--r--	727 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

team: no need to do team_notify_peers or team_mcast_rejoin when disabling port

README