Revision 5ffa5051c36c670be1a38000de442b002920ac12 authored by Joe Downing on 22 March 2018, 07:35:35 UTC, committed by Blink WPT Bot on 22 March 2018, 07:45:48 UTC
This change moves the KeyboardLock API methods to a 'keyboard' namespace on the Navigator object. We are doing this work now as there has been a request for additional keyboard functionality that would also be placed on the new keyboard object and we wanted to move the KeyboardLock methods there for consistency before we launch. KeyboardLock API Spec is here: https://w3c.github.io/keyboard-lock/#API Old calling pattern: Navigator.keyboardLock(); Navigator.keyboardUnlock(); New calling pattern: Navigator.keyboard.lock(); Navigator.keyboard.unlock(); Note: The main logic in the KeyboardLock.cpp class and tests is the same as it was, however the file changed enough that git does not recognize it as a file move. BUG=680809 Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4 Reviewed-on: https://chromium-review.googlesource.com/969656 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544996}
1 parent 1a8c195
filesystementry-getParent-manual.html
<!DOCTYPE html>
<meta charset=utf-8>
<title>Entries API: FileSystemEntry getParent() manual test</title>
<link rel=help href="https://wicg.github.io/entries-api/#dom-filesystementry-getparentapi-entry">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="support.js"></script>
<script>
entry_test((t, entry) => {
assert_idl_attribute(entry, 'getParent', 'FileSystemEntry has getParent method');
assert_equals(typeof entry.getParent, 'function', 'FileSystemEntry has a getParent() method');
assert_equals(entry.getParent(), void 0, 'getParent() arguments are optional');
entry.getParent(t.step_func(parent => {
assert_true(parent.isDirectory, 'parent should be a directory');
assert_equals(parent.fullPath, '/', 'parent should be root');
assert_equals(parent.name, '', 'root name is empty string');
t.done();
}), t.unreached_func('getParent() should not fail'));
}, 'FileSystemEntry - getParent()');
// TODO: Manual test for getParent() where containing directory is removed before getParent() is called.
</script>
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...