Skip to main content

Browse the archive

https://github.com/torvalds/linux
17 May 2024, 11:00:25 UTC
Revision 605108acfe6233b72e2f803aa1cb59a2af3001ca authored by Paolo Abeni on 21 November 2018, 17:21:35 UTC, committed by David S. Miller on 23 November 2018, 19:18:53 UTC 
net: don't keep lonely packets forever in the gro hash
 
Eric noted that with UDP GRO and NAPI timeout, we could keep a single
UDP packet inside the GRO hash forever, if the related NAPI instance
calls napi_gro_complete() at an higher frequency than the NAPI timeout.
Willem noted that even TCP packets could be trapped there, till the
next retransmission.
This patch tries to address the issue, flushing the old packets -
those with a NAPI_GRO_CB age before the current jiffy - before scheduling
the NAPI timeout. The rationale is that such a timeout should be
well below a jiffy and we are not flushing packets eligible for sane GRO.

v1  -> v2:
 - clarified the commit message and comment

RFC -> v1:
 - added 'Fixes tags', cleaned-up the wording.

Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Fixes: 3b47d30396ba ("net: gro: add a per device gro flush timer")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 896585d
Raw File
Tip revision: 605108acfe6233b72e2f803aa1cb59a2af3001ca authored by Paolo Abeni on 21 November 2018, 17:21:35 UTC
net: don't keep lonely packets forever in the gro hash
Tip revision: 605108a
.cocciconfig 
[spatch]
	options = --timeout 200
	options = --use-gitgrep
back to top