https://github.com/torvalds/linux
Revision 60f583d56aa515b896a9d94f860f52640c1e8a75 authored by Dave Hansen on 07 March 2013, 16:31:51 UTC, committed by H. Peter Anvin on 07 March 2013, 21:23:28 UTC
kernel_map_sync_memtype() is called from a variety of contexts. The pat.c code that calls it seems to ensure that it is not called for non-ram areas by checking via pat_pagerange_is_ram(). It is important that it only be called on the actual identity map because there *IS* no map to sync for highmem pages, or for memory holes. The ioremap.c uses are not as careful as those from pat.c, and call kernel_map_sync_memtype() on PCI space which is in the middle of the kernel identity map _range_, but is not actually mapped. This patch adds a check to kernel_map_sync_memtype() which probably duplicates some of the checks already in pat.c. But, it is necessary for the ioremap.c uses and shouldn't hurt other callers. I have reproduced this bug and this patch fixes it for me and the original bug reporter: https://lkml.org/lkml/2013/2/5/396 Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com> Link: http://lkml.kernel.org/r/20130307163151.D9B58C4E@kernel.stglabs.ibm.com Signed-off-by: Dave Hansen <dave@sr71.net> Tested-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
1 parent 3c4aff6
Tip revision: 60f583d56aa515b896a9d94f860f52640c1e8a75 authored by Dave Hansen on 07 March 2013, 16:31:51 UTC
x86: Do not try to sync identity map for non-mapped pages
x86: Do not try to sync identity map for non-mapped pages
Tip revision: 60f583d
| File | Mode | Size |
|---|---|---|
| basic | ||
| coccinelle | ||
| dtc | ||
| genksyms | ||
| kconfig | ||
| ksymoops | ||
| mod | ||
| package | ||
| rt-tester | ||
| selinux | ||
| tracing | ||
| .gitignore | -rw-r--r-- | 122 bytes |
| Kbuild.include | -rw-r--r-- | 10.1 KB |
| Lindent | -rwxr-xr-x | 460 bytes |
| Makefile | -rw-r--r-- | 1.4 KB |
| Makefile.asm-generic | -rw-r--r-- | 684 bytes |
| Makefile.build | -rw-r--r-- | 15.1 KB |
| Makefile.clean | -rw-r--r-- | 3.2 KB |
| Makefile.fwinst | -rw-r--r-- | 2.0 KB |
| Makefile.headersinst | -rw-r--r-- | 4.1 KB |
| Makefile.help | -rw-r--r-- | 68 bytes |
| Makefile.host | -rw-r--r-- | 6.5 KB |
| Makefile.lib | -rw-r--r-- | 13.5 KB |
| Makefile.modbuiltin | -rw-r--r-- | 1.8 KB |
| Makefile.modinst | -rw-r--r-- | 1.2 KB |
| Makefile.modpost | -rw-r--r-- | 5.0 KB |
| Makefile.modsign | -rw-r--r-- | 1003 bytes |
| asn1_compiler.c | -rw-r--r-- | 33.8 KB |
| bin2c.c | -rw-r--r-- | 702 bytes |
| bloat-o-meter | -rwxr-xr-x | 1.8 KB |
| bootgraph.pl | -rw-r--r-- | 5.6 KB |
| checkincludes.pl | -rwxr-xr-x | 1.8 KB |
| checkkconfigsymbols.sh | -rwxr-xr-x | 1.8 KB |
| checkpatch.pl | -rwxr-xr-x | 100.6 KB |
| checkstack.pl | -rwxr-xr-x | 5.3 KB |
| checksyscalls.sh | -rwxr-xr-x | 5.5 KB |
| checkversion.pl | -rwxr-xr-x | 1.9 KB |
| cleanfile | -rwxr-xr-x | 3.4 KB |
| cleanpatch | -rwxr-xr-x | 5.0 KB |
| coccicheck | -rwxr-xr-x | 3.6 KB |
| config | -rwxr-xr-x | 3.6 KB |
| conmakehash.c | -rw-r--r-- | 6.0 KB |
| decodecode | -rwxr-xr-x | 1.9 KB |
| depmod.sh | -rwxr-xr-x | 1.7 KB |
| diffconfig | -rwxr-xr-x | 3.6 KB |
| docproc.c | -rw-r--r-- | 14.1 KB |
| export_report.pl | -rw-r--r-- | 4.5 KB |
| extract-ikconfig | -rwxr-xr-x | 1.6 KB |
| extract-vmlinux | -rwxr-xr-x | 1.6 KB |
| gcc-goto.sh | -rw-r--r-- | 465 bytes |
| gcc-version.sh | -rw-r--r-- | 822 bytes |
| gcc-x86_32-has-stack-protector.sh | -rw-r--r-- | 184 bytes |
| gcc-x86_64-has-stack-protector.sh | -rw-r--r-- | 200 bytes |
| gen_initramfs_list.sh | -rw-r--r-- | 7.4 KB |
| get_maintainer.pl | -rwxr-xr-x | 54.1 KB |
| gfp-translate | -rwxr-xr-x | 1.7 KB |
| headerdep.pl | -rwxr-xr-x | 3.5 KB |
| headers.sh | -rwxr-xr-x | 530 bytes |
| headers_check.pl | -rw-r--r-- | 3.5 KB |
| headers_install.pl | -rw-r--r-- | 1.9 KB |
| kallsyms.c | -rw-r--r-- | 15.2 KB |
| kernel-doc | -rwxr-xr-x | 71.4 KB |
| link-vmlinux.sh | -rw-r--r-- | 5.5 KB |
| makelst | -rwxr-xr-x | 773 bytes |
| markup_oops.pl | -rw-r--r-- | 8.1 KB |
| mkcompile_h | -rwxr-xr-x | 2.5 KB |
| mkmakefile | -rw-r--r-- | 1.2 KB |
| mksysmap | -rw-r--r-- | 1.3 KB |
| mkuboot.sh | -rwxr-xr-x | 379 bytes |
| mkversion | -rw-r--r-- | 74 bytes |
| module-common.lds | -rw-r--r-- | 737 bytes |
| namespace.pl | -rwxr-xr-x | 13.0 KB |
| patch-kernel | -rwxr-xr-x | 9.9 KB |
| pnmtologo.c | -rw-r--r-- | 11.9 KB |
| profile2linkerlist.pl | -rw-r--r-- | 375 bytes |
| recordmcount.c | -rw-r--r-- | 12.4 KB |
| recordmcount.h | -rw-r--r-- | 16.3 KB |
| recordmcount.pl | -rwxr-xr-x | 17.5 KB |
| setlocalversion | -rwxr-xr-x | 3.9 KB |
| show_delta | -rwxr-xr-x | 3.0 KB |
| sign-file | -rwxr-xr-x | 12.2 KB |
| sortextable.c | -rw-r--r-- | 6.8 KB |
| sortextable.h | -rw-r--r-- | 4.9 KB |
| tags.sh | -rwxr-xr-x | 9.4 KB |
| unifdef.c | -rw-r--r-- | 34.8 KB |
| ver_linux | -rwxr-xr-x | 3.1 KB |
| xz_wrap.sh | -rw-r--r-- | 562 bytes |
Computing file changes ...
