Revision 61609d01cbb3ab865c8cccaf85e6837c47096480 authored by Yuri Tikhonov on 13 April 2009, 21:40:11 UTC, committed by Linus Torvalds on 13 April 2009, 22:04:32 UTC
Fix a division by zero which we have in shmem_truncate_range() and shmem_unuse_inode() when using big PAGE_SIZE values (e.g. 256kB on ppc44x). With 256kB PAGE_SIZE, the ENTRIES_PER_PAGEPAGE constant becomes too large (0x1.0000.0000) on a 32-bit kernel, so this patch just changes its type from 'unsigned long' to 'unsigned long long'. Hugh: reverted its unsigned long longs in shmem_truncate_range() and shmem_getpage(): the pagecache index cannot be more than an unsigned long, so the divisions by zero occurred in unreached code. It's a pity we need any ULL arithmetic here, but I found no pretty way to avoid it. Signed-off-by: Yuri Tikhonov <yur@emcraft.com> Signed-off-by: Hugh Dickins <hugh@veritas.com> Cc: Paul Mackerras <paulus@samba.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 347486b
| File | Mode | Size |
|---|---|---|
| Documentation | ||
| arch | ||
| block | ||
| crypto | ||
| drivers | ||
| firmware | ||
| fs | ||
| include | ||
| init | ||
| ipc | ||
| kernel | ||
| lib | ||
| mm | ||
| net | ||
| samples | ||
| scripts | ||
| security | ||
| sound | ||
| usr | ||
| virt | ||
| .gitignore | -rw-r--r-- | 867 bytes |
| .mailmap | -rw-r--r-- | 3.9 KB |
| COPYING | -rw-r--r-- | 18.3 KB |
| CREDITS | -rw-r--r-- | 91.6 KB |
| Kbuild | -rw-r--r-- | 2.4 KB |
| MAINTAINERS | -rw-r--r-- | 142.0 KB |
| Makefile | -rw-r--r-- | 53.6 KB |
| README | -rw-r--r-- | 16.7 KB |
| REPORTING-BUGS | -rw-r--r-- | 3.1 KB |
Computing file changes ...
