Revision 61bf318eac2c13356f7bd1c6a05421ef504ccc8a authored by Sergei Trofimovich on 13 March 2021, 05:08:27 UTC, committed by Linus Torvalds on 13 March 2021, 19:27:31 UTC
In https://bugs.gentoo.org/769614 Dmitry noticed that
`ptrace(PTRACE_GET_SYSCALL_INFO)` does not return error sign properly.
The bug is in mismatch between get/set errors:
static inline long syscall_get_error(struct task_struct *task,
struct pt_regs *regs)
{
return regs->r10 == -1 ? regs->r8:0;
}
static inline long syscall_get_return_value(struct task_struct *task,
struct pt_regs *regs)
{
return regs->r8;
}
static inline void syscall_set_return_value(struct task_struct *task,
struct pt_regs *regs,
int error, long val)
{
if (error) {
/* error < 0, but ia64 uses > 0 return value */
regs->r8 = -error;
regs->r10 = -1;
} else {
regs->r8 = val;
regs->r10 = 0;
}
}
Tested on v5.10 on rx3600 machine (ia64 9040 CPU).
Link: https://lkml.kernel.org/r/20210221002554.333076-2-slyfox@gentoo.org
Link: https://bugs.gentoo.org/769614
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Reported-by: Dmitry V. Levin <ldv@altlinux.org>
Reviewed-by: Dmitry V. Levin <ldv@altlinux.org>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 0ceb1ac
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 4.7 KB |
| Makefile | -rw-r--r-- | 716 bytes |
| README.dino | -rw-r--r-- | 1.0 KB |
| asp.c | -rw-r--r-- | 3.3 KB |
| ccio-dma.c | -rw-r--r-- | 46.6 KB |
| dino.c | -rw-r--r-- | 31.0 KB |
| eisa.c | -rw-r--r-- | 11.5 KB |
| eisa_eeprom.c | -rw-r--r-- | 2.0 KB |
| eisa_enumerator.c | -rw-r--r-- | 11.2 KB |
| gsc.c | -rw-r--r-- | 5.4 KB |
| gsc.h | -rw-r--r-- | 1.5 KB |
| hppb.c | -rw-r--r-- | 2.5 KB |
| iommu-helpers.h | -rw-r--r-- | 4.8 KB |
| iommu.h | -rw-r--r-- | 1.4 KB |
| iosapic.c | -rw-r--r-- | 28.4 KB |
| iosapic_private.h | -rw-r--r-- | 5.0 KB |
| lasi.c | -rw-r--r-- | 6.0 KB |
| lba_pci.c | -rw-r--r-- | 50.6 KB |
| led.c | -rw-r--r-- | 19.8 KB |
| pdc_stable.c | -rw-r--r-- | 29.7 KB |
| power.c | -rw-r--r-- | 7.2 KB |
| sba_iommu.c | -rw-r--r-- | 57.1 KB |
| superio.c | -rw-r--r-- | 13.6 KB |
| wax.c | -rw-r--r-- | 3.0 KB |
Computing file changes ...
