Revision 61bf318eac2c13356f7bd1c6a05421ef504ccc8a authored by Sergei Trofimovich on 13 March 2021, 05:08:27 UTC, committed by Linus Torvalds on 13 March 2021, 19:27:31 UTC
In https://bugs.gentoo.org/769614 Dmitry noticed that `ptrace(PTRACE_GET_SYSCALL_INFO)` does not return error sign properly. The bug is in mismatch between get/set errors: static inline long syscall_get_error(struct task_struct *task, struct pt_regs *regs) { return regs->r10 == -1 ? regs->r8:0; } static inline long syscall_get_return_value(struct task_struct *task, struct pt_regs *regs) { return regs->r8; } static inline void syscall_set_return_value(struct task_struct *task, struct pt_regs *regs, int error, long val) { if (error) { /* error < 0, but ia64 uses > 0 return value */ regs->r8 = -error; regs->r10 = -1; } else { regs->r8 = val; regs->r10 = 0; } } Tested on v5.10 on rx3600 machine (ia64 9040 CPU). Link: https://lkml.kernel.org/r/20210221002554.333076-2-slyfox@gentoo.org Link: https://bugs.gentoo.org/769614 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> Reported-by: Dmitry V. Levin <ldv@altlinux.org> Reviewed-by: Dmitry V. Levin <ldv@altlinux.org> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 0ceb1ac
File | Mode | Size |
---|---|---|
hisilicon | ||
sti | ||
tegra | ||
Kconfig | -rw-r--r-- | 8.1 KB |
Makefile | -rw-r--r-- | 1.6 KB |
core.c | -rw-r--r-- | 25.8 KB |
reset-a10sr.c | -rw-r--r-- | 3.2 KB |
reset-ath79.c | -rw-r--r-- | 3.3 KB |
reset-axs10x.c | -rw-r--r-- | 2.1 KB |
reset-bcm6345.c | -rw-r--r-- | 3.5 KB |
reset-berlin.c | -rw-r--r-- | 2.5 KB |
reset-brcmstb-rescal.c | -rw-r--r-- | 2.8 KB |
reset-brcmstb.c | -rw-r--r-- | 3.3 KB |
reset-hsdk.c | -rw-r--r-- | 3.5 KB |
reset-imx7.c | -rw-r--r-- | 13.9 KB |
reset-intel-gw.c | -rw-r--r-- | 6.4 KB |
reset-k210.c | -rw-r--r-- | 3.0 KB |
reset-lantiq.c | -rw-r--r-- | 5.2 KB |
reset-lpc18xx.c | -rw-r--r-- | 5.7 KB |
reset-meson-audio-arb.c | -rw-r--r-- | 4.9 KB |
reset-meson.c | -rw-r--r-- | 3.8 KB |
reset-npcm.c | -rw-r--r-- | 7.6 KB |
reset-oxnas.c | -rw-r--r-- | 2.7 KB |
reset-pistachio.c | -rw-r--r-- | 3.3 KB |
reset-qcom-aoss.c | -rw-r--r-- | 3.5 KB |
reset-qcom-pdc.c | -rw-r--r-- | 3.2 KB |
reset-raspberrypi.c | -rw-r--r-- | 3.1 KB |
reset-scmi.c | -rw-r--r-- | 3.4 KB |
reset-simple.c | -rw-r--r-- | 5.5 KB |
reset-socfpga.c | -rw-r--r-- | 2.1 KB |
reset-stm32mp1.c | -rw-r--r-- | 2.8 KB |
reset-sunxi.c | -rw-r--r-- | 1.9 KB |
reset-ti-sci.c | -rw-r--r-- | 8.1 KB |
reset-ti-syscon.c | -rw-r--r-- | 7.1 KB |
reset-uniphier-glue.c | -rw-r--r-- | 4.8 KB |
reset-uniphier.c | -rw-r--r-- | 14.1 KB |
reset-zynq.c | -rw-r--r-- | 3.2 KB |
reset-zynqmp.c | -rw-r--r-- | 3.5 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...