Revision 61bf318eac2c13356f7bd1c6a05421ef504ccc8a authored by Sergei Trofimovich on 13 March 2021, 05:08:27 UTC, committed by Linus Torvalds on 13 March 2021, 19:27:31 UTC
In https://bugs.gentoo.org/769614 Dmitry noticed that
`ptrace(PTRACE_GET_SYSCALL_INFO)` does not return error sign properly.
The bug is in mismatch between get/set errors:
static inline long syscall_get_error(struct task_struct *task,
struct pt_regs *regs)
{
return regs->r10 == -1 ? regs->r8:0;
}
static inline long syscall_get_return_value(struct task_struct *task,
struct pt_regs *regs)
{
return regs->r8;
}
static inline void syscall_set_return_value(struct task_struct *task,
struct pt_regs *regs,
int error, long val)
{
if (error) {
/* error < 0, but ia64 uses > 0 return value */
regs->r8 = -error;
regs->r10 = -1;
} else {
regs->r8 = val;
regs->r10 = 0;
}
}
Tested on v5.10 on rx3600 machine (ia64 9040 CPU).
Link: https://lkml.kernel.org/r/20210221002554.333076-2-slyfox@gentoo.org
Link: https://bugs.gentoo.org/769614
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Reported-by: Dmitry V. Levin <ldv@altlinux.org>
Reviewed-by: Dmitry V. Levin <ldv@altlinux.org>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 0ceb1ac
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 8.6 KB |
| Makefile | -rw-r--r-- | 1.3 KB |
| r8a7742-sysc.c | -rw-r--r-- | 1.4 KB |
| r8a7743-sysc.c | -rw-r--r-- | 807 bytes |
| r8a7745-sysc.c | -rw-r--r-- | 799 bytes |
| r8a77470-sysc.c | -rw-r--r-- | 818 bytes |
| r8a774a1-sysc.c | -rw-r--r-- | 1.6 KB |
| r8a774b1-sysc.c | -rw-r--r-- | 1.2 KB |
| r8a774c0-sysc.c | -rw-r--r-- | 1.6 KB |
| r8a774e1-sysc.c | -rw-r--r-- | 1.9 KB |
| r8a7779-sysc.c | -rw-r--r-- | 893 bytes |
| r8a7790-sysc.c | -rw-r--r-- | 1.5 KB |
| r8a7791-sysc.c | -rw-r--r-- | 868 bytes |
| r8a7792-sysc.c | -rw-r--r-- | 904 bytes |
| r8a7794-sysc.c | -rw-r--r-- | 856 bytes |
| r8a7795-sysc.c | -rw-r--r-- | 2.9 KB |
| r8a7796-sysc.c | -rw-r--r-- | 2.1 KB |
| r8a77965-sysc.c | -rw-r--r-- | 1.3 KB |
| r8a77970-sysc.c | -rw-r--r-- | 1.2 KB |
| r8a77980-sysc.c | -rw-r--r-- | 2.2 KB |
| r8a77990-sysc.c | -rw-r--r-- | 1.6 KB |
| r8a77995-sysc.c | -rw-r--r-- | 666 bytes |
| r8a779a0-sysc.c | -rw-r--r-- | 12.3 KB |
| r9a06g032-smp.c | -rw-r--r-- | 2.4 KB |
| rcar-rst.c | -rw-r--r-- | 3.8 KB |
| rcar-sysc.c | -rw-r--r-- | 12.7 KB |
| rcar-sysc.h | -rw-r--r-- | 2.6 KB |
| renesas-soc.c | -rw-r--r-- | 10.4 KB |
| rmobile-sysc.c | -rw-r--r-- | 8.1 KB |
Computing file changes ...
