Revision 61bf318eac2c13356f7bd1c6a05421ef504ccc8a authored by Sergei Trofimovich on 13 March 2021, 05:08:27 UTC, committed by Linus Torvalds on 13 March 2021, 19:27:31 UTC
In https://bugs.gentoo.org/769614 Dmitry noticed that
`ptrace(PTRACE_GET_SYSCALL_INFO)` does not return error sign properly.
The bug is in mismatch between get/set errors:
static inline long syscall_get_error(struct task_struct *task,
struct pt_regs *regs)
{
return regs->r10 == -1 ? regs->r8:0;
}
static inline long syscall_get_return_value(struct task_struct *task,
struct pt_regs *regs)
{
return regs->r8;
}
static inline void syscall_set_return_value(struct task_struct *task,
struct pt_regs *regs,
int error, long val)
{
if (error) {
/* error < 0, but ia64 uses > 0 return value */
regs->r8 = -error;
regs->r10 = -1;
} else {
regs->r8 = val;
regs->r10 = 0;
}
}
Tested on v5.10 on rx3600 machine (ia64 9040 CPU).
Link: https://lkml.kernel.org/r/20210221002554.333076-2-slyfox@gentoo.org
Link: https://bugs.gentoo.org/769614
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Reported-by: Dmitry V. Levin <ldv@altlinux.org>
Reviewed-by: Dmitry V. Levin <ldv@altlinux.org>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 0ceb1ac
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 3.5 KB |
| Makefile | -rw-r--r-- | 931 bytes |
| b43_pci_bridge.c | -rw-r--r-- | 1.8 KB |
| bridge_pcmcia_80211.c | -rw-r--r-- | 2.8 KB |
| driver_chipcommon.c | -rw-r--r-- | 17.7 KB |
| driver_chipcommon_pmu.c | -rw-r--r-- | 22.0 KB |
| driver_chipcommon_sflash.c | -rw-r--r-- | 4.1 KB |
| driver_extif.c | -rw-r--r-- | 5.0 KB |
| driver_gige.c | -rw-r--r-- | 7.3 KB |
| driver_gpio.c | -rw-r--r-- | 11.7 KB |
| driver_mipscore.c | -rw-r--r-- | 8.8 KB |
| driver_pcicore.c | -rw-r--r-- | 18.8 KB |
| embedded.c | -rw-r--r-- | 6.2 KB |
| host_soc.c | -rw-r--r-- | 4.5 KB |
| main.c | -rw-r--r-- | 30.4 KB |
| pci.c | -rw-r--r-- | 36.7 KB |
| pcihost_wrapper.c | -rw-r--r-- | 2.9 KB |
| pcmcia.c | -rw-r--r-- | 19.2 KB |
| scan.c | -rw-r--r-- | 10.2 KB |
| sdio.c | -rw-r--r-- | 15.6 KB |
| sprom.c | -rw-r--r-- | 5.2 KB |
| ssb_private.h | -rw-r--r-- | 7.0 KB |
Computing file changes ...
