Revision 61bf318eac2c13356f7bd1c6a05421ef504ccc8a authored by Sergei Trofimovich on 13 March 2021, 05:08:27 UTC, committed by Linus Torvalds on 13 March 2021, 19:27:31 UTC
In https://bugs.gentoo.org/769614 Dmitry noticed that `ptrace(PTRACE_GET_SYSCALL_INFO)` does not return error sign properly. The bug is in mismatch between get/set errors: static inline long syscall_get_error(struct task_struct *task, struct pt_regs *regs) { return regs->r10 == -1 ? regs->r8:0; } static inline long syscall_get_return_value(struct task_struct *task, struct pt_regs *regs) { return regs->r8; } static inline void syscall_set_return_value(struct task_struct *task, struct pt_regs *regs, int error, long val) { if (error) { /* error < 0, but ia64 uses > 0 return value */ regs->r8 = -error; regs->r10 = -1; } else { regs->r8 = val; regs->r10 = 0; } } Tested on v5.10 on rx3600 machine (ia64 9040 CPU). Link: https://lkml.kernel.org/r/20210221002554.333076-2-slyfox@gentoo.org Link: https://bugs.gentoo.org/769614 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> Reported-by: Dmitry V. Levin <ldv@altlinux.org> Reviewed-by: Dmitry V. Levin <ldv@altlinux.org> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 0ceb1ac
File | Mode | Size |
---|---|---|
events | ||
xen-pciback | ||
xenbus | ||
xenfs | ||
Kconfig | -rw-r--r-- | 11.0 KB |
Makefile | -rw-r--r-- | 1.8 KB |
acpi.c | -rw-r--r-- | 2.7 KB |
arm-device.c | -rw-r--r-- | 4.2 KB |
balloon.c | -rw-r--r-- | 18.0 KB |
biomerge.c | -rw-r--r-- | 617 bytes |
cpu_hotplug.c | -rw-r--r-- | 2.3 KB |
dbgp.c | -rw-r--r-- | 1.2 KB |
efi.c | -rw-r--r-- | 8.5 KB |
evtchn.c | -rw-r--r-- | 16.1 KB |
features.c | -rw-r--r-- | 803 bytes |
gntalloc.c | -rw-r--r-- | 15.3 KB |
gntdev-common.h | -rw-r--r-- | 2.2 KB |
gntdev-dmabuf.c | -rw-r--r-- | 20.3 KB |
gntdev-dmabuf.h | -rw-r--r-- | 943 bytes |
gntdev.c | -rw-r--r-- | 27.8 KB |
grant-table.c | -rw-r--r-- | 40.4 KB |
manage.c | -rw-r--r-- | 8.3 KB |
mcelog.c | -rw-r--r-- | 10.2 KB |
mem-reservation.c | -rw-r--r-- | 3.2 KB |
pci.c | -rw-r--r-- | 5.6 KB |
pcpu.c | -rw-r--r-- | 9.2 KB |
platform-pci.c | -rw-r--r-- | 4.1 KB |
privcmd-buf.c | -rw-r--r-- | 4.1 KB |
privcmd.c | -rw-r--r-- | 22.4 KB |
privcmd.h | -rw-r--r-- | 180 bytes |
pvcalls-back.c | -rw-r--r-- | 29.8 KB |
pvcalls-front.c | -rw-r--r-- | 31.9 KB |
pvcalls-front.h | -rw-r--r-- | 826 bytes |
swiotlb-xen.c | -rw-r--r-- | 16.3 KB |
sys-hypervisor.c | -rw-r--r-- | 12.5 KB |
time.c | -rw-r--r-- | 4.1 KB |
unpopulated-alloc.c | -rw-r--r-- | 4.3 KB |
xen-acpi-cpuhotplug.c | -rw-r--r-- | 10.2 KB |
xen-acpi-memhotplug.c | -rw-r--r-- | 11.3 KB |
xen-acpi-pad.c | -rw-r--r-- | 3.7 KB |
xen-acpi-processor.c | -rw-r--r-- | 17.0 KB |
xen-balloon.c | -rw-r--r-- | 7.3 KB |
xen-front-pgdir-shbuf.c | -rw-r--r-- | 14.5 KB |
xen-scsiback.c | -rw-r--r-- | 46.6 KB |
xen-stub.c | -rw-r--r-- | 2.3 KB |
xlate_mmu.c | -rw-r--r-- | 7.8 KB |
Computing file changes ...