Revision 61bf318eac2c13356f7bd1c6a05421ef504ccc8a authored by Sergei Trofimovich on 13 March 2021, 05:08:27 UTC, committed by Linus Torvalds on 13 March 2021, 19:27:31 UTC
In https://bugs.gentoo.org/769614 Dmitry noticed that `ptrace(PTRACE_GET_SYSCALL_INFO)` does not return error sign properly. The bug is in mismatch between get/set errors: static inline long syscall_get_error(struct task_struct *task, struct pt_regs *regs) { return regs->r10 == -1 ? regs->r8:0; } static inline long syscall_get_return_value(struct task_struct *task, struct pt_regs *regs) { return regs->r8; } static inline void syscall_set_return_value(struct task_struct *task, struct pt_regs *regs, int error, long val) { if (error) { /* error < 0, but ia64 uses > 0 return value */ regs->r8 = -error; regs->r10 = -1; } else { regs->r8 = val; regs->r10 = 0; } } Tested on v5.10 on rx3600 machine (ia64 9040 CPU). Link: https://lkml.kernel.org/r/20210221002554.333076-2-slyfox@gentoo.org Link: https://bugs.gentoo.org/769614 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> Reported-by: Dmitry V. Levin <ldv@altlinux.org> Reviewed-by: Dmitry V. Levin <ldv@altlinux.org> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 0ceb1ac
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.0 KB |
Makefile | -rw-r--r-- | 385 bytes |
cache.c | -rw-r--r-- | 3.0 KB |
cnode.c | -rw-r--r-- | 4.8 KB |
coda_cache.h | -rw-r--r-- | 712 bytes |
coda_fs_i.h | -rw-r--r-- | 1.9 KB |
coda_int.h | -rw-r--r-- | 611 bytes |
coda_linux.c | -rw-r--r-- | 5.4 KB |
coda_linux.h | -rw-r--r-- | 2.6 KB |
coda_psdev.h | -rw-r--r-- | 3.3 KB |
dir.c | -rw-r--r-- | 14.4 KB |
file.c | -rw-r--r-- | 7.9 KB |
inode.c | -rw-r--r-- | 7.3 KB |
pioctl.c | -rw-r--r-- | 2.2 KB |
psdev.c | -rw-r--r-- | 10.2 KB |
symlink.c | -rw-r--r-- | 1.1 KB |
sysctl.c | -rw-r--r-- | 1.2 KB |
upcall.c | -rw-r--r-- | 24.3 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...