Revision 61bf318eac2c13356f7bd1c6a05421ef504ccc8a authored by Sergei Trofimovich on 13 March 2021, 05:08:27 UTC, committed by Linus Torvalds on 13 March 2021, 19:27:31 UTC
In https://bugs.gentoo.org/769614 Dmitry noticed that `ptrace(PTRACE_GET_SYSCALL_INFO)` does not return error sign properly. The bug is in mismatch between get/set errors: static inline long syscall_get_error(struct task_struct *task, struct pt_regs *regs) { return regs->r10 == -1 ? regs->r8:0; } static inline long syscall_get_return_value(struct task_struct *task, struct pt_regs *regs) { return regs->r8; } static inline void syscall_set_return_value(struct task_struct *task, struct pt_regs *regs, int error, long val) { if (error) { /* error < 0, but ia64 uses > 0 return value */ regs->r8 = -error; regs->r10 = -1; } else { regs->r8 = val; regs->r10 = 0; } } Tested on v5.10 on rx3600 machine (ia64 9040 CPU). Link: https://lkml.kernel.org/r/20210221002554.333076-2-slyfox@gentoo.org Link: https://bugs.gentoo.org/769614 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> Reported-by: Dmitry V. Levin <ldv@altlinux.org> Reviewed-by: Dmitry V. Levin <ldv@altlinux.org> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 0ceb1ac
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 4.1 KB |
Makefile | -rw-r--r-- | 913 bytes |
array.c | -rw-r--r-- | 22.0 KB |
base.c | -rw-r--r-- | 91.4 KB |
bootconfig.c | -rw-r--r-- | 1.9 KB |
cmdline.c | -rw-r--r-- | 415 bytes |
consoles.c | -rw-r--r-- | 1.9 KB |
cpuinfo.c | -rw-r--r-- | 740 bytes |
devices.c | -rw-r--r-- | 1.2 KB |
fd.c | -rw-r--r-- | 7.5 KB |
fd.h | -rw-r--r-- | 583 bytes |
generic.c | -rw-r--r-- | 19.0 KB |
inode.c | -rw-r--r-- | 17.3 KB |
internal.h | -rw-r--r-- | 9.1 KB |
interrupts.c | -rw-r--r-- | 841 bytes |
kcore.c | -rw-r--r-- | 15.6 KB |
kmsg.c | -rw-r--r-- | 1.5 KB |
loadavg.c | -rw-r--r-- | 880 bytes |
meminfo.c | -rw-r--r-- | 5.2 KB |
namespaces.c | -rw-r--r-- | 4.2 KB |
nommu.c | -rw-r--r-- | 2.6 KB |
page.c | -rw-r--r-- | 7.9 KB |
proc_net.c | -rw-r--r-- | 9.7 KB |
proc_sysctl.c | -rw-r--r-- | 45.6 KB |
proc_tty.c | -rw-r--r-- | 4.5 KB |
root.c | -rw-r--r-- | 8.7 KB |
self.c | -rw-r--r-- | 1.7 KB |
softirqs.c | -rw-r--r-- | 741 bytes |
stat.c | -rw-r--r-- | 6.2 KB |
task_mmu.c | -rw-r--r-- | 47.1 KB |
task_nommu.c | -rw-r--r-- | 6.6 KB |
thread_self.c | -rw-r--r-- | 1.9 KB |
uptime.c | -rw-r--r-- | 988 bytes |
util.c | -rw-r--r-- | 383 bytes |
version.c | -rw-r--r-- | 515 bytes |
vmcore.c | -rw-r--r-- | 40.1 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...