Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
Revision 635227b881adff3533bf0d81fcd52dec65c14357 authored by Doug Parker on 01 February 2024, 00:29:52 UTC, committed by Alex Rickabaugh on 16 March 2024, 01:11:34 UTC 
refactor(zone.js): package `Zone` `*.d.ts` files (#53443)
 
This was a bit complicated, but the typings test (`packages/zone.js/test/typings/...`) was failing due to an unresolved import on `./zone-impl`.

The main cause is that `//packages/zone.js:zone_js_d_ts` was generating the output `zone.d.ts` file by _concatenating_ `zone.d.ts` with `zone.api.extensions.d.ts` and `zone.configurations.api.d.ts`. Now that `zone.d.ts` imports `zone-impl.d.ts`, concatenation is no longer a viable means of bundling this content.

To fix this, I created a new `packages/zone.js/zone.ts` entry point and imported the underlying `zone.ts` file as well as the two extensions. I added `extract_types` to pull the `*.d.ts` files out of the target (because all the JS is bundled separately) and used those files in the final NPM package. This is sufficient to pass the typings test and should be equivalent to what exists today.

PR Close #53443
1 parent 1081c51
History
Tip revision: 635227b881adff3533bf0d81fcd52dec65c14357 authored by Doug Parker on 01 February 2024, 00:29:52 UTC
refactor(zone.js): package `Zone` `*.d.ts` files (#53443)
Tip revision: 635227b
File Mode Size
.circleci
.devcontainer
.github
.husky
.ng-dev
.vscode
.yarn
adev
aio
devtools
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore -rw-r--r-- 1.6 KB
.bazelrc -rw-r--r-- 7.8 KB
.bazelversion -rw-r--r-- 6 bytes
.clang-format -rw-r--r-- 73 bytes
.editorconfig -rw-r--r-- 245 bytes
.gitattributes -rw-r--r-- 146 bytes
.gitignore -rw-r--r-- 1004 bytes
.gitmessage -rw-r--r-- 7.2 KB
.mailmap -rw-r--r-- 51 bytes
.npmrc -rw-r--r-- 21 bytes
.nvmrc -rw-r--r-- 8 bytes
.prettierrc -rw-r--r-- 196 bytes
.pullapprove.yml -rw-r--r-- 51.8 KB
.yarnrc -rw-r--r-- 130 bytes
BUILD.bazel -rw-r--r-- 2.5 KB
CHANGELOG.md -rw-r--r-- 287.4 KB
CHANGELOG_ARCHIVE.md -rw-r--r-- 997.0 KB
CODE_OF_CONDUCT.md -rw-r--r-- 3.6 KB
CONTRIBUTING.md -rw-r--r-- 15.7 KB
LICENSE -rw-r--r-- 1.1 KB
README.md -rw-r--r-- 5.5 KB
SECURITY.md -rw-r--r-- 403 bytes
WORKSPACE -rw-r--r-- 10.1 KB
browser-providers.conf.d.ts -rw-r--r-- 387 bytes
browser-providers.conf.js -rw-r--r-- 1.9 KB
gulpfile.js -rw-r--r-- 572 bytes
karma-js.conf.js -rw-r--r-- 6.0 KB
package.json -rw-r--r-- 9.9 KB
packages.bzl -rw-r--r-- 3.8 KB
renovate.json -rw-r--r-- 3.0 KB
tsconfig-tslint.json -rw-r--r-- 171 bytes
tslint.json -rw-r--r-- 5.3 KB
yarn.bzl -rw-r--r-- 77 bytes
yarn.lock -rw-r--r-- 812.6 KB
yarn.lock.readme.md -rw-r--r-- 1.3 KB

README.md

back to top