sort by:
Revision Author Date Message Commit Date
63c18a1 [feat] FSDP support for MMF 29 September 2021, 18:58:24 UTC
68d52ed fsdp 17 September 2021, 01:53:31 UTC
fe63eb0 [docs] Add loss tutorial doc (#1087) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1087 Test Plan: Imported from GitHub, without a `Test Plan:` line. **Static Docs Preview: mmf** |[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D30876325/V4/mmf/)| |**Modified Pages**| |[docs/tutorials/losses](https://our.intern.facebook.com/intern/staticdocs/eph/D30876325/V4/mmf/docs/tutorials/losses/)| Reviewed By: apsdehal Differential Revision: D30876325 Pulled By: Ryan-Qiyu-Jiang fbshipit-source-id: d0d2ab47a2149a3585d080c601066c7375a77024 15 September 2021, 14:23:33 UTC
357ee45 [docs] Add metrics tutorial doc (#1083) Summary: Add a tutorial doc for custom metrics. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1083 Test Plan: Imported from GitHub, without a `Test Plan:` line. **Static Docs Preview: mmf** |[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D30851769/V4/mmf/)| |**Modified Pages**| |[docs/tutorials/metrics](https://our.intern.facebook.com/intern/staticdocs/eph/D30851769/V4/mmf/docs/tutorials/metrics/)| Reviewed By: apsdehal Differential Revision: D30851769 Pulled By: Ryan-Qiyu-Jiang fbshipit-source-id: deb1c2811ff3e8e9a5668e7b0586c478e9c5aa39 15 September 2021, 14:20:11 UTC
610c142 [feat] Add loss support for dict return type (#1086) Summary: Add loss support for classes that return a dict of losses. All loss dictionaries are flattened in the final losses dict. Added bce_kl, mse_mae loss classes as examples and for unit testing. This new loss class returns a dict, containing the bce and kl div tensors as values with string keys. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1086 Reviewed By: apsdehal Differential Revision: D30872944 Pulled By: Ryan-Qiyu-Jiang fbshipit-source-id: 4116ff92bcb24439a20d4720c3813d3c3db6ced0 15 September 2021, 14:12:49 UTC
ce870b1 [feat] Add metric support for dict return type (#1075) Summary: Add metric support for classes that return a dict of metrics. All metric dictionaries are flattened in the final metrics dict. Add example f1_precision_recall metric class as an example, and for unit testing. This new metric class returns a dict, containing the f1, precision, and recall tensors as values with string keys. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1075 Reviewed By: apsdehal Differential Revision: D30778427 Pulled By: Ryan-Qiyu-Jiang fbshipit-source-id: a7443eab8a0e9a2ee5d361883d84dc8880312fbf 13 September 2021, 13:30:50 UTC
7fa7607 [feat] Weights and Biases Logging Feature (#1060) Summary: Add a WandbLogger class to support wandb logging. Update config options to enable wandb logger and integrate with the trainer. To enable wandb logging use the following options `training.wandb=True env.wandb_projectname=<ProjectName> env.wandb_runname=<RunName>` **Examples:** Screenshot of the wandb dashboard for two runs of m4c project on textvqa dataset. ![image](https://user-images.githubusercontent.com/42584330/131163071-50eb1405-aebb-4b61-982c-71000c29466f.png) 1. command line code for _run1_: `mmf_run config=projects/m4c/configs/textvqa/defaults.yaml datasets=textvqa model=m4c run_type=train_val training.batch_size=2 training.log_interval=2 training.wandb=True training.max_updates=10 env.wandb_projectname=Try1 env.wandb_runname=run1 ` 2. command line code for _run2_: `mmf_run config=projects/m4c/configs/textvqa/defaults.yaml datasets=textvqa model=m4c run_type=train_val training.batch_size=2 training.log_interval=1 training.wandb=True training.max_updates=10 env.wandb_projectname=Try1 env.wandb_runname=run2 ` Linked Issue: Wandb Logger in mmf https://github.com/facebookresearch/mmf/issues/588 Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1060 Test Plan: Imported from GitHub, without a `Test Plan:` line. |[Site Preview: mmf](https://our.intern.facebook.com/intern/staticdocs/eph/D30690086/V3/mmf/) Reviewed By: apsdehal Differential Revision: D30690086 Pulled By: vedanuj fbshipit-source-id: 684d0091b696747ed9535f4e4204e10dacdbf72b 09 September 2021, 22:58:13 UTC
15fa630 [refactor][PL][9/N] change the name of the _load_checkpoint to be more descriptive to contain test (#1030) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1030 Test Plan: Imported from OSS Reviewed By: simran2905 Differential Revision: D29888294 Pulled By: ytsheng fbshipit-source-id: 54919dc4e8448a1240b2cc72a364702aa7cf49c2 09 September 2021, 02:59:18 UTC
be5b032 [feat][PL][8/N] save config with checkpoint (#1024) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1024 Test Plan: Imported from OSS Reviewed By: apsdehal Differential Revision: D29670421 Pulled By: ytsheng fbshipit-source-id: ee97bd6b45f1ab8099403896e73f2d0c3a98ca96 09 September 2021, 02:49:07 UTC
e903a45 [feat][PL][7/N] trainer checkpoint from mmf to lightning update (#1023) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1023 Test Plan: Imported from OSS Reviewed By: apsdehal Differential Revision: D29670422 Pulled By: ytsheng fbshipit-source-id: 3d6387999634b19abd4b7895b6648f299f860772 09 September 2021, 02:25:22 UTC
5bb56b2 [feat][PL][6/N] pretrained state mapping for PL (#1022) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1022 Test Plan: Imported from OSS Reviewed By: apsdehal Differential Revision: D29670417 Pulled By: ytsheng fbshipit-source-id: f135cb85df212d6f86916a30fff9d90f20714844 09 September 2021, 02:11:28 UTC
c1d7495 [fix,feat] Support other pathmanager prefixes for config (#1079) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1079 This will allow us to support configs present in manifold. Reviewed By: BruceChaun Differential Revision: D30798178 fbshipit-source-id: 9a22e0184db37ba3a8190527df042a6cc1007066 09 September 2021, 00:59:03 UTC
f5f1ef0 [fix] Make demjson dep optional (#1080) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1080 Allows fixing issues with CI due to demjson. Reviewed By: ytsheng Differential Revision: D30813103 fbshipit-source-id: 3bfd113fd3a0b0438648305919f4fcf7e6497ea9 08 September 2021, 20:47:40 UTC
75ea3ab [fix] Add zoo requirements to coco masked config (#1072) Summary: Add same zoo_requirements as coco dataset to masked_coco. Prevents file not found error while loading datasets. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1072 Reviewed By: apsdehal Differential Revision: D30727857 Pulled By: Ryan-Qiyu-Jiang fbshipit-source-id: b96b26063156d2bb463fa6d19e254a9f703f9242 02 September 2021, 19:31:59 UTC
fd74eca [docs] Changed the installation link which was broken in README.md (#1056) Summary: Update the broken link for installation in README.md from https://mmf.sh/docs/getting_started/installation to https://mmf.sh/docs/. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1056 Reviewed By: vedanuj Differential Revision: D30568779 Pulled By: apsdehal fbshipit-source-id: 2f66de70a8c2745932747415f8926279402992ea 02 September 2021, 05:30:48 UTC
6ad3335 Bump tar from 6.1.5 to 6.1.11 in /website (#1070) Summary: Bumps [tar](https://github.com/npm/node-tar) from 6.1.5 to 6.1.11. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/node-tar/commit/e573aeea19d4d650908b7f6bf0a1ad8dce9f1736"><code>e573aee</code></a> 6.1.11</li> <li><a href="https://github.com/npm/node-tar/commit/edb8e9a3fa5869cfb935479a262f6f61b0a2ec57"><code>edb8e9a</code></a> fix: perf regression on hot string munging path</li> <li><a href="https://github.com/npm/node-tar/commit/a9d9b05fc974425089922bf66e8e7751ea8bfbbc"><code>a9d9b05</code></a> chore(test): Avoid spurious failures packing node_modules/.cache</li> <li><a href="https://github.com/npm/node-tar/commit/24b8bdadf37118182496ecf81fa7a872196fb38b"><code>24b8bda</code></a> fix(test): use posix path for testing path reservations</li> <li><a href="https://github.com/npm/node-tar/commit/e5a223c6b293f1cb2ebb2dd97668f787e8983ca4"><code>e5a223c</code></a> fix(test): make unpack test pass on case-sensitive fs</li> <li><a href="https://github.com/npm/node-tar/commit/188baddc1d0e6ef5140c7a788f03fc2a6c3df2ea"><code>188badd</code></a> 6.1.10</li> <li><a href="https://github.com/npm/node-tar/commit/23312ce7db8a12c78d0fba96d7664a01619266a3"><code>23312ce</code></a> drop dirCache for symlink on all platforms</li> <li><a href="https://github.com/npm/node-tar/commit/4f1f4a21fca64f3089da0e83ceea775c66b55052"><code>4f1f4a2</code></a> 6.1.9</li> <li><a href="https://github.com/npm/node-tar/commit/875a37e3ec031186fc6599f6807341f56c584598"><code>875a37e</code></a> fix: prevent path escape using drive-relative paths</li> <li><a href="https://github.com/npm/node-tar/commit/b6162c7fafe797f856564ef37f4b82747f051455"><code>b6162c7</code></a> fix: reserve paths properly for unicode, windows</li> <li>Additional commits viewable in <a href="https://github.com/npm/node-tar/compare/v6.1.5...v6.1.11">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tar&package-manager=npm_and_yarn&previous-version=6.1.5&new-version=6.1.11)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1070 Test Plan: Imported from GitHub, without a `Test Plan:` line. |[Site Preview: mmf](https://our.intern.facebook.com/intern/staticdocs/eph/D30690090/V2/mmf/) Reviewed By: apsdehal Differential Revision: D30690090 Pulled By: vedanuj fbshipit-source-id: 176e05fb9a99fa782b402ec7203f8d61b0e0787b 02 September 2021, 05:30:48 UTC
bbfd9bc [fix] Fix typo in script feature extraction (#945) Summary: `files` datatype should be set, so the function to remove an obj is `remove`, not `pop`. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/945 Reviewed By: vedanuj Differential Revision: D28703139 Pulled By: apsdehal fbshipit-source-id: c43035334258b3d61e1844b08a3c30a56d93dcfd 02 September 2021, 05:30:48 UTC
4658d90 [fix,refactor] Allow proper teardown for SummaryWriter (#1074) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1074 This diff does following things: - Refactors TensorboardLogger to be more clean and support cleanup method - Adds a teardown hook support for callbacks - Cleans up the trainer a little to have single teardown call. Reviewed By: vedanuj Differential Revision: D30680073 fbshipit-source-id: f300cdae02f9f9f2cff4524797440bb8c1a1e4ce 02 September 2021, 01:31:23 UTC
453c39e [fix] Only return cuda as current device if cuda is actually initialized (#942) Summary: This causes issues when GPU is available but person still want to run on CPU. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/942 Test Plan: Tested locally Reviewed By: vedanuj Differential Revision: D28917011 Pulled By: apsdehal fbshipit-source-id: e1cb1829140f152d589eaa1d613ec05f59269f7c 01 September 2021, 22:28:15 UTC
b4e2098 [feat] merge no_token_embedding_backend to main mmf (#188) Summary: Pull Request resolved: https://github.com/fairinternal/mmf-internal/pull/188 Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1071 We can upstream the pytext_backend_without_token_embeddings to main mmf to avoid duplicate code. Reviewed By: apsdehal Differential Revision: D30673593 fbshipit-source-id: f0b4b852049e1258cd7a0de29dc28bf626edc7a2 01 September 2021, 21:31:04 UTC
592289f [fix] Fix OmegaConf depreciation warning around register_resolver (#1069) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1069 The diff aims to fix the depreciation warning around register_resolver function by replacing it with the register_new_resolver. Reviewed By: vedanuj, apsdehal Differential Revision: D30671569 fbshipit-source-id: 743a51d936fda7060c1a257222a762676935be63 01 September 2021, 04:28:03 UTC
0d24224 [feat] ALBEF Vision Transformer Encoder (#1063) Summary: PR adds ALBEF's Vision Transformer to MMF. - Adds Vision Transformer model - Adds Vision Transformer encoder - Adds tests for Vision Transformer encoder Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1063 Reviewed By: ronghanghu Differential Revision: D30646130 Pulled By: apsdehal fbshipit-source-id: 3daf5b9f8232203aa6d544e8975f6fa7e964dbaf 31 August 2021, 02:45:06 UTC
baa1f70 Bump url-parse from 1.5.1 to 1.5.3 in /website (#1046) Summary: Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/unshiftio/url-parse/commit/ad444931666a30bad11472d89a216461cf16cae2"><code>ad44493</code></a> [dist] 1.5.3</li> <li><a href="https://github.com/unshiftio/url-parse/commit/c7984617e235892cc22e0f47bb5ff1c012e6e39f"><code>c798461</code></a> [fix] Fix host parsing for file URLs (<a href="https://github-redirect.dependabot.com/unshiftio/url-parse/issues/210">https://github.com/facebookresearch/mmf/issues/210</a>)</li> <li><a href="https://github.com/unshiftio/url-parse/commit/201034b8670c2aa382d7ec410ee750ac6f2f9c38"><code>201034b</code></a> [dist] 1.5.2</li> <li><a href="https://github.com/unshiftio/url-parse/commit/2d9ac2c94067742b2116332c1e03be9f37371dff"><code>2d9ac2c</code></a> [fix] Sanitize only special URLs (<a href="https://github-redirect.dependabot.com/unshiftio/url-parse/issues/209">https://github.com/facebookresearch/mmf/issues/209</a>)</li> <li><a href="https://github.com/unshiftio/url-parse/commit/fb128af4f43fa17f351d50cf615c7598c751f50a"><code>fb128af</code></a> [fix] Use <code>'null'</code> as <code>origin</code> for non special URLs</li> <li><a href="https://github.com/unshiftio/url-parse/commit/fed6d9e338ea39de2d68bb66607066d71328c62f"><code>fed6d9e</code></a> [fix] Add a leading slash only if the URL is special</li> <li><a href="https://github.com/unshiftio/url-parse/commit/94872e7ab9103ee69b958959baa14c9e682a7f10"><code>94872e7</code></a> [fix] Do not incorrectly set the <code>slashes</code> property to <code>true</code></li> <li><a href="https://github.com/unshiftio/url-parse/commit/81ab967889b08112d3356e451bf03e6aa0cbb7e0"><code>81ab967</code></a> [fix] Ignore slashes after the protocol for special URLs</li> <li><a href="https://github.com/unshiftio/url-parse/commit/ee22050a48a67409aa5f7c87947284156d615bd1"><code>ee22050</code></a> [ci] Use GitHub Actions</li> <li><a href="https://github.com/unshiftio/url-parse/commit/d2979b586d8c7751e0c77f127d9ce1b2143cc0c9"><code>d2979b5</code></a> [fix] Special case the <code>file:</code> protocol (<a href="https://github-redirect.dependabot.com/unshiftio/url-parse/issues/204">https://github.com/facebookresearch/mmf/issues/204</a>)</li> <li>Additional commits viewable in <a href="https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=url-parse&package-manager=npm_and_yarn&previous-version=1.5.1&new-version=1.5.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1046 Test Plan: Imported from GitHub, without a `Test Plan:` line. |[Site Preview: mmf](https://our.intern.facebook.com/intern/staticdocs/eph/D30392262/V3/mmf/) Reviewed By: apsdehal Differential Revision: D30392262 Pulled By: vedanuj fbshipit-source-id: 5741d20e13b5269d60d214d56207c3f59c31c270 28 August 2021, 01:20:55 UTC
d772fd1 Bump tar from 6.1.0 to 6.1.5 in /website (#1039) Summary: Bumps [tar](https://github.com/npm/node-tar) from 6.1.0 to 6.1.5. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/node-tar/commit/bd4691c90478f41b2649a97048199e34927dc046"><code>bd4691c</code></a> 6.1.5</li> <li><a href="https://github.com/npm/node-tar/commit/d694c4f810d864badf223efa35d24a000d780179"><code>d694c4f</code></a> ci: test on node 16</li> <li><a href="https://github.com/npm/node-tar/commit/84acbd31288541100910a528e437f901f8012214"><code>84acbd3</code></a> fix(unpack): fix hang on large file on open() fail</li> <li><a href="https://github.com/npm/node-tar/commit/97c46fcee7e4e7849ea3432086c4537fb6197025"><code>97c46fc</code></a> fix(unpack): always resume parsing after an entry error</li> <li><a href="https://github.com/npm/node-tar/commit/488ab8c01de69379406d937419fa3e5550e651c0"><code>488ab8c</code></a> chore: WriteEntry cleaner write() handling</li> <li><a href="https://github.com/npm/node-tar/commit/be89aafd95296e9721e124b77eee7c745e1c1e97"><code>be89aaf</code></a> WriteEntry backpressure</li> <li><a href="https://github.com/npm/node-tar/commit/ba73f5eea55f9cf65048b4d9578462ec8f80bc5e"><code>ba73f5e</code></a> chore: track fs state on WriteEntry class, not in arguments</li> <li><a href="https://github.com/npm/node-tar/commit/bf693837b3dcfeb76878b212310302dc5dc3d3dc"><code>bf69383</code></a> 6.1.4</li> <li><a href="https://github.com/npm/node-tar/commit/06cbde5935aa7643f578f874de84a7da2a74fe3a"><code>06cbde5</code></a> Avoid an unlikely but theoretically possible redos</li> <li><a href="https://github.com/npm/node-tar/commit/0b78386c53b00dce422742e19de94f2a4d9389f3"><code>0b78386</code></a> 6.1.3</li> <li>Additional commits viewable in <a href="https://github.com/npm/node-tar/compare/v6.1.0...v6.1.5">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tar&package-manager=npm_and_yarn&previous-version=6.1.0&new-version=6.1.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1039 Test Plan: Imported from GitHub, without a `Test Plan:` line. |[Site Preview: mmf](https://our.intern.facebook.com/intern/staticdocs/eph/D30392234/V3/mmf/) Reviewed By: apsdehal Differential Revision: D30392234 Pulled By: vedanuj fbshipit-source-id: 47546c55a093dc3a6d228228fa32e3cebccb6548 27 August 2021, 21:40:02 UTC
1947bd4 Bump prismjs from 1.23.0 to 1.24.0 in /website (#989) Summary: Bumps [prismjs](https://github.com/PrismJS/prism) from 1.23.0 to 1.24.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/PrismJS/prism/releases">prismjs's releases</a>.</em></p> <blockquote> <h2>v1.24.0</h2> <p>Release 1.24.0</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/PrismJS/prism/blob/master/CHANGELOG.md">prismjs's changelog</a>.</em></p> <blockquote> <h2>1.24.0 (2021-06-27)</h2> <h3>New components</h3> <ul> <li><strong>CFScript</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2771">#2771</a>) <a href="https://github.com/PrismJS/prism/commit/b0a6ec85"><code>b0a6ec85</code></a></li> <li><strong>ChaiScript</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2706">#2706</a>) <a href="https://github.com/PrismJS/prism/commit/3f7d7453"><code>3f7d7453</code></a></li> <li><strong>COBOL</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2800">#2800</a>) <a href="https://github.com/PrismJS/prism/commit/7e5f78ff"><code>7e5f78ff</code></a></li> <li><strong>Coq</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2803">#2803</a>) <a href="https://github.com/PrismJS/prism/commit/41e25d3c"><code>41e25d3c</code></a></li> <li><strong>CSV</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2794">#2794</a>) <a href="https://github.com/PrismJS/prism/commit/f9b69528"><code>f9b69528</code></a></li> <li><strong>DOT (Graphviz)</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2690">#2690</a>) <a href="https://github.com/PrismJS/prism/commit/1f91868e"><code>1f91868e</code></a></li> <li><strong>False</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2802">#2802</a>) <a href="https://github.com/PrismJS/prism/commit/99a21dc5"><code>99a21dc5</code></a></li> <li><strong>ICU Message Format</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2745">#2745</a>) <a href="https://github.com/PrismJS/prism/commit/bf4e7ba9"><code>bf4e7ba9</code></a></li> <li><strong>Idris</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2755">#2755</a>) <a href="https://github.com/PrismJS/prism/commit/e9314415"><code>e9314415</code></a></li> <li><strong>Jexl</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2764">#2764</a>) <a href="https://github.com/PrismJS/prism/commit/7e51b99c"><code>7e51b99c</code></a></li> <li><strong>KuMir (КуМир)</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2760">#2760</a>) <a href="https://github.com/PrismJS/prism/commit/3419fb77"><code>3419fb77</code></a></li> <li><strong>Log file</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2796">#2796</a>) <a href="https://github.com/PrismJS/prism/commit/2bc6475b"><code>2bc6475b</code></a></li> <li><strong>Nevod</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2798">#2798</a>) <a href="https://github.com/PrismJS/prism/commit/f84c49c5"><code>f84c49c5</code></a></li> <li><strong>OpenQasm</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2797">#2797</a>) <a href="https://github.com/PrismJS/prism/commit/1a2347a3"><code>1a2347a3</code></a></li> <li><strong>PATROL Scripting Language</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2739">#2739</a>) <a href="https://github.com/PrismJS/prism/commit/18c67b49"><code>18c67b49</code></a></li> <li><strong>Q#</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2804">#2804</a>) <a href="https://github.com/PrismJS/prism/commit/1b63cd01"><code>1b63cd01</code></a></li> <li><strong>Rego</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2624">#2624</a>) <a href="https://github.com/PrismJS/prism/commit/e38986f9"><code>e38986f9</code></a></li> <li><strong>Squirrel</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2721">#2721</a>) <a href="https://github.com/PrismJS/prism/commit/fd1081d2"><code>fd1081d2</code></a></li> <li><strong>URI</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2708">#2708</a>) <a href="https://github.com/PrismJS/prism/commit/bbc77d19"><code>bbc77d19</code></a></li> <li><strong>V</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2687">#2687</a>) <a href="https://github.com/PrismJS/prism/commit/72962701"><code>72962701</code></a></li> <li><strong>Wolfram language</strong> &amp; <strong>Mathematica</strong> &amp; <strong>Mathematica Notebook</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2921">#2921</a>) <a href="https://github.com/PrismJS/prism/commit/c4f6b2cc"><code>c4f6b2cc</code></a></li> </ul> <h3>Updated components</h3> <ul> <li>Fixed problems reported by <code>regexp/no-dupe-disjunctions</code> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2952">#2952</a>) <a href="https://github.com/PrismJS/prism/commit/f471d2d7"><code>f471d2d7</code></a></li> <li>Fixed some cases of quadratic worst-case runtime (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2922">#2922</a>) <a href="https://github.com/PrismJS/prism/commit/79d22182"><code>79d22182</code></a></li> <li>Fixed 2 cases of exponential backtracking (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2774">#2774</a>) <a href="https://github.com/PrismJS/prism/commit/d85e30da"><code>d85e30da</code></a></li> <li><strong>AQL</strong> <ul> <li>Update for ArangoDB 3.8 (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2842">#2842</a>) <a href="https://github.com/PrismJS/prism/commit/ea82478d"><code>ea82478d</code></a></li> </ul> </li> <li><strong>AutoHotkey</strong> <ul> <li>Improved tag pattern (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2920">#2920</a>) <a href="https://github.com/PrismJS/prism/commit/fc2a3334"><code>fc2a3334</code></a></li> </ul> </li> <li><strong>Bash</strong> <ul> <li>Accept hyphens in function names (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2832">#2832</a>) <a href="https://github.com/PrismJS/prism/commit/e4ad22ad"><code>e4ad22ad</code></a></li> <li>Fixed single-quoted strings (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2792">#2792</a>) <a href="https://github.com/PrismJS/prism/commit/e5cfdb4a"><code>e5cfdb4a</code></a></li> </ul> </li> <li><strong>C++</strong> <ul> <li>Added support for generic functions and made <code>::</code> punctuation (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2814">#2814</a>) <a href="https://github.com/PrismJS/prism/commit/3df62fd0"><code>3df62fd0</code></a></li> <li>Added missing keywords and modules (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2763">#2763</a>) <a href="https://github.com/PrismJS/prism/commit/88fa72cf"><code>88fa72cf</code></a></li> </ul> </li> <li><strong>Dart</strong> <ul> <li>Improved support for classes &amp; generics (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2810">#2810</a>) <a href="https://github.com/PrismJS/prism/commit/d0bcd074"><code>d0bcd074</code></a></li> </ul> </li> <li><strong>Docker</strong> <ul> <li>Improvements (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2720">#2720</a>) <a href="https://github.com/PrismJS/prism/commit/93dd83c2"><code>93dd83c2</code></a></li> </ul> </li> <li><strong>Elixir</strong> <ul> <li>Added missing keywords (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2958">#2958</a>) <a href="https://github.com/PrismJS/prism/commit/114e4626"><code>114e4626</code></a></li> <li>Added missing keyword and other improvements (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2773">#2773</a>) <a href="https://github.com/PrismJS/prism/commit/e6c0d298"><code>e6c0d298</code></a></li> <li>Added <code>defdelagate</code> keyword and highlighting for function/module names (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2709">#2709</a>) <a href="https://github.com/PrismJS/prism/commit/59f725d7"><code>59f725d7</code></a></li> </ul> </li> <li><strong>F#</strong></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/PrismJS/prism/commit/3432b4b1e4440d6592ed82b6b5b9e72f660e43a8"><code>3432b4b</code></a> 1.24.0</li> <li><a href="https://github.com/PrismJS/prism/commit/46d07207687fa747018b6676250507a486c0117f"><code>46d0720</code></a> Updated <code>.npmignore</code> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2971">#2971</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/aef7f08df6d6fe1e027ee3ab347c2f391c0c1045"><code>aef7f08</code></a> Changelog for v1.24.0 (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2965">#2965</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/e9477d8369bc59cacc99d1d81abfe3e20b7df258"><code>e9477d8</code></a> Markdown: Improved code snippets (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2967">#2967</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/4b55bd6af88559d430fc195fbe5845364ade8df1"><code>4b55bd6</code></a> Made Match Braces and Custom Class compatible (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2947">#2947</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/e8d3b50330a325a8291f20d63f60e68a985ae738"><code>e8d3b50</code></a> ESLint: Added <code>regexp/strict</code> rule (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2944">#2944</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/bfd7fded29755510571e3abf0846f2a9edf44ef6"><code>bfd7fde</code></a> GraphQL: Fixed <code>definition-query</code> and <code>definition-mutation</code> tokens (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2964">#2964</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/14e3868f05f84d05885f5465264c5c72e6ca9490"><code>14e3868</code></a> Fixed reST test</li> <li><a href="https://github.com/PrismJS/prism/commit/a7656de67a07e6415fe0c7149708c8613ff73c12"><code>a7656de</code></a> reST: Fixed <code>inline</code> pattern (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2946">#2946</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/b4ac0618156a13ab04ff685c5091cb436e8a13a4"><code>b4ac061</code></a> ESLint: Use cache (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2959">#2959</a>)</li> <li>Additional commits viewable in <a href="https://github.com/PrismJS/prism/compare/v1.23.0...v1.24.0">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~rundevelopment">rundevelopment</a>, a new releaser for prismjs since your current version.</p> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=prismjs&package-manager=npm_and_yarn&previous-version=1.23.0&new-version=1.24.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/989 Test Plan: Imported from GitHub, without a `Test Plan:` line. |[Site Preview: mmf](https://our.intern.facebook.com/intern/staticdocs/eph/D29494387/V3/mmf/) Reviewed By: apsdehal Differential Revision: D29494387 Pulled By: vedanuj fbshipit-source-id: d717296fbab2c085c531084dbd2f54ca06c3e197 27 August 2021, 21:28:50 UTC
e019df6 Bump color-string from 1.5.3 to 1.5.5 in /website (#984) Summary: Bumps [color-string](https://github.com/Qix-/color-string) from 1.5.3 to 1.5.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Qix-/color-string/releases">color-string's releases</a>.</em></p> <blockquote> <h2>1.5.5 (Patch/Security Release) - hwb() ReDos patch (low-severity)</h2> <blockquote> <p>Release notes copied verbatim from the commit message, which can be found here: 0789e21284c33d89ebc4ab4ca6f759b9375ac9d3</p> </blockquote> <pre><code>Discovered by Yeting Li, c/o Colin Ife via Snyk.io. <p>A ReDos (Regular Expression Denial of Service) vulnerability was responsibly disclosed to me via email by Colin on Mar 5 2021 regarding an exponential time complexity for linearly increasing input lengths for <code>hwb()</code> color strings.</p> <p>Strings reaching more than 5000 characters would see several milliseconds of processing time; strings reaching more than 50,000 characters began seeing 1500ms (1.5s) of processing time.</p> <p>The cause was due to a the regular expression that parses hwb() strings - specifically, the hue value - where the integer portion of the hue value used a 0-or-more quantifier shortly thereafter followed by a 1-or-more quantifier.</p> <p>This caused excessive backtracking and a cartesian scan, resulting in exponential time complexity given a linear increase in input length.</p> <p>Thank you Yeting Li and Colin Ife for bringing this to my attention in a secure, responsible and professional manner.</p> <p>A CVE will not be assigned for this vulnerability. </code></pre></p> <h2>1.5.4 (Patch Release)</h2> <ul> <li>Removes rounding of alpha values in RGBA hex (<code>#rrggbbaa</code>) and condensed-hex (<code>#rgba</code>) parsers, which caused certain unique inputs to result in identical outputs (see <a href="https://github.com/qix-/color/issues/174">https://github.com/qix-/color/issues/174</a>).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/Qix-/color-string/commits/1.5.5">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=color-string&package-manager=npm_and_yarn&previous-version=1.5.3&new-version=1.5.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/984 Test Plan: Imported from GitHub, without a `Test Plan:` line. |[Site Preview: mmf](https://our.intern.facebook.com/intern/staticdocs/eph/D29494369/V3/mmf/) Reviewed By: apsdehal Differential Revision: D29494369 Pulled By: vedanuj fbshipit-source-id: fb0c3d676bca6f29b542d072094f4e835c60e922 27 August 2021, 21:22:39 UTC
1ca5979 Bump path-parse from 1.0.6 to 1.0.7 in /website (#1045) Summary: Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/jbgutierrez/path-parse/commits/v1.0.7">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=path-parse&package-manager=npm_and_yarn&previous-version=1.0.6&new-version=1.0.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1045 Test Plan: Imported from GitHub, without a `Test Plan:` line. |[Site Preview: mmf](https://our.intern.facebook.com/intern/staticdocs/eph/D30392250/V3/mmf/) Reviewed By: apsdehal Differential Revision: D30392250 Pulled By: vedanuj fbshipit-source-id: 6fc81e34b6806a3929f9f29bcc526515bfcf8264 27 August 2021, 21:19:19 UTC
87df959 [feat][PL][5/N] load model checkpoint directly + model zoo (#1021) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1021 So for each of the diffs, the test should make it clear what it does. But here is the overview. This diff does the following two: - the lightning trainer to read directly from an mmf zoo checkpoint. - added the test for loading the mmf zoo checkpoint using the lightning trainer Notes: lightning models use the provided API load_from_checkpoint api. Test Plan: Imported from OSS Reviewed By: apsdehal Differential Revision: D29670423 Pulled By: ytsheng fbshipit-source-id: 8a07e875abaff9db7cd17b85f80cb15cb9fad6fe 26 August 2021, 23:10:48 UTC
c191cd4 [feat][PL][4/N] best ckpt (#1020) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1020 Add the summary as a comment since every time I export the PR from github it overrides the summary. This PR does the following things: - Adds the code to do best checkpoint monitoring. The monitor callback is an instance of the ModelCheckpoint callback, same as the trainingCallback. - Adds the test for the best checkpoint monitoring; Adjust the test to make it the cleanest for handle best checkpoint monitoring. Test Plan: Imported from OSS Reviewed By: apsdehal Differential Revision: D29670420 Pulled By: ytsheng fbshipit-source-id: 4a72196869c205bfe4cc5e4a6bfda21d74934065 26 August 2021, 22:54:19 UTC
e4ef8e9 [feat] allow extra commandline args in sweep scripts (#1057) Summary: This PR adds `--extra_args` in sweep lib to allow passing additional MMF command-line arguments, like `mmf_run` and `mmf_predict`. Usage: one can append to the sweep script extra command line arguments such as ``` python tools/sweeps/sweep_visual_bert.py \ <gpu, node, or other arguments> \ --extra_args training.checkpoint_interval 10000 training.batch_size 128 ``` Note that it also support the other format with equal sign `=` in args such as `--extra_args training.batch_size=128` Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1057 Test Plan: tested on FAIR cluster Reviewed By: apsdehal Differential Revision: D30568684 Pulled By: ronghanghu fbshipit-source-id: 88f85be01b4aa3aa32d616ae72e4b84ce4e51aa5 26 August 2021, 17:17:31 UTC
92c167d [fix] add `weight_decay` parameter to `get_bert_configured_parameters` (#1034) Summary: Allow specifiying custom weight decay in `get_bert_configured_parameters`. The behavior of existing codebase is kept the same for backward compatibility. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1034 Test Plan: tested in custom projects Reviewed By: apsdehal Differential Revision: D30459987 Pulled By: ronghanghu fbshipit-source-id: 9bca0775e3dfc095716e0aa53dc1b691f3b33730 20 August 2021, 23:59:48 UTC
8c4189b [fix][PL][3/N] minor change in base model (#1019) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1019 Two things: 1. make sure to not `should_update_loss` when updating the meter from the report. This is also the current behavior in `evaluation_loop` with mmf trainer. 2. Remove some functions in test, since they should just be using the parent class's functions. Test Plan: Imported from OSS Reviewed By: simran2905 Differential Revision: D29670419 Pulled By: ytsheng fbshipit-source-id: 52cc155907d25ade1be1f6d675f7cdb6ea6ff658 18 August 2021, 01:37:47 UTC
b4211e2 [feat][PL][2/N] PL train checkpoint (#1018) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1018 Test Plan: Imported from OSS Reviewed By: apsdehal Differential Revision: D29670418 Pulled By: ytsheng fbshipit-source-id: 54626b9367d42c1e6d0148a0afacbcf3d9248495 18 August 2021, 01:37:47 UTC
90b39ab Fix typo in BaseAlign's config Summary: Fix typo in BaseAlign's config Reviewed By: BruceChaun Differential Revision: D30378765 fbshipit-source-id: 5283977c8a3406d20a2823abb4c1b651fb46136d 18 August 2021, 00:51:51 UTC
5d35649 [Lighting] Upgrade `requirements.txt` for downstream projects to latest fbcode revision. Summary: ^ Reviewed By: yifuwang Differential Revision: D30346110 fbshipit-source-id: 154e69f233132635e947ddbd252ffbd957ead6f1 16 August 2021, 22:35:21 UTC
8c80a00 [MMF][fix] Only save config in master process Summary: In large-scale distributed jobs, multiple processes writing config simultaneously to the manifold can cause issues with consistency among the keys. This PR makes sure that only master process writes the config. Reviewed By: vedanuj Differential Revision: D30193487 fbshipit-source-id: 060fe341a7dfd13f81627ded948e35a669ecbde6 11 August 2021, 07:33:53 UTC
c745af5 [feat] use persistent workers in data loader by default (#1041) Summary: Switch to use persistent workers in MMF data loaders, so that one doesn't need to keep forking and joining worker processes upon each iteration. This update reduces the overhead and potential OOM error in worker forking. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1041 Test Plan: tested locally Reviewed By: vedanuj Differential Revision: D30238770 Pulled By: ronghanghu fbshipit-source-id: d2ba9fa10d9be4468cf69004104824833428a45b 11 August 2021, 05:34:44 UTC
d37fffc Synchronize PyTorchLightning/pytorch-lightning (revision 000fbe63@000fbe63) to github/third-party/PyTorchLightning/pytorch-lightning Summary: # Manual Changes - Migrate callsites of `_extract_batch_size` to `extract_batch_size` (as per https://fburl.com/code/4q7n8fs9). - Remove unnecessary unit tests in `test_hive_writing_callback.py` ### New commit log messages 000fbe63 Expose `extract_batch_size` method and add corresponding tests. (#8357) Reviewed By: yifuwang Differential Revision: D29834484 fbshipit-source-id: 219a3d40401d9b2c35d3a74b75f2394c4f57d61b 27 July 2021, 04:44:34 UTC
7fabdb6 Synchronize PyTorchLightning/pytorch-lightning (revision eb6d9912@eb6d9912) to github/third-party/PyTorchLightning/pytorch-lightning Summary: # Note After this PR, gradients are clipped/normalized in between `on_after_backward` and `on_before_optimizer_step`. Changed the test to perform the gradient clipping check `on_before_optimizer_step` rather than `on_after_backward`. - Changed `test_grad_clipping.py` to use `on_before_optimizer_step` for the callback. ### New commit log messages eb6d9912 Refactor plugins backward (#8328) Reviewed By: yifuwang Differential Revision: D29834093 fbshipit-source-id: efa284ea92ec715d4fa2155f72f969e6399febca 27 July 2021, 04:44:34 UTC
1056bdd [feat] check NaNs in losses during training, and exit when it happens (#1027) Summary: Add config option `training.exit_on_nan_losses` (Default to True). When `training.exit_on_nan_losses` is True, check for NaNs in the loss dict and exit the training when NaN happens. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1027 Test Plan: tested locally; a new test case `test_exit_on_nan_losses` is added. Reviewed By: apsdehal Differential Revision: D29855002 Pulled By: ronghanghu fbshipit-source-id: e5c8ea3c17c5ed7140a417317062c0f4c2ea45fa 25 July 2021, 22:42:43 UTC
77de437 [fix][PL][1/N]: clean up lightning test code (#1017) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1017 ≈ Test Plan: Imported from OSS Reviewed By: apsdehal, simran2905 Differential Revision: D29670416 Pulled By: ytsheng fbshipit-source-id: 8fb5e71cd31ea8133be8f868dd132f2553e04e15 24 July 2021, 00:26:14 UTC
cef7440 [perf] tune NCCL params for acceleration (#185) Summary: Pull Request resolved: https://github.com/fairinternal/mmf-internal/pull/185 Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1026 Following suggestions from post https://fb.workplace.com/notes/yi-wang/faster-distributed-training-in-2-lines/271004654689757 and add 2 more NCCL parameters if it's distributed training on FB cluster. Generally, we are seeing around 1.5 ~ 2X speedup in MMF. Reviewed By: vedanuj, apsdehal Differential Revision: D28306852 fbshipit-source-id: d41d44b6708e43e084aa061afeee9f1981bf5bec 23 July 2021, 05:16:44 UTC
c5c7930 [MMF][feat] Add callback in registry (#1029) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1029 Add callback register so that user can add their customized callback function in MMF training. # Usage ``` training: ... callbacks: - type: my_callback params: foo: bar ``` Reviewed By: vedanuj Differential Revision: D29810950 fbshipit-source-id: 36c03cd9aa29a9e6f1c8fda61ad3be95088dbca8 22 July 2021, 20:24:59 UTC
9c10014 [sdoc] Update static-dcos docusaurus config files without internal and external editUrls. Summary: Update all docusaurus.config.js files to have both internal and external editUrls Reviewed By: jknoxville Differential Revision: D29741479 fbshipit-source-id: b1efd6c5603f0d3e1edaa738df86aeffe5801897 19 July 2021, 16:44:42 UTC
697da00 [fix] using temperature in clip loss scaling Summary: Scale LOSS with Temperature!!! Reviewed By: mengjiaow Differential Revision: D29743897 fbshipit-source-id: dab04ffb1c4a0b9b02084cc85ebc834e56726c18 17 July 2021, 01:57:11 UTC
eef7028 [fix] black (#1004) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1004 Reviewed By: vedanuj Differential Revision: D29566950 Pulled By: ytsheng fbshipit-source-id: 00b93496a17b19fe68b6096ee08a58d421a3fb9b 09 July 2021, 20:28:02 UTC
7dbe6a0 [MMF] fix freeze_base in unimodal image model (#1006) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/1006 `freeze_base` is not used in MMF unimodal image model so we can't train an image model with fixed trunk. Reviewed By: apsdehal Differential Revision: D29524453 fbshipit-source-id: ba8023b9b987d48e3612aaa46b2d30c5e71fb019 07 July 2021, 20:35:20 UTC
273a56b [feat] ITM Loss (#961) Summary: PR adds Image-text matching loss to MMF. The loss can be used standalone or with the MMFTransformer as a head. Addresses https://github.com/facebookresearch/mmf/issues/947 #466 - Adds ITM loss - Fixes ITM loss for validation dataset - Adds config for COCO ITM loss - Adds tests for ITM loss Pull Request resolved: https://github.com/facebookresearch/mmf/pull/961 Test Plan: Imported from GitHub, without a `Test Plan:` line. Pass tests Reviewed By: apsdehal Differential Revision: D28925014 Pulled By: vedanuj fbshipit-source-id: d123468f746820e1412380384dd15c5ebed15887 30 June 2021, 21:15:33 UTC
a13040b [Fix][Hateful memes fine grained] Fix dataset yaml file format Summary: Default format requires a "version" and "resource" field. Reviewed By: vedanuj Differential Revision: D29493693 fbshipit-source-id: ac519b48b909a6e3b13fbc70a7e55ddfe6c623ed 30 June 2021, 20:18:41 UTC
b771f97 [fix] black and isort (#991) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/991 Reviewed By: vedanuj Differential Revision: D29448673 Pulled By: ytsheng fbshipit-source-id: f60d39fee67e331e09314e4f644b03dde1d50caf 29 June 2021, 21:14:50 UTC
71dfcfc [feat][clip] minor clip update for processor, model and loss Summary: * make clip_text_processor to be more generic * avoid using /= * add temperature to the model Reviewed By: vedanuj Differential Revision: D29384557 fbshipit-source-id: 8b16081fc18a0978aee959640fe063bba741c884 28 June 2021, 21:26:23 UTC
397c163 [mmf,fix] Support OC 2.1; fix internal tests Summary: Fixes the final internal test that is failing. Reviewed By: ytsheng Differential Revision: D29406286 fbshipit-source-id: 6003cc01036a736a971abd5b11eae6a6b67fdc63 28 June 2021, 21:10:49 UTC
b718c89 [chores] PT upgrade (#987) Summary: Upgrade to PT 1.9, torchvision 0.10, torchaudio 0.9 Pull Request resolved: https://github.com/facebookresearch/mmf/pull/987 Reviewed By: ytsheng Differential Revision: D29415991 Pulled By: vedanuj fbshipit-source-id: dc4bec0a6f2a05702e1601bf816acb95de2471c0 28 June 2021, 18:31:53 UTC
666e7c5 [fix] oss and fbcode pytorch lightning version sync (#979) Summary: tests passed. 188 passed, 175 warnings in 838.33s (0:13:58) Pull Request resolved: https://github.com/facebookresearch/mmf/pull/979 Reviewed By: vedanuj Differential Revision: D29283067 Pulled By: ytsheng fbshipit-source-id: e5c52dc1323cdfd6e23a83803b289c7ade57332b 26 June 2021, 01:07:13 UTC
e6efa84 [fix] Support for OmegaConf 2.1: fix rest of the tests (#981) Summary: Some of the tests are still failing. Attempt to fix those. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/981 Reviewed By: ytsheng, vedanuj Differential Revision: D29311564 Pulled By: apsdehal fbshipit-source-id: bbc98aa11dc94b8c0299ebd03f5eff8f3f7e1c07 24 June 2021, 20:36:13 UTC
dbd2be7 [fix] refactor regression (#978) Summary: A regression caused by a recent refactor. Fixes issue: https://github.com/facebookresearch/mmf/issues/976 Pull Request resolved: https://github.com/facebookresearch/mmf/pull/978 Reviewed By: apsdehal Differential Revision: D29282922 Pulled By: ytsheng fbshipit-source-id: c11b15283a4e83d76e115496076db917efacc43c 23 June 2021, 09:06:41 UTC
88fc9d8 [feat] Patch MMF for concurrent use of transformer v3.x and v4.x (#960) Summary: Due to internal systems being relying on older version, it is hard to upgrade transformers v4.x while maintaining sanity. This diffs patches 4.x to behave same in terms of imports and can be used by end users who want to upgrade to transformers v4.x without actually upgrading MMF. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/960 Test Plan: Tested by upgrading to new version. Reviewed By: vedanuj Differential Revision: D28917040 Pulled By: apsdehal fbshipit-source-id: 0f01d507a2d0afbc4fa58bd44933966d23255e9a 23 June 2021, 07:02:33 UTC
133b923 [fix] Support OmegaConf 2.1 (#973) Summary: Changes to support upgrading to omegaconf 2.1 Pull Request resolved: https://github.com/facebookresearch/mmf/pull/973 Reviewed By: ytsheng Differential Revision: D29189139 Pulled By: apsdehal fbshipit-source-id: b719ec94b00bd24b48ad12d3e58ef1f44aa454c5 18 June 2021, 08:09:55 UTC
b08ac7a [feat] Adding KRISP, additions to OKVQA dataset (#750) Summary: Adding KRISP Paper to mmf repo Additional changes to use image features for OKVQA Pull Request resolved: https://github.com/facebookresearch/mmf/pull/750 Reviewed By: ytsheng, vedanuj Differential Revision: D29082706 Pulled By: apsdehal fbshipit-source-id: 5eb3346291f6de8eaf44385d7a6cba52d317b8d4 17 June 2021, 02:20:03 UTC
7705b7f [mmf_ads][sweep] sweep pretrain+finetune large model (#183) Summary: Pull Request resolved: https://github.com/fairinternal/mmf-internal/pull/183 Sweep finetuning from a pre-trained large model Differential Revision: D29056437 fbshipit-source-id: 22214d8d3c6958ce4a4a8a0fcef0455efcf0be34 15 June 2021, 02:59:07 UTC
9d5222a [feat] add resnet18 as encoder (#970) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/970 Adding resnet-18 image encoder Reviewed By: apsdehal Differential Revision: D28267636 fbshipit-source-id: 49ad3860b7abfa7d0697be13a1369500337e9ed1 15 June 2021, 00:35:02 UTC
322bd33 [feat] PL last validation after training (#933) Summary: * this implements the last validation functionality after training since it was added in PL master recently. * updated the tests to check for the last validation result. * still waiting on PL to fix its tariner.global_step inconsistency * two reports are being kept for now until we figure out a better way to consolidate them. They are being kept in the lightning module for calculating the early stopping and saving the checkpoint (PR coming soon); they are being kept in the loop callback for logging purposes. Eventually, we may move all of them into the lightning module. But I am submitting the PRs one step at the time for now. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/933 Reviewed By: apsdehal, simran2905 Differential Revision: D28329041 Pulled By: ytsheng fbshipit-source-id: 60f014fa37556a6d15645d5cfe8b1442c12b9aa2 12 June 2021, 16:58:59 UTC
7cc07dc Bump url-parse from 1.4.7 to 1.5.1 in /website (#932) Summary: Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/unshiftio/url-parse/commit/eb6d9f51e395b7e47bf2594e457d541db21c713b"><code>eb6d9f5</code></a> [dist] 1.5.1</li> <li><a href="https://github.com/unshiftio/url-parse/commit/750d8e8a9d45dbce9ff09759f0fe4564cdd47d74"><code>750d8e8</code></a> [fix] Fixes relative path resolving <a href="https://github-redirect.dependabot.com/unshiftio/url-parse/issues/199">https://github.com/facebookresearch/mmf/issues/199</a> <a href="https://github-redirect.dependabot.com/unshiftio/url-parse/issues/200">https://github.com/facebookresearch/mmf/issues/200</a> (<a href="https://github-redirect.dependabot.com/unshiftio/url-parse/issues/201">https://github.com/facebookresearch/mmf/issues/201</a>)</li> <li><a href="https://github.com/unshiftio/url-parse/commit/3ac777474ba5dc48a7e33771cbb311fc6f69bef8"><code>3ac7774</code></a> [test] Make test consistent for browser testing</li> <li><a href="https://github.com/unshiftio/url-parse/commit/267a0c6f7ef1a58271be61611c5103daace602c9"><code>267a0c6</code></a> [dist] 1.5.0</li> <li><a href="https://github.com/unshiftio/url-parse/commit/d1e7e8822f26e8a49794b757123b51386325b2b0"><code>d1e7e88</code></a> [security] More backslash fixes (<a href="https://github-redirect.dependabot.com/unshiftio/url-parse/issues/197">https://github.com/facebookresearch/mmf/issues/197</a>)</li> <li><a href="https://github.com/unshiftio/url-parse/commit/d99bf4cf259b7378c855f786edc253e70405ffdc"><code>d99bf4c</code></a> [ignore] Remove npm-debug.log from .gitignore</li> <li><a href="https://github.com/unshiftio/url-parse/commit/422c8b5e4cac6a79cd35b4e86731476dcbeec7e4"><code>422c8b5</code></a> [pkg] Replace nyc with c8</li> <li><a href="https://github.com/unshiftio/url-parse/commit/933809d630c7b21399b4e5df59fccccd80033b21"><code>933809d</code></a> [pkg] Move coveralls to dev dependencies</li> <li><a href="https://github.com/unshiftio/url-parse/commit/190b2168035899a2a88f2dc2625963bf7e2f338f"><code>190b216</code></a> [pkg] Add .npmrc</li> <li><a href="https://github.com/unshiftio/url-parse/commit/ce3783f4ea25753cfa36376769c14e4e2fe6ea80"><code>ce3783f</code></a> [test] Do not test on all available versions of Edge and Safari</li> <li>Additional commits viewable in <a href="https://github.com/unshiftio/url-parse/compare/1.4.7...1.5.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=url-parse&package-manager=npm_and_yarn&previous-version=1.4.7&new-version=1.5.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/932 Reviewed By: apsdehal Differential Revision: D28430674 Pulled By: vedanuj fbshipit-source-id: 7691d843940db4685202618bda30cc99a55e00d3 12 June 2021, 00:17:09 UTC
08b2238 Bump lodash from 4.17.19 to 4.17.21 in /website (#936) Summary: Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/f299b52f39486275a9e6483b60a410e06520c538"><code>f299b52</code></a> Bump to v4.17.21</li> <li><a href="https://github.com/lodash/lodash/commit/c4847ebe7d14540bb28a8b932a9ce1b9ecbfee1a"><code>c4847eb</code></a> Improve performance of <code>toNumber</code>, <code>trim</code> and <code>trimEnd</code> on large input strings</li> <li><a href="https://github.com/lodash/lodash/commit/3469357cff396a26c363f8c1b5a91dde28ba4b1c"><code>3469357</code></a> Prevent command injection through <code>_.template</code>'s <code>variable</code> option</li> <li><a href="https://github.com/lodash/lodash/commit/ded9bc66583ed0b4e3b7dc906206d40757b4a90a"><code>ded9bc6</code></a> Bump to v4.17.20.</li> <li><a href="https://github.com/lodash/lodash/commit/63150ef7645ac07961b63a86490f419f356429aa"><code>63150ef</code></a> Documentation fixes.</li> <li><a href="https://github.com/lodash/lodash/commit/00f0f62a979d2f5fa0287c06eae70cf9a62d8794"><code>00f0f62</code></a> test.js: Remove trailing comma.</li> <li><a href="https://github.com/lodash/lodash/commit/846e434c7a5b5692c55ebf5715ed677b70a32389"><code>846e434</code></a> Temporarily use a custom fork of <code>lodash-cli</code>.</li> <li><a href="https://github.com/lodash/lodash/commit/5d046f39cbd27f573914768e3b36eeefcc4f1229"><code>5d046f3</code></a> Re-enable Travis tests on <code>4.17</code> branch.</li> <li><a href="https://github.com/lodash/lodash/commit/aa816b36d402a1ad9385142ce7188f17dae514fd"><code>aa816b3</code></a> Remove <code>/npm-package</code>.</li> <li>See full diff in <a href="https://github.com/lodash/lodash/compare/4.17.19...4.17.21">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~bnjmnt4n">bnjmnt4n</a>, a new releaser for lodash since your current version.</p> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=lodash&package-manager=npm_and_yarn&previous-version=4.17.19&new-version=4.17.21)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/936 Reviewed By: apsdehal Differential Revision: D28430679 Pulled By: vedanuj fbshipit-source-id: 017157083dc80a6d705fbe1c2964847cf4b43396 12 June 2021, 00:13:05 UTC
f8e424a Bump ws from 6.2.1 to 6.2.2 in /website (#957) Summary: Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/websockets/ws/commits">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ws&package-manager=npm_and_yarn&previous-version=6.2.1&new-version=6.2.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/957 Reviewed By: apsdehal Differential Revision: D28995838 Pulled By: vedanuj fbshipit-source-id: c5acd84ec6c66f4c737774f7c29ab9403174d2e3 12 June 2021, 00:10:30 UTC
778893c Bump merge-deep from 3.0.2 to 3.0.3 in /website (#963) Summary: Bumps [merge-deep](https://github.com/jonschlinkert/merge-deep) from 3.0.2 to 3.0.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/jonschlinkert/merge-deep/commit/628ff47c9d824ccf21adf9a2b7cc6b74632e11a1"><code>628ff47</code></a> 3.0.3</li> <li><a href="https://github.com/jonschlinkert/merge-deep/commit/cfbe20ccdb00255b711de57e37ed8ce9f109ef3f"><code>cfbe20c</code></a> run verb to generate README documentation</li> <li><a href="https://github.com/jonschlinkert/merge-deep/commit/e370968581413a2e5ffdbbf7c2f5094e0e0b3861"><code>e370968</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/jonschlinkert/merge-deep/issues/17">https://github.com/facebookresearch/mmf/issues/17</a> from jonschlinkert/key-properties</li> <li><a href="https://github.com/jonschlinkert/merge-deep/commit/393e2cbaeacf54e77a307c3620a00f0ac057b8d5"><code>393e2cb</code></a> adding a test to ensure using merge-deep for inheritance still works</li> <li><a href="https://github.com/jonschlinkert/merge-deep/commit/c39b16134a6a9704be2e661b49b92e8561f10d90"><code>c39b161</code></a> add test to ensure constructor is not cloned</li> <li><a href="https://github.com/jonschlinkert/merge-deep/commit/11e5dd56de8a6aed0b1ed022089dbce6968d82a5"><code>11e5dd5</code></a> add isValidKey function to ensure only valid keys are merged</li> <li>See full diff in <a href="https://github.com/jonschlinkert/merge-deep/compare/3.0.2...3.0.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=merge-deep&package-manager=npm_and_yarn&previous-version=3.0.2&new-version=3.0.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/963 Reviewed By: apsdehal Differential Revision: D28995854 Pulled By: vedanuj fbshipit-source-id: 0e143e6746df8e5120a2a74633a0b6ea0d781018 12 June 2021, 00:09:06 UTC
7dfad57 Bump hosted-git-info from 2.8.8 to 2.8.9 in /website (#937) Summary: Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md">hosted-git-info's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9">2.8.9</a> (2021-04-07)</h2> <h3>Bug Fixes</h3> <ul> <li>backport regex fix from <a href="https://github-redirect.dependabot.com/npm/hosted-git-info/issues/76">https://github.com/facebookresearch/mmf/issues/76</a> (<a href="https://github.com/npm/hosted-git-info/commit/29adfe5">29adfe5</a>), closes <a href="https://github-redirect.dependabot.com/npm/hosted-git-info/issues/84">https://github.com/facebookresearch/mmf/issues/84</a></li> </ul> <p><!-- raw HTML omitted --><!-- raw HTML omitted --></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/hosted-git-info/commit/8d4b3697d79bcd89cdb36d1db165e3696c783a01"><code>8d4b369</code></a> chore(release): 2.8.9</li> <li><a href="https://github.com/npm/hosted-git-info/commit/29adfe5ef789784c861b2cdeb15051ec2ba651a7"><code>29adfe5</code></a> fix: backport regex fix from <a href="https://github-redirect.dependabot.com/npm/hosted-git-info/issues/76">https://github.com/facebookresearch/mmf/issues/76</a></li> <li>See full diff in <a href="https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~nlf">nlf</a>, a new releaser for hosted-git-info since your current version.</p> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=hosted-git-info&package-manager=npm_and_yarn&previous-version=2.8.8&new-version=2.8.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/937 Reviewed By: apsdehal Differential Revision: D28430663 Pulled By: vedanuj fbshipit-source-id: 167c5d80e1148d1c244f01940aa85adf81c6ef38 12 June 2021, 00:06:43 UTC
dce69a1 [feat] AIRStore Dataset Integration (#918) Summary: - Add Airstore dataset - Add config for running masked coco training with Airstore Pull Request resolved: https://github.com/facebookresearch/mmf/pull/918 Test Plan: - Tested with Masked COCO training Reviewed By: apsdehal Differential Revision: D29050028 Pulled By: vedanuj fbshipit-source-id: 1e5b320778418a832507a5fbe6aa16d214f36c12 11 June 2021, 23:40:22 UTC
b00223d [fix] set logging level according to training.logger_level (#959) Summary: Correctly set logging level in the logger according to training.logger_level. Also fix lint errors in other files to pass the tests. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/959 Test Plan: tested locally. Reviewed By: vedanuj Differential Revision: D28925702 Pulled By: ronghanghu fbshipit-source-id: e42e8eb559b2b32f4e8c7dda9fc2a3a424f63eda 10 June 2021, 09:44:44 UTC
6777ca4 fix fp16 overflow issue (#962) Summary: "-1e9" induces "RuntimeError: value cannot be converted to type at::Half without overflow:" when fp16=true, replace it with "-10000.0" Tested locally Thanks for your contribution! If you're sending a large PR (e.g., >50 lines), please open an issue first about the feature/bug, and indicate how you want to contribute. Use [contributing guidelines](https://github.com/facebookresearch/mmf/tree/master/.github/CONTRIBUTING.md) before opening up the PR to follow MMF style guidelines. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/962 Reviewed By: vedanuj Differential Revision: D28963671 Pulled By: jayleicn fbshipit-source-id: f8dcdd28eeccc9d2b19af4cd17710c869feb0eea 08 June 2021, 17:44:23 UTC
5265e1c [feat,fix] Random init bert encocder, other QoL fixes (#941) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/941 - Add dataset_type property to base_dataset class to avoid some failures in dataset builders - broadcast fp16 in OSS - Fix NCCL error happening in sweep script - is_correct if not present in processor output defaults to True This changes are required for running fairseq_mlm. Pull Request resolved: https://github.com/fairinternal/mmf-internal/pull/178 Reviewed By: vedanuj Differential Revision: D28393021 Pulled By: apsdehal fbshipit-source-id: c31bcff57d1ce8bde71a38e7e99cc70ecb5a7c13 08 June 2021, 06:32:06 UTC
1bb7b75 [feat][6/N] clip accuracy (#165) Summary: Pull Request resolved: https://github.com/fairinternal/mmf-internal/pull/165 Test Plan: Run `pytest tests` to see the metrics test cases pass Reviewed By: apsdehal Differential Revision: D27457530 Pulled By: ytsheng fbshipit-source-id: ed82a88f3fc21a881c9d4d364a9efaba624cf95e 08 June 2021, 06:25:29 UTC
4694a4e [MMF][fix] fix python version comparison (#958) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/958 Move from string based comparison to major/minor integer based comparison. Searched for `torch.__version__` in repo to find all uses Reviewed By: vedanuj Differential Revision: D28900525 fbshipit-source-id: b6c069ffdba9b849c58bf6f50f5d453e0edb68ee 04 June 2021, 19:22:01 UTC
10cc2b7 Bump dns-packet from 1.3.1 to 1.3.4 in /website (#951) Summary: Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mafintosh/dns-packet/commit/ebdf849da5dc0d96836e87628349776c623c5be7"><code>ebdf849</code></a> 1.3.4</li> <li><a href="https://github.com/mafintosh/dns-packet/commit/ac578722f2707310b841b65aae61d6332f8882a1"><code>ac57872</code></a> move all allocUnsafes to allocs for easier maintenance</li> <li><a href="https://github.com/mafintosh/dns-packet/commit/c64c9507e51532c9e9a3cbefa146a134ecc025fd"><code>c64c950</code></a> 1.3.3</li> <li><a href="https://github.com/mafintosh/dns-packet/commit/0598ba19d18da4568b32415e60a9629061b3c45c"><code>0598ba1</code></a> fix .. in encodingLength</li> <li><a href="https://github.com/mafintosh/dns-packet/commit/010aedb33c1ee8c3f558db5249c1d46e2bd7a101"><code>010aedb</code></a> 1.3.2</li> <li><a href="https://github.com/mafintosh/dns-packet/commit/0d0d593f8df4e2712c43957a6c62e95047f12b2d"><code>0d0d593</code></a> backport encodingLength fix to v1</li> <li>See full diff in <a href="https://github.com/mafintosh/dns-packet/compare/v1.3.1...v1.3.4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dns-packet&package-manager=npm_and_yarn&previous-version=1.3.1&new-version=1.3.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookresearch/mmf/network/alerts). </details> Pull Request resolved: https://github.com/facebookresearch/mmf/pull/951 Reviewed By: ytsheng Differential Revision: D28839295 Pulled By: vedanuj fbshipit-source-id: 77ef7f8af869fa255bf410a272112cf9fe893e75 03 June 2021, 18:22:09 UTC
5d94327 [feat] Implement knowledge distillation in MMF (#956) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/956 Add a general knowledge distillation in MMF # High-level Design * Knowledge distillation model contains teacher and student models. Teacher model is used to generate soft targets and let student model mimic. * Add a processor which can process text and feature of teacher and student models. The text/feature processors can be different. * In yaml config, student model still uses the name like `text_processor` in dataset_config. `teacher_text_processor` or `teacher_feature_key` can be added to specify teacher's processor or feature_key. Teacher model is built and loaded from `modal_config.kd.teacher.pretrained_checkpoint` and its parameters can be frozen or tunable. Student config has the same format as teacher's and supports loading pretrained model. * Support three distillation losses: MSELoss, CosineEmbeddingLoss, and KLDivergence. The final loss is a weighted sum of distillation and metric losses. # Summary of experiment results 1. LR set as 1e-4 to 1e-3 2. KL divergence as distillation loss is the best 3. Classification loss weight should be small 4. Different teacher architecture doesn't really matter 5. It doesn't matter whether student parameters are pretrained or not 6. If image features are the same in teacher and student, extra data is not needed to get similar performance 7. Otherwise, unlabeled data will help student model performance Reviewed By: vedanuj Differential Revision: D27726297 fbshipit-source-id: 37673782265aa1e80af0172b974ae430d6fd7a6e 03 June 2021, 06:46:37 UTC
c2af5c1 [feat] allow modules to have mismatch dimensions when loading pretrained checkpoints (#955) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/955 Pull Request resolved: https://github.com/fairinternal/mmf-internal/pull/182 Make it possible to skip dimension mismatch weight copying during pretrained checkpoint loading if users specify so. One use case is to add new modalities (xray video embedding) into the pretrained checkpoint so that things like token_type embedding can be changed. Reviewed By: apsdehal Differential Revision: D28703466 fbshipit-source-id: 95a1abc115b3095f658d2fe9c89440f571568b36 02 June 2021, 05:17:17 UTC
b37493a [feat] allow different lr to be set for encoders (image encoder) (#181) Summary: Pull Request resolved: https://github.com/fairinternal/mmf-internal/pull/181 Pull Request resolved: https://github.com/facebookresearch/mmf/pull/953 This diff allows to set different lr to different encoders such as image encoder. Reviewed By: apsdehal Differential Revision: D28700114 fbshipit-source-id: c5e44cde08c95ebde803ce80ac166b32f7ac7249 02 June 2021, 04:57:04 UTC
25d69c8 [PostRay] Create a Recurring WPIE Eval that skips the sweep launcher 1/N (#179) Summary: Pull Request resolved: https://github.com/fairinternal/mmf-internal/pull/179 Pull Request resolved: https://github.com/facebookresearch/mmf/pull/950 Created a new flow workflow that performs the same operations as the current launcher, but does it as part of flow execution so it can be launched with flow-cli (or indeed, as a recurring run) The prefix field defaults to having a date/time macro in it which should allow us to avoid collisions in the recurring run Reviewed By: madian9, apsdehal Differential Revision: D28608702 fbshipit-source-id: 9b43f3aa6ea34893bf9d172cf37e2e4e8ba1d25f 21 May 2021, 22:44:54 UTC
da8287a [MMC] Experiment on attribute new taxonomy Summary: Experiments on commerce attribute with new taxonomy Modifications 1. Fix soft label masking error when label contains `ignore_index` 2. Compute AP even if some labels are missing during validation 3. Add metric `accuracy_with_unknown` for missing category Reviewed By: lichengunc Differential Revision: D28346114 fbshipit-source-id: a8f76eb29a3fdb9f165aecbd66428511ec154a50 21 May 2021, 00:04:06 UTC
3183b13 [feat] add project docs to UniT model (#920) Summary: Add a project page to UniT in the MMF website. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/920 Test Plan: tested website building internally Reviewed By: vedanuj Differential Revision: D28137781 Pulled By: ronghanghu fbshipit-source-id: 9126b013116633921f439699ec8e6a4a9359d279 20 May 2021, 17:47:51 UTC
7bca9c1 [mmf] Add usage logging to components (#938) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/938 Adding usage logging to MMF components for analytics Reviewed By: ytsheng Differential Revision: D28309104 fbshipit-source-id: c9dfd619ceba6d9d9c87df4ab86cf1773f51bde6 17 May 2021, 21:10:24 UTC
44ae471 [fix] Memory leak in test reporter; detach report in inference (#939) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/939 In recent PR, we started adding to report in all processors to better support TPUs. Unfortunately, the data collected in test reporter was not continuously flushed in cases other than master. This PR fixes. Other than that, we now detach the report as well in prediction loop. Reviewed By: rayhou0710 Differential Revision: D28338749 fbshipit-source-id: 850ce1b5b77d992a9357a60cbf107b42ff6e81d5 12 May 2021, 22:34:25 UTC
957087b [fix,feat] fix lightning requirements + add leak hook (#940) Summary: * Lightning got updated and they also updated the internal tests, but they did not update the OSS dependency. We should communicate it to them so that they can also the OSS side. Or if there is an automatic way of doing this, it would be even better. * This diff adds a pytest hook to check for memory leaks being caused. This just adds printing statements. {F615127206} Pull Request resolved: https://github.com/facebookresearch/mmf/pull/940 Reviewed By: apsdehal Differential Revision: D28375742 Pulled By: ytsheng fbshipit-source-id: d6d6978ffaec3a70730a1126761b8e9e1190bae3 12 May 2021, 08:32:57 UTC
51bc339 Synchronize PyTorchLightning/pytorch-lightning (revision 7b283e3c@master) to github/third-party/PyTorchLightning/pytorch-lightning Summary: # Manual - remove fixme's in `model_checkpoint.py`, `parameter_monitor.py`, `test_quantization.py`, and `speed_monitor.py` now that `Trainer` is properly annotated. - update `test_quantization.py` to `trainer.train_loop.global_step` instead of `trainer.global_step` which is a read-only. - update `loop_callback.py` to read from `train_loop` for `batch_idx` (which is no longer available). # Automatic ### New commit log messages 7b283e3c Bugfix/Multiple dataloaders (#7433) d7c44cc6 Docs: sync chlog 1.3.1 (#7478) fdf50a5e Mark certain Trainer APIs as protected (#7420) ad9118f0 remove trainer hidden state | sanity refactor [1 / n] (#7437) 4a1134db Log epoch metrics before firing the `on_evaluation_end` hook (#7272) b65ae794 Automatically check `DataModule.has_{setup,teardown,prepare_data}` [2/2] (#7238) 8660d8cf [pre-commit.ci] pre-commit autoupdate (#7475) f6fe715e Fix Sphinx argument deprecation (#7464) Reviewed By: shuyingsunshine21 Differential Revision: D28353491 fbshipit-source-id: 98b87d99e2f09b47b07270858fcbdb5d5299730b 12 May 2021, 00:38:28 UTC
8447557 [fix] isort broken on master (#934) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/934 Reviewed By: apsdehal Differential Revision: D28317799 Pulled By: ytsheng fbshipit-source-id: 0e69b7dec6c0e476ea9ab71326b8b32dd1fe4c4e 10 May 2021, 23:06:10 UTC
38fab0b [feat] make it optional to tie mlm head weights to text_encoder embedding weights (#172) Summary: Pull Request resolved: https://github.com/fairinternal/mmf-internal/pull/172 Pull Request resolved: https://github.com/facebookresearch/mmf/pull/874 Make it possible to have the mlm head weights tied to text_encoder embedding weights in case we have a separate text encoder for encoding text modalities. Reviewed By: apsdehal Differential Revision: D27756957 fbshipit-source-id: ce26e79ca9930127f36c3c2adfe280e3c67ac23a 09 May 2021, 00:45:41 UTC
dbe8dec [refactor][4/N]: allow download to work for manifold files (#173) Summary: Pull Request resolved: https://github.com/fairinternal/mmf-internal/pull/173 * adds a feature in download.py to allow it to work for manifold * onboards clip_processor to work with all three config below: * local on disk file * manifold file * http file Reviewed By: vedanuj Differential Revision: D27760358 fbshipit-source-id: 1b7b8eff09a21e8afc48971d69d46df18a8ced6b 08 May 2021, 21:27:00 UTC
2147104 [postray] move around modality keys when searching for image channel Summary: In the use case of WPIE in D28278151, we take multiple image type inputs such as raw image, xray, xray_oc, cluster_fit, etc. Move modality to the first place of _check_keys_for_modality() so that we first search for the modality name. Otherwise, all image type encoders will pick up the "image" key. Reviewed By: apsdehal Differential Revision: D28306631 fbshipit-source-id: 021cb6300e228431797996321d28bbd8ebd2865d 08 May 2021, 04:06:04 UTC
e2d2742 [fix] fall back to None for max_updates and num_updates on trainer (#924) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/924 Reviewed By: apsdehal Differential Revision: D28179972 Pulled By: ytsheng fbshipit-source-id: 37cc47b6a81d375558eec522bd8724fad6324513 07 May 2021, 06:03:45 UTC
26cd2ea [fix] sound file import (#929) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/929 fix: https://fb.workplace.com/groups/574291956570984/permalink/732930907373754/ Reviewed By: apsdehal Differential Revision: D28242842 fbshipit-source-id: cd67eb71ab2739396d0bbc8b47f7b8eebaca0ab3 06 May 2021, 03:06:18 UTC
d2a2e91 [fix] Assign config to instance in setup as well (#928) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/928 Followup to https://github.com/facebookresearch/mmf/pull/921 for datasets which don't inherit from MMFDatasetBuilder Reviewed By: ytsheng Differential Revision: D28238562 fbshipit-source-id: 2502800fbe72a81b578aacbb38faebb9364c813f 06 May 2021, 02:28:18 UTC
90c1e74 [fix] get_optimizer_parameters in BaseTransformer (#927) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/927 Pull Request resolved: https://github.com/fairinternal/mmf-internal/pull/177 Fix the functionality of assigning a different lr to task heads. Reviewed By: vedanuj Differential Revision: D28112762 fbshipit-source-id: f7038594ff7451031e557bc81e4bf3adbff84da0 06 May 2021, 00:22:35 UTC
18534f8 [feat] Charades dataset along with video and audio processors (#894) Summary: This PR adds support for Charades dataset along with general purpose video and audio processors Pull Request resolved: https://github.com/facebookresearch/mmf/pull/894 Test Plan: ``` python mmf_cli/run.py config=projects/mmf_transformer/configs/charades/direct.yaml run_type=train_val dataset=charades model=mmf_transformer training.batch_size=4 training.num_workers=1 training.find_unused_parameters=True training.log_interval=100 ``` Reviewed By: ytsheng Differential Revision: D28124494 Pulled By: apsdehal fbshipit-source-id: b2c11598872baef5cc279d653176d2b45d0e45eb 05 May 2021, 09:38:22 UTC
0505b85 [fix] XLA issues, test reporter barrier, oc and torch warnings (#922) Summary: - Return false for is_xla in case it is not registered for correct drop_last setting in dataloader - Always call format_for_prediction for all workers to avoid hangs in TPU and NCCLs - Move .pretty use in OC to OmegaConf.to_yaml - Remove `check_reduction` parameter from DDP init Pull Request resolved: https://github.com/facebookresearch/mmf/pull/922 Test Plan: Tested locally with changes on charades branch Reviewed By: vedanuj Differential Revision: D28156890 Pulled By: apsdehal fbshipit-source-id: 8d4156f050dd09e4201673dcc030f242d8bd4df7 05 May 2021, 04:57:43 UTC
fe714b3 [mmf][PR][fix] Fix roberta_processor and transformer_processor (#923) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/923 **BERT encodes:** - **single sequence: ``[CLS] X [SEP]``** - **pair of sequences: ``[CLS] A [SEP] B [SEP]``** **RoBERTa and SPM encode:** - **single sequence: ``<s> X </s>``** - **pair of sequences: ``<s> A </s> </s> B </s>``** The original implementation would cause: 1) if a sentence is longer than max_seq_len, it will be chunked without eos token, i.e., `<s> X` instead of `<s> X </s>`. 2) the masking strategy is not correctly supported: 2a) no correct `<mask>` token; 2b) bos and eos token could be masked out in the function of `random_word()`. In this diff, we made the following changes: 1) Add `<mask>` token and its mapping to `SentencePieceTokenizer`. 2) Add `MaskedRobertaTokenizer` class and our `SentencePieceTokenizer` would be its subclass. 3) Make sure `_truncate_seq_pair` will return sentence of `<s> x </s>` or a pair of sentence of `<s> x </s> </s> y </s>`. Previously the last `</s>` would be popped if the input was a too long sentence. 4) Add tests of too long sentence, two sentence, and masked sentence. For making `SentencePieceTokenizer` a subclass of `MaskedRobertaTokenizer`, we simply did a small surgery of the returned SPM's tokenization result, which removes the pre-padded `<s>` and `</s>` from the input sentence. We will add them back in `_convert_to_indices`. Reviewed By: apsdehal Differential Revision: D28025537 fbshipit-source-id: 24b4dbe1118734f7bb5942d2e3deba190fac9698 04 May 2021, 07:02:00 UTC
8a01258 [fix] multinode jobs after recent lightning update (#921) Summary: After Sasha's update of pytorch lightning on MMF master, it broke MMF codebase for multinode job. The root problem to PR https://github.com/PyTorchLightning/pytorch-lightning/pull/6802. The assumption that SLURM_PROCID points to worker rank is wrong as some frameworks launch their own processes later using multiprocessing spawn and have ntasks_per_node=1 set. This means that first node will have procid = 0, second node will have procid = 1 set and so on. Now, since this is used in prepare_data masking in LightningDataModule, this leads to it running on all workers on first node and thus causing inconsistencies. Now, this leads to prepare_data being called on all workers on first node instead of rank zero. Specifically, the barrier call in prepare_data, is called on first node workers but not on others leading to block later on. This PR fixes this by ensuring on our side that we only call prepare_data on rank zero. Furthermore, this can cause further confusion, we remove sync barrier calls from download as well. Users are now supposed to handle is_master checks on their own. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/921 Test Plan: Tested in multinode settings. Reviewed By: vedanuj Differential Revision: D28156855 Pulled By: apsdehal fbshipit-source-id: 4e0dd5317e15153f558d34c6951a89299602454f 03 May 2021, 22:31:47 UTC
1cc6b08 [feat] allow attribute prediction in UniT; fix UniT zoo ckpt yaml config (#910) Summary: - allow predicting attributes in Visual Genome detection -- run with `model_config.unit.predict_attributes=True` to write attributes into json prediction files - also fix the config.yaml files for the UniT checkpoints - visualizing predicted boxes and attributes: https://gist.github.com/ronghanghu/47053b7e58460d48986345fb9027b460#file-visualize_detection_vg_outputs_with_attr-ipynb Pull Request resolved: https://github.com/facebookresearch/mmf/pull/910 Test Plan: tested locally and verified attribute outputs Reviewed By: apsdehal Differential Revision: D28101483 Pulled By: ronghanghu fbshipit-source-id: f4db66c562d2867c473347e13db042cc9b0fd462 01 May 2021, 03:18:58 UTC
d30dad3 [mmf/debuggability] longer timeout on first batch (#919) Summary: Pull Request resolved: https://github.com/facebookresearch/mmf/pull/919 Timeout on first batch should be much longer, because workers might start at different times. Reviewed By: madian9 Differential Revision: D28122452 fbshipit-source-id: c076d80f8b75545f67ccc3656445ab159aaf3b46 30 April 2021, 20:27:15 UTC
9d8d89c [fix] pytorch lightning api change (#916) Summary: Recently, pytorch lightning internal in fbcode got updated to the recent master; My PR https://github.com/facebookresearch/mmf/issues/755 also updated OSS pytorch lightning dependency to master; This is to fix the original fix https://github.com/facebookresearch/mmf/issues/880 to use the most recent pytorch lightning api. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/916 Reviewed By: apsdehal Differential Revision: D28112996 Pulled By: ytsheng fbshipit-source-id: de462682ae0fcb98dd40c39ab5e61fe3dc77e338 30 April 2021, 16:59:16 UTC
08f062e [feat] Adds audio (resnet18) and video (r2plus1d18) encoders (#879) Summary: This PR adds support for audio and video modality encoders to MMF. These can be used in conjunction with MMFTransformer. An example config has been added to showcase the usage. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/879 Test Plan: Unit tests have been added. Reviewed By: ytsheng Differential Revision: D27804875 Pulled By: apsdehal fbshipit-source-id: 9f276dab2dc711fb8e5868a029f73c16083c1782 29 April 2021, 08:16:39 UTC
back to top