Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision 6407df5ca54a511054200a1eb23f78f723ca1de4 authored by Huang Ying on 08 May 2009, 02:51:41 UTC, committed by H. Peter Anvin on 08 May 2009, 05:01:05 UTC 
x86, kexec: fix crashdump panic with CONFIG_KEXEC_JUMP
 
Tim Starling reported that crashdump will panic with kernel compiled
with CONFIG_KEXEC_JUMP due to null pointer deference in
machine_kexec_32.c: machine_kexec(), when deferencing
kexec_image. Refering to:

http://bugzilla.kernel.org/show_bug.cgi?id=13265

This patch fixes the BUG via replacing global variable reference:
kexec_image in machine_kexec() with local variable reference: image,
which is more appropriate, and will not be null.

Same BUG is in machine_kexec_64.c too, so fixed too in the same way.

[ Impact: fix crash on kexec ]

Reported-by: Tim Starling <tstarling@wikimedia.org>
Signed-off-by: Huang Ying <ying.huang@intel.com>
LKML-Reference: <1241751101.6259.85.camel@yhuang-dev.sh.intel.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
1 parent 4983439
Raw File
Tip revision: 6407df5ca54a511054200a1eb23f78f723ca1de4 authored by Huang Ying on 08 May 2009, 02:51:41 UTC
x86, kexec: fix crashdump panic with CONFIG_KEXEC_JUMP
Tip revision: 6407df5
gcc-x86_32-has-stack-protector.sh 
#!/bin/sh

echo "int foo(void) { char X[200]; return 3; }" | $* -S -xc -c -O0 -fstack-protector - -o - 2> /dev/null | grep -q "%gs"
if [ "$?" -eq "0" ] ; then
	echo y
else
	echo n
fi
back to top