Revision 64897b20eed29cee2b998fb5ba362e65523dba3c authored by Rafael J. Wysocki on 21 March 2017, 21:19:07 UTC, committed by Rafael J. Wysocki on 21 March 2017, 21:19:07 UTC
The policy->cpuinfo.max_freq and policy->max updates in
intel_cpufreq_turbo_update() are excessive as they are done for no
good reason and may lead to problems in principle, so they should be
dropped.  However, after dropping them intel_cpufreq_turbo_update()
becomes almost entirely pointless, because the check made by it is
made again down the road in intel_pstate_prepare_request().  The
only thing in it that still needs to be done is the call to
update_turbo_state(), so drop intel_cpufreq_turbo_update() altogether
and make its callers invoke update_turbo_state() directly instead of
it.

In addition to that, fix intel_cpufreq_verify_policy() so that it
checks global.no_turbo in addition to global.turbo_disabled when
updating policy->cpuinfo.max_freq to make it consistent with
intel_pstate_verify_policy().

Fixes: 001c76f05b01 (cpufreq: intel_pstate: Generic governors support)
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 7de3255
History
File Mode Size
Makefile -rw-r--r-- 293 bytes
arraymap.c -rw-r--r-- 14.3 KB
bpf_lru_list.c -rw-r--r-- 17.5 KB
bpf_lru_list.h -rw-r--r-- 2.2 KB
cgroup.c -rw-r--r-- 6.6 KB
core.c -rw-r--r-- 36.3 KB
hashtab.c -rw-r--r-- 28.1 KB
helpers.c -rw-r--r-- 4.5 KB
inode.c -rw-r--r-- 9.6 KB
lpm_trie.c -rw-r--r-- 14.6 KB
percpu_freelist.c -rw-r--r-- 2.2 KB
percpu_freelist.h -rw-r--r-- 929 bytes
stackmap.c -rw-r--r-- 7.3 KB
syscall.c -rw-r--r-- 24.5 KB
verifier.c -rw-r--r-- 96.4 KB

back to top