Revision 64897b20eed29cee2b998fb5ba362e65523dba3c authored by Rafael J. Wysocki on 21 March 2017, 21:19:07 UTC, committed by Rafael J. Wysocki on 21 March 2017, 21:19:07 UTC
The policy->cpuinfo.max_freq and policy->max updates in
intel_cpufreq_turbo_update() are excessive as they are done for no
good reason and may lead to problems in principle, so they should be
dropped.  However, after dropping them intel_cpufreq_turbo_update()
becomes almost entirely pointless, because the check made by it is
made again down the road in intel_pstate_prepare_request().  The
only thing in it that still needs to be done is the call to
update_turbo_state(), so drop intel_cpufreq_turbo_update() altogether
and make its callers invoke update_turbo_state() directly instead of
it.

In addition to that, fix intel_cpufreq_verify_policy() so that it
checks global.no_turbo in addition to global.turbo_disabled when
updating policy->cpuinfo.max_freq to make it consistent with
intel_pstate_verify_policy().

Fixes: 001c76f05b01 (cpufreq: intel_pstate: Generic governors support)
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 7de3255
History
File Mode Size
Makefile -rw-r--r-- 1.2 KB
autogroup.c -rw-r--r-- 6.5 KB
autogroup.h -rw-r--r-- 1.5 KB
clock.c -rw-r--r-- 10.2 KB
completion.c -rw-r--r-- 9.7 KB
core.c -rw-r--r-- 178.8 KB
cpuacct.c -rw-r--r-- 8.3 KB
cpuacct.h -rw-r--r-- 359 bytes
cpudeadline.c -rw-r--r-- 6.1 KB
cpudeadline.h -rw-r--r-- 733 bytes
cpufreq.c -rw-r--r-- 2.2 KB
cpufreq_schedutil.c -rw-r--r-- 16.8 KB
cpupri.c -rw-r--r-- 6.8 KB
cpupri.h -rw-r--r-- 674 bytes
cputime.c -rw-r--r-- 21.6 KB
deadline.c -rw-r--r-- 45.9 KB
debug.c -rw-r--r-- 23.1 KB
fair.c -rw-r--r-- 248.5 KB
features.h -rw-r--r-- 2.0 KB
idle.c -rw-r--r-- 8.5 KB
idle_task.c -rw-r--r-- 2.3 KB
loadavg.c -rw-r--r-- 11.1 KB
rt.c -rw-r--r-- 54.3 KB
sched.h -rw-r--r-- 50.2 KB
stats.c -rw-r--r-- 3.2 KB
stats.h -rw-r--r-- 5.0 KB
stop_task.c -rw-r--r-- 2.9 KB
swait.c -rw-r--r-- 2.9 KB
topology.c -rw-r--r-- 39.4 KB
wait.c -rw-r--r-- 18.3 KB

back to top