Revision 6573773339b47b2e255df1e274788257aa50ad92 authored by Morten Stenshorne on 14 March 2018, 06:40:47 UTC, committed by Blink WPT Bot on 14 March 2018, 06:48:02 UTC
We cannot use the content size (intrinsic block size) as min-height or max-height (min-width or max-width, if writing mode is vertical). Doing so would cause min-height to incorrectly override any specified height or max-height that is less than the intrinsic block size, and max-height to override any specified height that's greater than the intrinsic block size. Do what the spec says [1] instead: max-height to become 'none', and min-height to become 0. This fixes the final rendering problem with Acid2 (this was about the min-height issue). It now renders correctly with LayoutNG! Since no other tests than Acid2 started to pass with this change, I wrote a couple. [1] https://www.w3.org/TR/CSS22/visudet.html#min-max-heights XXXXXX XX XX X X X O O X X X X /\ X X \/ X X X X X X X X XXXXXXXX X X X XX XX XXXXXX Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic4f2c3c1dbc2bd66956ed4b270b08058999bc351 Reviewed-on: https://chromium-review.googlesource.com/960085 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#543018}
1 parent 07b4a27
Computing file changes ...