Skip to main content

Browse the archive

Revision 66218da212bf141532d678a699f5789c78145ab1 authored by Atsushi Nemoto on 24 January 2007, 06:43:34 UTC, committed by Ralf Baechle on 24 January 2007, 19:23:22 UTC 
[MIPS] Fix wrong checksum calculation on 64-bit MIPS
 
The commit 8e3d8433d8c22ca6c42cba4a67d300c39aae7822 ([NET]: MIPS
checksum annotations and cleanups) broke 64-bit MIPS.

The problem is the commit replaces some unsigned long with __be32.  On
64bit MIPS, a __be32 (i.e. unsigned int) value is represented as a
sign-extented 32-bit value in a 64-bit argument register.  So the
address 192.168.0.1 (0xc0a80001) is passed as 0xffffffffc0a80001 to
csum_tcpudp_nofold() but the asm code in the function expects
0x00000000c0a80001, therefore it returns a wrong checksum.  Explicit
cast to unsigned long is needed to drop high 32bit.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
1 parent 9cfdf6f
Raw File
msgbuf.h 
#ifndef _ASM_MSGBUF_H
#define _ASM_MSGBUF_H

/*
 * The msqid64_ds structure for FR-V architecture.
 * Note extra padding because this structure is passed back and forth
 * between kernel and user space.
 *
 * Pad space is left for:
 * - 64-bit time_t to solve y2038 problem
 * - 2 miscellaneous 32-bit values
 */

struct msqid64_ds {
	struct ipc64_perm	msg_perm;
	__kernel_time_t		msg_stime;	/* last msgsnd time */
	unsigned long		__unused1;
	__kernel_time_t		msg_rtime;	/* last msgrcv time */
	unsigned long		__unused2;
	__kernel_time_t		msg_ctime;	/* last change time */
	unsigned long		__unused3;
	unsigned long		msg_cbytes;	/* current number of bytes on queue */
	unsigned long		msg_qnum;	/* number of messages in queue */
	unsigned long		msg_qbytes;	/* max number of bytes on queue */
	__kernel_pid_t		msg_lspid;	/* pid of last msgsnd */
	__kernel_pid_t		msg_lrpid;	/* last receive pid */
	unsigned long		__unused4;
	unsigned long		__unused5;
};

#endif /* _ASM_MSGBUF_H */
back to top