Revision 666ad1df2dc5b181a40d831c125529fe7e9bf0b4 authored by Brad King on 24 February 2017, 15:07:18 UTC, committed by Brad King on 24 February 2017, 15:15:50 UTC
This reverts commit v3.7.0-rc1~275^2 (Ninja: Use full path for all
source files, 2016-08-05).  Unfortunately using absolute paths can
cause incorrect rebuilds due to ninja limitations.  The ninja
manual [1] explains:

> ... using absolute paths, your depfile may result in a mixture of
> relative and absolute paths. Paths used by other build rules need
> to match exactly.

Passing an absolute path to a source file to the compiler while using a
relative path in the ninja build manifest can cause such mixture and
lead to incorrect rebuilds.  Simply revert the change for now.

Note that there was a follow-up to the original change in commit
v3.7.0-rc2~10^2 (Ninja: Fix RC language depfile generation with
cmcldeps, 2016-10-13).  We don't need to revert that because that
change made the relevant code cleverly adapt to whatever variable
we use to reference the source file.

[1] https://ninja-build.org/manual.html#_deps

Fixes: #16675
Issue: #13894
1 parent efac65d
History
File Mode Size
ABSTRACT.rst -rw-r--r-- 309 bytes
AUTORCC_OPTIONS.rst -rw-r--r-- 477 bytes
AUTOUIC_OPTIONS.rst -rw-r--r-- 470 bytes
COMPILE_DEFINITIONS.rst -rw-r--r-- 836 bytes
COMPILE_DEFINITIONS_CONFIG.rst -rw-r--r-- 361 bytes
COMPILE_FLAGS.rst -rw-r--r-- 258 bytes
EXTERNAL_OBJECT.rst -rw-r--r-- 233 bytes
Fortran_FORMAT.rst -rw-r--r-- 363 bytes
GENERATED.rst -rw-r--r-- 271 bytes
HEADER_FILE_ONLY.rst -rw-r--r-- 333 bytes
KEEP_EXTENSION.rst -rw-r--r-- 343 bytes
LABELS.rst -rw-r--r-- 231 bytes
LANGUAGE.rst -rw-r--r-- 384 bytes
LOCATION.rst -rw-r--r-- 138 bytes
MACOSX_PACKAGE_LOCATION.rst -rw-r--r-- 1.2 KB
OBJECT_DEPENDS.rst -rw-r--r-- 1.1 KB
OBJECT_OUTPUTS.rst -rw-r--r-- 290 bytes
SYMBOLIC.rst -rw-r--r-- 230 bytes
VS_DEPLOYMENT_CONTENT.rst -rw-r--r-- 521 bytes
VS_DEPLOYMENT_LOCATION.rst -rw-r--r-- 370 bytes
VS_SHADER_ENTRYPOINT.rst -rw-r--r-- 124 bytes
VS_SHADER_FLAGS.rst -rw-r--r-- 92 bytes
VS_SHADER_MODEL.rst -rw-r--r-- 149 bytes
VS_SHADER_TYPE.rst -rw-r--r-- 82 bytes
VS_TOOL_OVERRIDE.rst -rw-r--r-- 171 bytes
VS_XAML_TYPE.rst -rw-r--r-- 188 bytes
WRAP_EXCLUDE.rst -rw-r--r-- 364 bytes
XCODE_EXPLICIT_FILE_TYPE.rst -rw-r--r-- 277 bytes
XCODE_FILE_ATTRIBUTES.rst -rw-r--r-- 306 bytes
XCODE_LAST_KNOWN_FILE_TYPE.rst -rw-r--r-- 326 bytes

back to top