Revision 666ad1df2dc5b181a40d831c125529fe7e9bf0b4 authored by Brad King on 24 February 2017, 15:07:18 UTC, committed by Brad King on 24 February 2017, 15:15:50 UTC
This reverts commit v3.7.0-rc1~275^2 (Ninja: Use full path for all source files, 2016-08-05). Unfortunately using absolute paths can cause incorrect rebuilds due to ninja limitations. The ninja manual [1] explains: > ... using absolute paths, your depfile may result in a mixture of > relative and absolute paths. Paths used by other build rules need > to match exactly. Passing an absolute path to a source file to the compiler while using a relative path in the ninja build manifest can cause such mixture and lead to incorrect rebuilds. Simply revert the change for now. Note that there was a follow-up to the original change in commit v3.7.0-rc2~10^2 (Ninja: Fix RC language depfile generation with cmcldeps, 2016-10-13). We don't need to revert that because that change made the relevant code cleverly adapt to whatever variable we use to reference the source file. [1] https://ninja-build.org/manual.html#_deps Fixes: #16675 Issue: #13894
1 parent efac65d
| File | Mode | Size |
|---|---|---|
| ATTACHED_FILES.rst | -rw-r--r-- | 206 bytes |
| ATTACHED_FILES_ON_FAIL.rst | -rw-r--r-- | 218 bytes |
| COST.rst | -rw-r--r-- | 235 bytes |
| DEPENDS.rst | -rw-r--r-- | 467 bytes |
| ENVIRONMENT.rst | -rw-r--r-- | 319 bytes |
| FAIL_REGULAR_EXPRESSION.rst | -rw-r--r-- | 406 bytes |
| FIXTURES_CLEANUP.rst | -rw-r--r-- | 1.7 KB |
| FIXTURES_REQUIRED.rst | -rw-r--r-- | 4.6 KB |
| FIXTURES_SETUP.rst | -rw-r--r-- | 1.7 KB |
| LABELS.rst | -rw-r--r-- | 117 bytes |
| MEASUREMENT.rst | -rw-r--r-- | 268 bytes |
| PASS_REGULAR_EXPRESSION.rst | -rw-r--r-- | 483 bytes |
| PROCESSORS.rst | -rw-r--r-- | 244 bytes |
| REQUIRED_FILES.rst | -rw-r--r-- | 155 bytes |
| RESOURCE_LOCK.rst | -rw-r--r-- | 277 bytes |
| RUN_SERIAL.rst | -rw-r--r-- | 229 bytes |
| SKIP_RETURN_CODE.rst | -rw-r--r-- | 325 bytes |
| TIMEOUT.rst | -rw-r--r-- | 318 bytes |
| TIMEOUT_AFTER_MATCH.rst | -rw-r--r-- | 1.3 KB |
| WILL_FAIL.rst | -rw-r--r-- | 184 bytes |
| WORKING_DIRECTORY.rst | -rw-r--r-- | 185 bytes |
Computing file changes ...
