Revision 666ad1df2dc5b181a40d831c125529fe7e9bf0b4 authored by Brad King on 24 February 2017, 15:07:18 UTC, committed by Brad King on 24 February 2017, 15:15:50 UTC
This reverts commit v3.7.0-rc1~275^2 (Ninja: Use full path for all
source files, 2016-08-05).  Unfortunately using absolute paths can
cause incorrect rebuilds due to ninja limitations.  The ninja
manual [1] explains:

> ... using absolute paths, your depfile may result in a mixture of
> relative and absolute paths. Paths used by other build rules need
> to match exactly.

Passing an absolute path to a source file to the compiler while using a
relative path in the ninja build manifest can cause such mixture and
lead to incorrect rebuilds.  Simply revert the change for now.

Note that there was a follow-up to the original change in commit
v3.7.0-rc2~10^2 (Ninja: Fix RC language depfile generation with
cmcldeps, 2016-10-13).  We don't need to revert that because that
change made the relevant code cleverly adapt to whatever variable
we use to reference the source file.

[1] https://ninja-build.org/manual.html#_deps

Fixes: #16675
Issue: #13894
1 parent efac65d
History
File Mode Size
BadInvalidName1-result.txt -rw-r--r-- 2 bytes
BadInvalidName1-stderr.txt -rw-r--r-- 265 bytes
BadInvalidName1.cmake -rw-r--r-- 283 bytes
BadInvalidName2-result.txt -rw-r--r-- 2 bytes
BadInvalidName2-stderr.txt -rw-r--r-- 281 bytes
BadInvalidName2.cmake -rw-r--r-- 280 bytes
BadInvalidName3-result.txt -rw-r--r-- 2 bytes
BadInvalidName3-stderr.txt -rw-r--r-- 250 bytes
BadInvalidName3.cmake -rw-r--r-- 265 bytes
BadInvalidName4-result.txt -rw-r--r-- 2 bytes
BadInvalidName4-stderr.txt -rw-r--r-- 254 bytes
BadInvalidName4.cmake -rw-r--r-- 329 bytes
BadInvalidName5-result.txt -rw-r--r-- 2 bytes
BadInvalidName5-stderr.txt -rw-r--r-- 300 bytes
BadInvalidName5.cmake -rw-r--r-- 250 bytes
BadInvalidName6-result.txt -rw-r--r-- 2 bytes
BadInvalidName6-stderr.txt -rw-r--r-- 293 bytes
BadInvalidName6.cmake -rw-r--r-- 263 bytes
BadInvalidName7-result.txt -rw-r--r-- 2 bytes
BadInvalidName7-stderr.txt -rw-r--r-- 280 bytes
BadInvalidName7.cmake -rw-r--r-- 313 bytes
BadInvalidName8-result.txt -rw-r--r-- 2 bytes
BadInvalidName8-stderr.txt -rw-r--r-- 276 bytes
BadInvalidName8.cmake -rw-r--r-- 249 bytes
BadNonTarget-result.txt -rw-r--r-- 2 bytes
BadNonTarget-stderr.txt -rw-r--r-- 265 bytes
BadNonTarget.cmake -rw-r--r-- 280 bytes
BadSelfReference1-result.txt -rw-r--r-- 2 bytes
BadSelfReference1-stderr.txt -rw-r--r-- 165 bytes
BadSelfReference1.cmake -rw-r--r-- 268 bytes
BadSelfReference2-result.txt -rw-r--r-- 2 bytes
BadSelfReference2-stderr.txt -rw-r--r-- 165 bytes
BadSelfReference2.cmake -rw-r--r-- 335 bytes
BadSelfReference3-result.txt -rw-r--r-- 2 bytes
BadSelfReference3-stderr.txt -rw-r--r-- 200 bytes
BadSelfReference3.cmake -rw-r--r-- 306 bytes
BadSelfReference4-result.txt -rw-r--r-- 2 bytes
BadSelfReference4-stderr.txt -rw-r--r-- 200 bytes
BadSelfReference4.cmake -rw-r--r-- 370 bytes
BadSelfReference5-result.txt -rw-r--r-- 2 bytes
BadSelfReference5-stderr.txt -rw-r--r-- 165 bytes
BadSelfReference5.cmake -rw-r--r-- 335 bytes
BadSelfReference6-result.txt -rw-r--r-- 2 bytes
BadSelfReference6-stderr.txt -rw-r--r-- 200 bytes
BadSelfReference6.cmake -rw-r--r-- 370 bytes
CMakeLists.txt -rw-r--r-- 215 bytes
LinkImplementationCycle1-result.txt -rw-r--r-- 2 bytes
LinkImplementationCycle1-stderr.txt -rw-r--r-- 396 bytes
LinkImplementationCycle1.cmake -rw-r--r-- 181 bytes
LinkImplementationCycle2-result.txt -rw-r--r-- 2 bytes
LinkImplementationCycle2-stderr.txt -rw-r--r-- 406 bytes
LinkImplementationCycle2.cmake -rw-r--r-- 191 bytes
LinkImplementationCycle3-result.txt -rw-r--r-- 2 bytes
LinkImplementationCycle3.cmake -rw-r--r-- 302 bytes
LinkImplementationCycle4-result.txt -rw-r--r-- 2 bytes
LinkImplementationCycle4-stderr.txt -rw-r--r-- 274 bytes
LinkImplementationCycle4.cmake -rw-r--r-- 430 bytes
LinkImplementationCycle5-result.txt -rw-r--r-- 2 bytes
LinkImplementationCycle5-stderr.txt -rw-r--r-- 274 bytes
LinkImplementationCycle5.cmake -rw-r--r-- 293 bytes
LinkImplementationCycle6-result.txt -rw-r--r-- 2 bytes
LinkImplementationCycle6-stderr.txt -rw-r--r-- 274 bytes
LinkImplementationCycle6.cmake -rw-r--r-- 451 bytes
RunCMakeTest.cmake -rw-r--r-- 649 bytes
empty.cpp -rw-r--r-- 73 bytes

back to top