Revision 666ad1df2dc5b181a40d831c125529fe7e9bf0b4 authored by Brad King on 24 February 2017, 15:07:18 UTC, committed by Brad King on 24 February 2017, 15:15:50 UTC
This reverts commit v3.7.0-rc1~275^2 (Ninja: Use full path for all source files, 2016-08-05). Unfortunately using absolute paths can cause incorrect rebuilds due to ninja limitations. The ninja manual [1] explains: > ... using absolute paths, your depfile may result in a mixture of > relative and absolute paths. Paths used by other build rules need > to match exactly. Passing an absolute path to a source file to the compiler while using a relative path in the ninja build manifest can cause such mixture and lead to incorrect rebuilds. Simply revert the change for now. Note that there was a follow-up to the original change in commit v3.7.0-rc2~10^2 (Ninja: Fix RC language depfile generation with cmcldeps, 2016-10-13). We don't need to revert that because that change made the relevant code cleverly adapt to whatever variable we use to reference the source file. [1] https://ninja-build.org/manual.html#_deps Fixes: #16675 Issue: #13894
1 parent efac65d
File | Mode | Size |
---|---|---|
BadTargetName-result.txt | -rw-r--r-- | 2 bytes |
BadTargetName-stderr.txt | -rw-r--r-- | 682 bytes |
BadTargetName.cmake | -rw-r--r-- | 69 bytes |
ByproductsNoCommand-result.txt | -rw-r--r-- | 2 bytes |
ByproductsNoCommand-stderr.txt | -rw-r--r-- | 190 bytes |
ByproductsNoCommand.cmake | -rw-r--r-- | 47 bytes |
CMakeLists.txt | -rw-r--r-- | 99 bytes |
NoArguments-result.txt | -rw-r--r-- | 2 bytes |
NoArguments-stderr.txt | -rw-r--r-- | 190 bytes |
NoArguments.cmake | -rw-r--r-- | 20 bytes |
RunCMakeTest.cmake | -rw-r--r-- | 653 bytes |
TargetOrder.cmake | -rw-r--r-- | 1.2 KB |
UsesTerminalNoCommand-result.txt | -rw-r--r-- | 2 bytes |
UsesTerminalNoCommand-stderr.txt | -rw-r--r-- | 195 bytes |
UsesTerminalNoCommand.cmake | -rw-r--r-- | 42 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...