Revision 666ad1df2dc5b181a40d831c125529fe7e9bf0b4 authored by Brad King on 24 February 2017, 15:07:18 UTC, committed by Brad King on 24 February 2017, 15:15:50 UTC
This reverts commit v3.7.0-rc1~275^2 (Ninja: Use full path for all source files, 2016-08-05). Unfortunately using absolute paths can cause incorrect rebuilds due to ninja limitations. The ninja manual [1] explains: > ... using absolute paths, your depfile may result in a mixture of > relative and absolute paths. Paths used by other build rules need > to match exactly. Passing an absolute path to a source file to the compiler while using a relative path in the ninja build manifest can cause such mixture and lead to incorrect rebuilds. Simply revert the change for now. Note that there was a follow-up to the original change in commit v3.7.0-rc2~10^2 (Ninja: Fix RC language depfile generation with cmcldeps, 2016-10-13). We don't need to revert that because that change made the relevant code cleverly adapt to whatever variable we use to reference the source file. [1] https://ninja-build.org/manual.html#_deps Fixes: #16675 Issue: #13894
1 parent efac65d
File | Mode | Size |
---|---|---|
CMakeLists.txt.in | -rw-r--r-- | 184 bytes |
CTestConfig.cmake.in | -rw-r--r-- | 47 bytes |
CTestTestLoadFail-result.txt | -rw-r--r-- | 9 bytes |
CTestTestLoadFail-stderr.txt | -rw-r--r-- | 23 bytes |
CTestTestLoadFail-stdout.txt | -rw-r--r-- | 175 bytes |
CTestTestLoadInvalid-stderr.txt | -rw-r--r-- | 44 bytes |
CTestTestLoadInvalid-stdout.txt | -rw-r--r-- | 256 bytes |
CTestTestLoadPass-stdout.txt | -rw-r--r-- | 253 bytes |
RunCMakeTest.cmake | -rw-r--r-- | 2.2 KB |
TestChangeId-check.cmake | -rw-r--r-- | 427 bytes |
TestLoadFail-result.txt | -rw-r--r-- | 9 bytes |
TestLoadFail-stderr.txt | -rw-r--r-- | 23 bytes |
TestLoadFail-stdout.txt | -rw-r--r-- | 170 bytes |
TestLoadInvalid-stderr.txt | -rw-r--r-- | 38 bytes |
TestLoadInvalid-stdout.txt | -rw-r--r-- | 251 bytes |
TestLoadOrder-stderr.txt | -rw-r--r-- | 38 bytes |
TestLoadOrder-stdout.txt | -rw-r--r-- | 249 bytes |
TestLoadPass-stdout.txt | -rw-r--r-- | 248 bytes |
TestOutputSize-check.cmake | -rw-r--r-- | 887 bytes |
TestQuiet-stdout.txt | -rw-r--r-- | 52 bytes |
test.cmake.in | -rw-r--r-- | 811 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...