Revision 666ad1df2dc5b181a40d831c125529fe7e9bf0b4 authored by Brad King on 24 February 2017, 15:07:18 UTC, committed by Brad King on 24 February 2017, 15:15:50 UTC
This reverts commit v3.7.0-rc1~275^2 (Ninja: Use full path for all
source files, 2016-08-05).  Unfortunately using absolute paths can
cause incorrect rebuilds due to ninja limitations.  The ninja
manual [1] explains:

> ... using absolute paths, your depfile may result in a mixture of
> relative and absolute paths. Paths used by other build rules need
> to match exactly.

Passing an absolute path to a source file to the compiler while using a
relative path in the ninja build manifest can cause such mixture and
lead to incorrect rebuilds.  Simply revert the change for now.

Note that there was a follow-up to the original change in commit
v3.7.0-rc2~10^2 (Ninja: Fix RC language depfile generation with
cmcldeps, 2016-10-13).  We don't need to revert that because that
change made the relevant code cleverly adapt to whatever variable
we use to reference the source file.

[1] https://ninja-build.org/manual.html#_deps

Fixes: #16675
Issue: #13894
1 parent efac65d
History
File Mode Size
CMakeLists.txt -rw-r--r-- 101 bytes
EmptyFilterRegex-result.txt -rw-r--r-- 2 bytes
EmptyFilterRegex-stderr.txt -rw-r--r-- 0 bytes
EmptyFilterRegex.cmake -rw-r--r-- 67 bytes
EmptyGet0-result.txt -rw-r--r-- 2 bytes
EmptyGet0-stderr.txt -rw-r--r-- 142 bytes
EmptyGet0.cmake -rw-r--r-- 41 bytes
EmptyInsert-1-result.txt -rw-r--r-- 2 bytes
EmptyInsert-1-stderr.txt -rw-r--r-- 157 bytes
EmptyInsert-1.cmake -rw-r--r-- 40 bytes
EmptyRemoveAt0-result.txt -rw-r--r-- 2 bytes
EmptyRemoveAt0-stderr.txt -rw-r--r-- 153 bytes
EmptyRemoveAt0.cmake -rw-r--r-- 40 bytes
FILTER-NotList-result.txt -rw-r--r-- 2 bytes
FILTER-NotList-stderr.txt -rw-r--r-- 175 bytes
FILTER-NotList.cmake -rw-r--r-- 74 bytes
FILTER-REGEX-InvalidMode-result.txt -rw-r--r-- 2 bytes
FILTER-REGEX-InvalidMode-stderr.txt -rw-r--r-- 185 bytes
FILTER-REGEX-InvalidMode.cmake -rw-r--r-- 129 bytes
FILTER-REGEX-InvalidOperator-result.txt -rw-r--r-- 2 bytes
FILTER-REGEX-InvalidOperator-stderr.txt -rw-r--r-- 191 bytes
FILTER-REGEX-InvalidOperator.cmake -rw-r--r-- 125 bytes
FILTER-REGEX-InvalidRegex-result.txt -rw-r--r-- 2 bytes
FILTER-REGEX-InvalidRegex-stderr.txt -rw-r--r-- 206 bytes
FILTER-REGEX-InvalidRegex.cmake -rw-r--r-- 122 bytes
FILTER-REGEX-TooManyArguments-result.txt -rw-r--r-- 2 bytes
FILTER-REGEX-TooManyArguments-stderr.txt -rw-r--r-- 198 bytes
FILTER-REGEX-TooManyArguments.cmake -rw-r--r-- 143 bytes
FILTER-REGEX-Valid0-result.txt -rw-r--r-- 2 bytes
FILTER-REGEX-Valid0-stderr.txt -rw-r--r-- 123 bytes
FILTER-REGEX-Valid0.cmake -rw-r--r-- 195 bytes
FILTER-REGEX-Valid1-result.txt -rw-r--r-- 2 bytes
FILTER-REGEX-Valid1-stderr.txt -rw-r--r-- 125 bytes
FILTER-REGEX-Valid1.cmake -rw-r--r-- 195 bytes
GET-CMP0007-WARN-stderr.txt -rw-r--r-- 445 bytes
GET-CMP0007-WARN.cmake -rw-r--r-- 198 bytes
GET-InvalidIndex-result.txt -rw-r--r-- 2 bytes
GET-InvalidIndex-stderr.txt -rw-r--r-- 161 bytes
GET-InvalidIndex.cmake -rw-r--r-- 58 bytes
INSERT-InvalidIndex-result.txt -rw-r--r-- 2 bytes
INSERT-InvalidIndex-stderr.txt -rw-r--r-- 164 bytes
INSERT-InvalidIndex.cmake -rw-r--r-- 60 bytes
InvalidSubcommand-result.txt -rw-r--r-- 2 bytes
InvalidSubcommand-stderr.txt -rw-r--r-- 180 bytes
InvalidSubcommand.cmake -rw-r--r-- 32 bytes
LENGTH-TooManyArguments-result.txt -rw-r--r-- 2 bytes
LENGTH-TooManyArguments-stderr.txt -rw-r--r-- 179 bytes
LENGTH-TooManyArguments.cmake -rw-r--r-- 40 bytes
NoArguments-result.txt -rw-r--r-- 2 bytes
NoArguments-stderr.txt -rw-r--r-- 168 bytes
NoArguments.cmake -rw-r--r-- 7 bytes
REMOVE_AT-InvalidIndex-result.txt -rw-r--r-- 2 bytes
REMOVE_AT-InvalidIndex-stderr.txt -rw-r--r-- 167 bytes
REMOVE_AT-InvalidIndex.cmake -rw-r--r-- 57 bytes
REMOVE_AT-NotList-result.txt -rw-r--r-- 2 bytes
REMOVE_AT-NotList-stderr.txt -rw-r--r-- 181 bytes
REMOVE_AT-NotList.cmake -rw-r--r-- 47 bytes
REMOVE_DUPLICATES-NotList-result.txt -rw-r--r-- 2 bytes
REMOVE_DUPLICATES-NotList-stderr.txt -rw-r--r-- 197 bytes
REMOVE_DUPLICATES-NotList.cmake -rw-r--r-- 53 bytes
REMOVE_DUPLICATES-TooManyArguments-result.txt -rw-r--r-- 2 bytes
REMOVE_DUPLICATES-TooManyArguments-stderr.txt -rw-r--r-- 202 bytes
REMOVE_DUPLICATES-TooManyArguments.cmake -rw-r--r-- 44 bytes
REMOVE_ITEM-NotList-result.txt -rw-r--r-- 2 bytes
REMOVE_ITEM-NotList-stderr.txt -rw-r--r-- 185 bytes
REMOVE_ITEM-NotList.cmake -rw-r--r-- 53 bytes
REVERSE-NotList-result.txt -rw-r--r-- 2 bytes
REVERSE-NotList-stderr.txt -rw-r--r-- 177 bytes
REVERSE-NotList.cmake -rw-r--r-- 43 bytes
REVERSE-TooManyArguments-result.txt -rw-r--r-- 2 bytes
REVERSE-TooManyArguments-stderr.txt -rw-r--r-- 182 bytes
REVERSE-TooManyArguments.cmake -rw-r--r-- 34 bytes
RunCMakeTest.cmake -rw-r--r-- 837 bytes
SORT-NotList-result.txt -rw-r--r-- 2 bytes
SORT-NotList-stderr.txt -rw-r--r-- 171 bytes
SORT-NotList.cmake -rw-r--r-- 40 bytes
SORT-TooManyArguments-result.txt -rw-r--r-- 2 bytes
SORT-TooManyArguments-stderr.txt -rw-r--r-- 176 bytes
SORT-TooManyArguments.cmake -rw-r--r-- 31 bytes

back to top