Revision 666ad1df2dc5b181a40d831c125529fe7e9bf0b4 authored by Brad King on 24 February 2017, 15:07:18 UTC, committed by Brad King on 24 February 2017, 15:15:50 UTC
This reverts commit v3.7.0-rc1~275^2 (Ninja: Use full path for all source files, 2016-08-05). Unfortunately using absolute paths can cause incorrect rebuilds due to ninja limitations. The ninja manual [1] explains: > ... using absolute paths, your depfile may result in a mixture of > relative and absolute paths. Paths used by other build rules need > to match exactly. Passing an absolute path to a source file to the compiler while using a relative path in the ninja build manifest can cause such mixture and lead to incorrect rebuilds. Simply revert the change for now. Note that there was a follow-up to the original change in commit v3.7.0-rc2~10^2 (Ninja: Fix RC language depfile generation with cmcldeps, 2016-10-13). We don't need to revert that because that change made the relevant code cleverly adapt to whatever variable we use to reference the source file. [1] https://ninja-build.org/manual.html#_deps Fixes: #16675 Issue: #13894
1 parent efac65d
File | Mode | Size |
---|---|---|
cmake | ||
subdir | ||
Append.cmake | -rw-r--r-- | 1.3 KB |
AppendNoArgs-result.txt | -rw-r--r-- | 2 bytes |
AppendNoArgs-stderr.txt | -rw-r--r-- | 178 bytes |
AppendNoArgs.cmake | -rw-r--r-- | 15 bytes |
CMakeLists.txt | -rw-r--r-- | 101 bytes |
Concat.cmake | -rw-r--r-- | 573 bytes |
ConcatNoArgs-result.txt | -rw-r--r-- | 2 bytes |
ConcatNoArgs-stderr.txt | -rw-r--r-- | 178 bytes |
ConcatNoArgs.cmake | -rw-r--r-- | 15 bytes |
RegexClear-stderr.txt | -rw-r--r-- | 1.5 KB |
RegexClear.cmake | -rw-r--r-- | 1.6 KB |
RunCMakeTest.cmake | -rw-r--r-- | 409 bytes |
UTF-16BE-stderr.txt | -rw-r--r-- | 24 bytes |
UTF-16BE.cmake | -rw-r--r-- | 150 bytes |
UTF-16BE.txt | -rw-r--r-- | 83 bytes |
UTF-16LE-stderr.txt | -rw-r--r-- | 24 bytes |
UTF-16LE.cmake | -rw-r--r-- | 150 bytes |
UTF-16LE.txt | -rw-r--r-- | 83 bytes |
UTF-32BE-stderr.txt | -rw-r--r-- | 24 bytes |
UTF-32BE.cmake | -rw-r--r-- | 150 bytes |
UTF-32BE.txt | -rw-r--r-- | 165 bytes |
UTF-32LE-stderr.txt | -rw-r--r-- | 24 bytes |
UTF-32LE.cmake | -rw-r--r-- | 150 bytes |
UTF-32LE.txt | -rw-r--r-- | 165 bytes |
Uuid.cmake | -rw-r--r-- | 660 bytes |
UuidBadNamespace-result.txt | -rw-r--r-- | 2 bytes |
UuidBadNamespace-stderr.txt | -rw-r--r-- | 175 bytes |
UuidBadNamespace.cmake | -rw-r--r-- | 164 bytes |
UuidBadType-result.txt | -rw-r--r-- | 2 bytes |
UuidBadType-stderr.txt | -rw-r--r-- | 164 bytes |
UuidBadType.cmake | -rw-r--r-- | 164 bytes |
UuidMissingNameValue-result.txt | -rw-r--r-- | 2 bytes |
UuidMissingNameValue-stderr.txt | -rw-r--r-- | 176 bytes |
UuidMissingNameValue.cmake | -rw-r--r-- | 148 bytes |
UuidMissingNamespace-result.txt | -rw-r--r-- | 2 bytes |
UuidMissingNamespace-stderr.txt | -rw-r--r-- | 179 bytes |
UuidMissingNamespace.cmake | -rw-r--r-- | 132 bytes |
UuidMissingNamespaceValue-result.txt | -rw-r--r-- | 2 bytes |
UuidMissingNamespaceValue-stderr.txt | -rw-r--r-- | 186 bytes |
UuidMissingNamespaceValue.cmake | -rw-r--r-- | 142 bytes |
UuidMissingTypeValue-result.txt | -rw-r--r-- | 2 bytes |
UuidMissingTypeValue-stderr.txt | -rw-r--r-- | 176 bytes |
UuidMissingTypeValue.cmake | -rw-r--r-- | 160 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...