swh:1:snp:17b06ab52d7de9edd56595cd5b03cce221cef5dc
Revision 666ad1df2dc5b181a40d831c125529fe7e9bf0b4 authored by Brad King on 24 February 2017, 15:07:18 UTC, committed by Brad King on 24 February 2017, 15:15:50 UTC
This reverts commit v3.7.0-rc1~275^2 (Ninja: Use full path for all
source files, 2016-08-05).  Unfortunately using absolute paths can
cause incorrect rebuilds due to ninja limitations.  The ninja
manual [1] explains:

> ... using absolute paths, your depfile may result in a mixture of
> relative and absolute paths. Paths used by other build rules need
> to match exactly.

Passing an absolute path to a source file to the compiler while using a
relative path in the ninja build manifest can cause such mixture and
lead to incorrect rebuilds.  Simply revert the change for now.

Note that there was a follow-up to the original change in commit
v3.7.0-rc2~10^2 (Ninja: Fix RC language depfile generation with
cmcldeps, 2016-10-13).  We don't need to revert that because that
change made the relevant code cleverly adapt to whatever variable
we use to reference the source file.

[1] https://ninja-build.org/manual.html#_deps

Fixes: #16675
Issue: #13894
1 parent efac65d
History
Tip revision: 1a315c55e3c934d1eead9842adaad66c0079ce5e authored by Brad King on 10 April 2024, 13:44:03 UTC
Merge topic 'genex-cleanup'
Tip revision: 1a315c5
File Mode Size
Auxiliary
Help
Licenses
Modules
Packaging
Source
Templates
Tests
Utilities
.clang-format -rw-r--r-- 217 bytes
.gitattributes -rw-r--r-- 658 bytes
.gitignore -rw-r--r-- 64 bytes
.hooks-config.bash -rw-r--r-- 435 bytes
CMakeCPack.cmake -rw-r--r-- 8.1 KB
CMakeCPackOptions.cmake.in -rw-r--r-- 12.8 KB
CMakeGraphVizOptions.cmake -rw-r--r-- 153 bytes
CMakeLists.txt -rw-r--r-- 29.1 KB
CMakeLogo.gif -rw-r--r-- 4.4 KB
CONTRIBUTING.rst -rw-r--r-- 1.7 KB
CTestConfig.cmake -rw-r--r-- 440 bytes
CTestCustom.cmake.in -rw-r--r-- 5.8 KB
CompileFlags.cmake -rw-r--r-- 2.9 KB
Copyright.txt -rw-r--r-- 4.8 KB
DartConfig.cmake -rw-r--r-- 374 bytes
README.rst -rw-r--r-- 2.9 KB
bootstrap -rwxr-xr-x 46.6 KB
cmake_uninstall.cmake.in -rw-r--r-- 790 bytes
configure -rwxr-xr-x 99 bytes
doxygen.config -rw-r--r-- 27.4 KB

README.rst

back to top