Revision 66cb3a2d7ad0d0e9af4d3430a4f2a32ffb9ac098 authored by David Arcari on 26 May 2022, 20:31:40 UTC, committed by Hans de Goede on 10 June 2022, 19:59:08 UTC
The probe function pmt_crashlog_probe() may incorrectly reference the 'priv->entry array' as it uses 'i' to reference the array instead of 'priv->num_entries' as it should. This is similar to the problem that was addressed in pmt_telemetry_probe via commit 2cdfa0c20d58 ("platform/x86/intel: Fix 'rmmod pmt_telemetry' panic"). Cc: "David E. Box" <david.e.box@linux.intel.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Mark Gross <markgross@kernel.org> Cc: linux-kernel@vger.kernel.org Signed-off-by: David Arcari <darcari@redhat.com> Reviewed-by: David E. Box <david.e.box@linux.intel.com> Link: https://lore.kernel.org/r/20220526203140.339120-1-darcari@redhat.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent b9c29f3
memcat_p.c
// SPDX-License-Identifier: GPL-2.0
#include <linux/slab.h>
/*
* Merge two NULL-terminated pointer arrays into a newly allocated
* array, which is also NULL-terminated. Nomenclature is inspired by
* memset_p() and memcat() found elsewhere in the kernel source tree.
*/
void **__memcat_p(void **a, void **b)
{
void **p = a, **new;
int nr;
/* count the elements in both arrays */
for (nr = 0, p = a; *p; nr++, p++)
;
for (p = b; *p; nr++, p++)
;
/* one for the NULL-terminator */
nr++;
new = kmalloc_array(nr, sizeof(void *), GFP_KERNEL);
if (!new)
return NULL;
/* nr -> last index; p points to NULL in b[] */
for (nr--; nr >= 0; nr--, p = p == b ? &a[nr] : p - 1)
new[nr] = *p;
return new;
}
EXPORT_SYMBOL_GPL(__memcat_p);
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...