https://github.com/Kitware/CMake
Revision 67b6f1a09b3e14373ba5683d11300a145c80877f authored by Daniel Scharrer on 05 September 2022, 21:42:28 UTC, committed by Brad King on 06 September 2022, 15:05:23 UTC
CMAKE_FIND_LIBRARY_PREFIXES and CMAKE_FIND_LIBRARY_SUFFIXES have
different behavior when undefined and when defined but empty:
Empty means to use an empty prefix/suffix while undefined means to
use a hardcoded default for the platform we are running on.
Unfortunately, set(a ${b}) will undefine a when b is empty,
meaning that when targeting a platform where either of these variables
is empty (e.g. Windows where CMAKE_FIND_LIBRARY_PREFIXES is empty)
the unpatched FindZLIB code ends up unsetting that variable, causing
all subsequent find_library calls to use the hardcoded default
for the runtime platform (e.g. "lib" for CMAKE_FIND_LIBRARY_PREFIXES
on Linux).
On the other hand, set(a "${b}") will always define a to be empty but
defined so we have to do this dance to fully preserve the state of these
variables.
1 parent 6dd6f91
Tip revision: 67b6f1a09b3e14373ba5683d11300a145c80877f authored by Daniel Scharrer on 05 September 2022, 21:42:28 UTC
FindZLIB: fix CMAKE_FIND_LIBRARY_PREFIXES being unset when it was empty
FindZLIB: fix CMAKE_FIND_LIBRARY_PREFIXES being unset when it was empty
Tip revision: 67b6f1a
| File | Mode | Size |
|---|---|---|
| .github | ||
| .gitlab | ||
| Auxiliary | ||
| Help | ||
| Licenses | ||
| Modules | ||
| Packaging | ||
| Source | ||
| Templates | ||
| Tests | ||
| Utilities | ||
| .clang-format | -rw-r--r-- | 1.4 KB |
| .clang-tidy | -rw-r--r-- | 1.3 KB |
| .codespellrc | -rw-r--r-- | 570 bytes |
| .editorconfig | -rw-r--r-- | 164 bytes |
| .gitattributes | -rw-r--r-- | 1.2 KB |
| .gitignore | -rw-r--r-- | 316 bytes |
| .gitlab-ci.yml | -rw-r--r-- | 28.6 KB |
| .hooks-config | -rw-r--r-- | 418 bytes |
| CMakeCPack.cmake | -rw-r--r-- | 9.8 KB |
| CMakeCPackOptions.cmake.in | -rw-r--r-- | 12.0 KB |
| CMakeGraphVizOptions.cmake | -rw-r--r-- | 153 bytes |
| CMakeLists.txt | -rw-r--r-- | 34.0 KB |
| CMakeLogo.gif | -rw-r--r-- | 4.4 KB |
| CONTRIBUTING.rst | -rw-r--r-- | 3.0 KB |
| CTestConfig.cmake | -rw-r--r-- | 566 bytes |
| CTestCustom.cmake.in | -rw-r--r-- | 6.8 KB |
| CompileFlags.cmake | -rw-r--r-- | 4.7 KB |
| Copyright.txt | -rw-r--r-- | 5.3 KB |
| DartConfig.cmake | -rw-r--r-- | 374 bytes |
| README.rst | -rw-r--r-- | 3.9 KB |
| bootstrap | -rwxr-xr-x | 63.2 KB |
| cmake_uninstall.cmake.in | -rw-r--r-- | 789 bytes |
| configure | -rwxr-xr-x | 99 bytes |
| doxygen.config | -rw-r--r-- | 27.4 KB |
Computing file changes ...
