https://github.com/torvalds/linux
Revision 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC, committed by Alex Deucher on 01 July 2019, 14:15:00 UTC
I'm not entirely sure why this is, but for some reason:

921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")

Breaks runtime PM resume on the Radeon PRO WX 3100 (Lexa) in one the
pre-production laptops I have. The issue manifests as the following
messages in dmesg:

[drm] UVD and UVD ENC initialized successfully.
amdgpu 0000:3b:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vce1 test failed (-110)
[drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <vce_v3_0> failed -110
[drm:amdgpu_device_resume [amdgpu]] *ERROR* amdgpu_device_ip_resume failed (-110).

And happens after about 6-10 runtime PM suspend/resume cycles (sometimes
sooner, if you're lucky!). Unfortunately I can't seem to pin down
precisely which part in psm_adjust_power_state_dynamic that is causing
the issue, but not skipping the display setting setup seems to fix it.
Hopefully if there is a better fix for this, this patch will spark
discussion around it.

Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")
Cc: Evan Quan <evan.quan@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Rex Zhu <Rex.Zhu@amd.com>
Cc: Likun Gao <Likun.Gao@amd.com>
Cc: <stable@vger.kernel.org> # v5.1+
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent f78c581
History
Tip revision: 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC
drm/amdgpu: Don't skip display settings in hwmgr_resume()
Tip revision: 688f3d1
File Mode Size
Marvell
Microchip
OMAP
SA1100
SH-Mobile
SPEAr
Samsung
Samsung-S3C24XX
VFP
keystone
nwfpe
pxa
sti
stm32
sunxi
Booting -rw-r--r-- 7.9 KB
IXP4xx -rw-r--r-- 6.3 KB
Interrupts -rw-r--r-- 6.6 KB
Netwinder -rw-r--r-- 1.5 KB
Porting -rw-r--r-- 4.4 KB
README -rw-r--r-- 7.6 KB
Setup -rw-r--r-- 3.5 KB
cluster-pm-race-avoidance.txt -rw-r--r-- 16.2 KB
firmware.txt -rw-r--r-- 2.2 KB
kernel_mode_neon.txt -rw-r--r-- 5.6 KB
kernel_user_helpers.txt -rw-r--r-- 6.6 KB
mem_alignment -rw-r--r-- 2.4 KB
memory.txt -rw-r--r-- 3.1 KB
swp_emulation -rw-r--r-- 1.2 KB
tcm.txt -rw-r--r-- 5.0 KB
uefi.txt -rw-r--r-- 2.9 KB
vlocks.txt -rw-r--r-- 6.6 KB

README

back to top