https://github.com/torvalds/linux
Revision 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC, committed by Alex Deucher on 01 July 2019, 14:15:00 UTC
I'm not entirely sure why this is, but for some reason:

921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")

Breaks runtime PM resume on the Radeon PRO WX 3100 (Lexa) in one the
pre-production laptops I have. The issue manifests as the following
messages in dmesg:

[drm] UVD and UVD ENC initialized successfully.
amdgpu 0000:3b:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vce1 test failed (-110)
[drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <vce_v3_0> failed -110
[drm:amdgpu_device_resume [amdgpu]] *ERROR* amdgpu_device_ip_resume failed (-110).

And happens after about 6-10 runtime PM suspend/resume cycles (sometimes
sooner, if you're lucky!). Unfortunately I can't seem to pin down
precisely which part in psm_adjust_power_state_dynamic that is causing
the issue, but not skipping the display setting setup seems to fix it.
Hopefully if there is a better fix for this, this patch will spark
discussion around it.

Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")
Cc: Evan Quan <evan.quan@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Rex Zhu <Rex.Zhu@amd.com>
Cc: Likun Gao <Likun.Gao@amd.com>
Cc: <stable@vger.kernel.org> # v5.1+
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent f78c581
History
Tip revision: 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC
drm/amdgpu: Don't skip display settings in hwmgr_resume()
Tip revision: 688f3d1
File Mode Size
powercap
regulator
apm-acpi.txt -rw-r--r-- 1.5 KB
basic-pm-debugging.txt -rw-r--r-- 11.9 KB
charger-manager.txt -rw-r--r-- 9.2 KB
drivers-testing.txt -rw-r--r-- 2.1 KB
energy-model.txt -rw-r--r-- 5.5 KB
freezing-of-tasks.txt -rw-r--r-- 12.0 KB
interface.txt -rw-r--r-- 3.5 KB
opp.txt -rw-r--r-- 13.5 KB
pci.txt -rw-r--r-- 56.3 KB
pm_qos_interface.txt -rw-r--r-- 9.7 KB
power_supply_class.txt -rw-r--r-- 9.9 KB
runtime_pm.txt -rw-r--r-- 44.5 KB
s2ram.txt -rw-r--r-- 3.3 KB
suspend-and-cpuhotplug.txt -rw-r--r-- 12.5 KB
suspend-and-interrupts.txt -rw-r--r-- 7.0 KB
swsusp-and-swap-files.txt -rw-r--r-- 2.7 KB
swsusp-dmcrypt.txt -rw-r--r-- 4.7 KB
swsusp.txt -rw-r--r-- 17.5 KB
tricks.txt -rw-r--r-- 753 bytes
userland-swsusp.txt -rw-r--r-- 8.4 KB
video.txt -rw-r--r-- 8.3 KB

back to top