https://github.com/torvalds/linux
Revision 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC, committed by Alex Deucher on 01 July 2019, 14:15:00 UTC
I'm not entirely sure why this is, but for some reason:

921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")

Breaks runtime PM resume on the Radeon PRO WX 3100 (Lexa) in one the
pre-production laptops I have. The issue manifests as the following
messages in dmesg:

[drm] UVD and UVD ENC initialized successfully.
amdgpu 0000:3b:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vce1 test failed (-110)
[drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <vce_v3_0> failed -110
[drm:amdgpu_device_resume [amdgpu]] *ERROR* amdgpu_device_ip_resume failed (-110).

And happens after about 6-10 runtime PM suspend/resume cycles (sometimes
sooner, if you're lucky!). Unfortunately I can't seem to pin down
precisely which part in psm_adjust_power_state_dynamic that is causing
the issue, but not skipping the display setting setup seems to fix it.
Hopefully if there is a better fix for this, this patch will spark
discussion around it.

Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")
Cc: Evan Quan <evan.quan@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Rex Zhu <Rex.Zhu@amd.com>
Cc: Likun Gao <Likun.Gao@amd.com>
Cc: <stable@vger.kernel.org> # v5.1+
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent f78c581
History
Tip revision: 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC
drm/amdgpu: Don't skip display settings in hwmgr_resume()
Tip revision: 688f3d1
File Mode Size
.gitignore -rw-r--r-- 20 bytes
active_mm.rst -rw-r--r-- 3.8 KB
balance.rst -rw-r--r-- 5.3 KB
cleancache.rst -rw-r--r-- 14.0 KB
conf.py -rw-r--r-- 236 bytes
frontswap.rst -rw-r--r-- 15.1 KB
highmem.rst -rw-r--r-- 5.4 KB
hmm.rst -rw-r--r-- 20.2 KB
hugetlbfs_reserv.rst -rw-r--r-- 28.8 KB
hwpoison.rst -rw-r--r-- 6.0 KB
index.rst -rw-r--r-- 1.1 KB
ksm.rst -rw-r--r-- 3.4 KB
memory-model.rst -rw-r--r-- 7.9 KB
mmu_notifier.rst -rw-r--r-- 4.1 KB
numa.rst -rw-r--r-- 8.6 KB
overcommit-accounting.rst -rw-r--r-- 2.6 KB
page_frags.rst -rw-r--r-- 2.3 KB
page_migration.rst -rw-r--r-- 11.6 KB
page_owner.rst -rw-r--r-- 3.8 KB
remap_file_pages.rst -rw-r--r-- 1.6 KB
slub.rst -rw-r--r-- 13.5 KB
split_page_table_lock.rst -rw-r--r-- 3.6 KB
swap_numa.rst -rw-r--r-- 3.0 KB
transhuge.rst -rw-r--r-- 8.4 KB
unevictable-lru.rst -rw-r--r-- 29.2 KB
z3fold.rst -rw-r--r-- 1.2 KB
zsmalloc.rst -rw-r--r-- 3.0 KB
zswap.rst -rw-r--r-- 6.3 KB

back to top