https://github.com/torvalds/linux
Revision 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC, committed by Alex Deucher on 01 July 2019, 14:15:00 UTC
I'm not entirely sure why this is, but for some reason:

921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")

Breaks runtime PM resume on the Radeon PRO WX 3100 (Lexa) in one the
pre-production laptops I have. The issue manifests as the following
messages in dmesg:

[drm] UVD and UVD ENC initialized successfully.
amdgpu 0000:3b:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vce1 test failed (-110)
[drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <vce_v3_0> failed -110
[drm:amdgpu_device_resume [amdgpu]] *ERROR* amdgpu_device_ip_resume failed (-110).

And happens after about 6-10 runtime PM suspend/resume cycles (sometimes
sooner, if you're lucky!). Unfortunately I can't seem to pin down
precisely which part in psm_adjust_power_state_dynamic that is causing
the issue, but not skipping the display setting setup seems to fix it.
Hopefully if there is a better fix for this, this patch will spark
discussion around it.

Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")
Cc: Evan Quan <evan.quan@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Rex Zhu <Rex.Zhu@amd.com>
Cc: Likun Gao <Likun.Gao@amd.com>
Cc: <stable@vger.kernel.org> # v5.1+
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent f78c581
History
Tip revision: 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC
drm/amdgpu: Don't skip display settings in hwmgr_resume()
Tip revision: 688f3d1
File Mode Size
Kconfig -rw-r--r-- 4.0 KB
Makefile -rw-r--r-- 1.3 KB
bat_algo.c -rw-r--r-- 5.6 KB
bat_algo.h -rw-r--r-- 733 bytes
bat_iv_ogm.c -rw-r--r-- 78.4 KB
bat_iv_ogm.h -rw-r--r-- 303 bytes
bat_v.c -rw-r--r-- 29.7 KB
bat_v.h -rw-r--r-- 827 bytes
bat_v_elp.c -rw-r--r-- 17.0 KB
bat_v_elp.h -rw-r--r-- 813 bytes
bat_v_ogm.c -rw-r--r-- 26.8 KB
bat_v_ogm.h -rw-r--r-- 761 bytes
bitarray.c -rw-r--r-- 2.6 KB
bitarray.h -rw-r--r-- 1.5 KB
bridge_loop_avoidance.c -rw-r--r-- 69.7 KB
bridge_loop_avoidance.h -rw-r--r-- 3.9 KB
debugfs.c -rw-r--r-- 13.5 KB
debugfs.h -rw-r--r-- 1.6 KB
distributed-arp-table.c -rw-r--r-- 52.0 KB
distributed-arp-table.h -rw-r--r-- 4.9 KB
fragmentation.c -rw-r--r-- 15.6 KB
fragmentation.h -rw-r--r-- 1.3 KB
gateway_client.c -rw-r--r-- 22.2 KB
gateway_client.h -rw-r--r-- 1.6 KB
gateway_common.c -rw-r--r-- 7.2 KB
gateway_common.h -rw-r--r-- 1.0 KB
hard-interface.c -rw-r--r-- 29.3 KB
hard-interface.h -rw-r--r-- 3.8 KB
hash.c -rw-r--r-- 1.7 KB
hash.h -rw-r--r-- 3.9 KB
icmp_socket.c -rw-r--r-- 10.1 KB
icmp_socket.h -rw-r--r-- 734 bytes
log.c -rw-r--r-- 5.4 KB
log.h -rw-r--r-- 4.0 KB
main.c -rw-r--r-- 20.3 KB
main.h -rw-r--r-- 12.2 KB
multicast.c -rw-r--r-- 52.7 KB
multicast.h -rw-r--r-- 2.5 KB
netlink.c -rw-r--r-- 40.6 KB
netlink.h -rw-r--r-- 946 bytes
network-coding.c -rw-r--r-- 58.2 KB
network-coding.h -rw-r--r-- 3.0 KB
originator.c -rw-r--r-- 41.6 KB
originator.h -rw-r--r-- 3.2 KB
routing.c -rw-r--r-- 36.6 KB
routing.h -rw-r--r-- 1.6 KB
send.c -rw-r--r-- 29.6 KB
send.h -rw-r--r-- 4.1 KB
soft-interface.c -rw-r--r-- 32.5 KB
soft-interface.h -rw-r--r-- 1.1 KB
sysfs.c -rw-r--r-- 35.2 KB
sysfs.h -rw-r--r-- 2.2 KB
tp_meter.c -rw-r--r-- 42.3 KB
tp_meter.h -rw-r--r-- 620 bytes
trace.c -rw-r--r-- 164 bytes
trace.h -rw-r--r-- 1.7 KB
translation-table.c -rw-r--r-- 132.7 KB
translation-table.h -rw-r--r-- 2.5 KB
tvlv.c -rw-r--r-- 18.7 KB
tvlv.h -rw-r--r-- 1.7 KB
types.h -rw-r--r-- 60.8 KB

back to top