https://github.com/torvalds/linux
Revision 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC, committed by Alex Deucher on 01 July 2019, 14:15:00 UTC
I'm not entirely sure why this is, but for some reason:

921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")

Breaks runtime PM resume on the Radeon PRO WX 3100 (Lexa) in one the
pre-production laptops I have. The issue manifests as the following
messages in dmesg:

[drm] UVD and UVD ENC initialized successfully.
amdgpu 0000:3b:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vce1 test failed (-110)
[drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <vce_v3_0> failed -110
[drm:amdgpu_device_resume [amdgpu]] *ERROR* amdgpu_device_ip_resume failed (-110).

And happens after about 6-10 runtime PM suspend/resume cycles (sometimes
sooner, if you're lucky!). Unfortunately I can't seem to pin down
precisely which part in psm_adjust_power_state_dynamic that is causing
the issue, but not skipping the display setting setup seems to fix it.
Hopefully if there is a better fix for this, this patch will spark
discussion around it.

Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")
Cc: Evan Quan <evan.quan@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Rex Zhu <Rex.Zhu@amd.com>
Cc: Likun Gao <Likun.Gao@amd.com>
Cc: <stable@vger.kernel.org> # v5.1+
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent f78c581
History
Tip revision: 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC
drm/amdgpu: Don't skip display settings in hwmgr_resume()
Tip revision: 688f3d1
File Mode Size
bnep
cmtp
hidp
rfcomm
6lowpan.c -rw-r--r-- 27.6 KB
Kconfig -rw-r--r-- 3.9 KB
Makefile -rw-r--r-- 720 bytes
a2mp.c -rw-r--r-- 21.4 KB
a2mp.h -rw-r--r-- 3.2 KB
af_bluetooth.c -rw-r--r-- 17.1 KB
amp.c -rw-r--r-- 13.8 KB
amp.h -rw-r--r-- 1.9 KB
ecdh_helper.c -rw-r--r-- 5.9 KB
ecdh_helper.h -rw-r--r-- 1.4 KB
hci_conn.c -rw-r--r-- 43.3 KB
hci_core.c -rw-r--r-- 106.9 KB
hci_debugfs.c -rw-r--r-- 24.7 KB
hci_debugfs.h -rw-r--r-- 1.6 KB
hci_event.c -rw-r--r-- 141.4 KB
hci_request.c -rw-r--r-- 70.6 KB
hci_request.h -rw-r--r-- 5.2 KB
hci_sock.c -rw-r--r-- 44.4 KB
hci_sysfs.c -rw-r--r-- 2.2 KB
l2cap_core.c -rw-r--r-- 180.8 KB
l2cap_sock.c -rw-r--r-- 36.8 KB
leds.c -rw-r--r-- 2.2 KB
leds.h -rw-r--r-- 554 bytes
lib.c -rw-r--r-- 3.3 KB
mgmt.c -rw-r--r-- 195.5 KB
mgmt_util.c -rw-r--r-- 6.2 KB
mgmt_util.h -rw-r--r-- 2.2 KB
sco.c -rw-r--r-- 24.5 KB
selftest.c -rw-r--r-- 8.5 KB
selftest.h -rw-r--r-- 1.6 KB
smp.c -rw-r--r-- 94.6 KB
smp.h -rw-r--r-- 5.0 KB

back to top