https://github.com/torvalds/linux
Revision 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC, committed by Alex Deucher on 01 July 2019, 14:15:00 UTC
I'm not entirely sure why this is, but for some reason:

921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")

Breaks runtime PM resume on the Radeon PRO WX 3100 (Lexa) in one the
pre-production laptops I have. The issue manifests as the following
messages in dmesg:

[drm] UVD and UVD ENC initialized successfully.
amdgpu 0000:3b:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vce1 test failed (-110)
[drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <vce_v3_0> failed -110
[drm:amdgpu_device_resume [amdgpu]] *ERROR* amdgpu_device_ip_resume failed (-110).

And happens after about 6-10 runtime PM suspend/resume cycles (sometimes
sooner, if you're lucky!). Unfortunately I can't seem to pin down
precisely which part in psm_adjust_power_state_dynamic that is causing
the issue, but not skipping the display setting setup seems to fix it.
Hopefully if there is a better fix for this, this patch will spark
discussion around it.

Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on needed")
Cc: Evan Quan <evan.quan@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Rex Zhu <Rex.Zhu@amd.com>
Cc: Likun Gao <Likun.Gao@amd.com>
Cc: <stable@vger.kernel.org> # v5.1+
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent f78c581
History
Tip revision: 688f3d1ebedffa310b6591bd1b63fa0770d945fe authored by Lyude Paul on 20 June 2019, 23:21:26 UTC
drm/amdgpu: Don't skip display settings in hwmgr_resume()
Tip revision: 688f3d1
File Mode Size
Kconfig -rw-r--r-- 28.7 KB
Makefile -rw-r--r-- 3.2 KB
act_api.c -rw-r--r-- 36.2 KB
act_bpf.c -rw-r--r-- 10.2 KB
act_connmark.c -rw-r--r-- 6.5 KB
act_csum.c -rw-r--r-- 16.8 KB
act_gact.c -rw-r--r-- 7.6 KB
act_ife.c -rw-r--r-- 20.4 KB
act_ipt.c -rw-r--r-- 10.5 KB
act_meta_mark.c -rw-r--r-- 1.7 KB
act_meta_skbprio.c -rw-r--r-- 1.7 KB
act_meta_skbtcindex.c -rw-r--r-- 1.8 KB
act_mirred.c -rw-r--r-- 11.4 KB
act_nat.c -rw-r--r-- 7.8 KB
act_pedit.c -rw-r--r-- 11.7 KB
act_police.c -rw-r--r-- 10.3 KB
act_sample.c -rw-r--r-- 7.5 KB
act_simple.c -rw-r--r-- 6.4 KB
act_skbedit.c -rw-r--r-- 9.3 KB
act_skbmod.c -rw-r--r-- 7.9 KB
act_tunnel_key.c -rw-r--r-- 16.3 KB
act_vlan.c -rw-r--r-- 8.4 KB
cls_api.c -rw-r--r-- 82.1 KB
cls_basic.c -rw-r--r-- 7.8 KB
cls_bpf.c -rw-r--r-- 16.6 KB
cls_cgroup.c -rw-r--r-- 5.0 KB
cls_flow.c -rw-r--r-- 16.5 KB
cls_flower.c -rw-r--r-- 68.9 KB
cls_fw.c -rw-r--r-- 10.0 KB
cls_matchall.c -rw-r--r-- 9.9 KB
cls_route.c -rw-r--r-- 14.3 KB
cls_rsvp.c -rw-r--r-- 547 bytes
cls_rsvp.h -rw-r--r-- 17.8 KB
cls_rsvp6.c -rw-r--r-- 554 bytes
cls_tcindex.c -rw-r--r-- 16.3 KB
cls_u32.c -rw-r--r-- 33.5 KB
em_canid.c -rw-r--r-- 5.3 KB
em_cmp.c -rw-r--r-- 1.9 KB
em_ipset.c -rw-r--r-- 2.9 KB
em_ipt.c -rw-r--r-- 5.9 KB
em_meta.c -rw-r--r-- 22.8 KB
em_nbyte.c -rw-r--r-- 1.6 KB
em_text.c -rw-r--r-- 3.4 KB
em_u32.c -rw-r--r-- 1.2 KB
ematch.c -rw-r--r-- 14.4 KB
sch_api.c -rw-r--r-- 53.7 KB
sch_atm.c -rw-r--r-- 19.5 KB
sch_blackhole.c -rw-r--r-- 924 bytes
sch_cake.c -rw-r--r-- 78.0 KB
sch_cbq.c -rw-r--r-- 41.8 KB
sch_cbs.c -rw-r--r-- 13.3 KB
sch_choke.c -rw-r--r-- 12.6 KB
sch_codel.c -rw-r--r-- 8.5 KB
sch_drr.c -rw-r--r-- 11.2 KB
sch_dsmark.c -rw-r--r-- 11.8 KB
sch_etf.c -rw-r--r-- 11.4 KB
sch_fifo.c -rw-r--r-- 4.2 KB
sch_fq.c -rw-r--r-- 24.1 KB
sch_fq_codel.c -rw-r--r-- 19.0 KB
sch_generic.c -rw-r--r-- 32.4 KB
sch_gred.c -rw-r--r-- 22.3 KB
sch_hfsc.c -rw-r--r-- 39.5 KB
sch_hhf.c -rw-r--r-- 21.4 KB
sch_htb.c -rw-r--r-- 41.4 KB
sch_ingress.c -rw-r--r-- 7.2 KB
sch_mq.c -rw-r--r-- 7.1 KB
sch_mqprio.c -rw-r--r-- 16.6 KB
sch_multiq.c -rw-r--r-- 8.6 KB
sch_netem.c -rw-r--r-- 30.9 KB
sch_pie.c -rw-r--r-- 15.7 KB
sch_plug.c -rw-r--r-- 6.4 KB
sch_prio.c -rw-r--r-- 9.5 KB
sch_qfq.c -rw-r--r-- 41.6 KB
sch_red.c -rw-r--r-- 10.5 KB
sch_sfb.c -rw-r--r-- 16.7 KB
sch_sfq.c -rw-r--r-- 22.3 KB
sch_skbprio.c -rw-r--r-- 7.5 KB
sch_taprio.c -rw-r--r-- 29.1 KB
sch_tbf.c -rw-r--r-- 13.5 KB
sch_teql.c -rw-r--r-- 11.8 KB

back to top